took in feedback

Author: hanniavalera

package.nls.json

@@ -251,11 +251,11 @@
     "cmake-tools.configuration.cmake.debugConfig.setupCommands.text.description": "Command to run.",
     "cmake-tools.configuration.cmake.debugConfig.setupCommands.description.description": "Description of the command.",
     "cmake-tools.configuration.cmake.launchConfig.markdownDescription": "Redirect the **CMake: Run Without Debugging** command (`cmake.launchTarget`) to either a VS Code task from `tasks.json` (`task` mode) or a custom external program (`program` mode). The active CMake target is still built first when `#cmake.buildBeforeRun#` is enabled, and its path is available via `${command:cmake.launchTargetPath}`. When set, this setting **fully replaces** `#cmake.debugConfig#`'s `args`, `cwd`, and `environment` on the launch path; provide equivalents inside `cmake.launchConfig` instead. The debug command (`cmake.debugTarget`) is unaffected. Only one of `task` or `program` may be set. When the delegated task itself depends on a CMake build (e.g. via `dependsOn`), consider setting `#cmake.buildBeforeRun#` to `false` to avoid building twice. When using `program`, the terminal lifecycle follows the `#cmake.launchBehavior#` setting (reuse, break-and-reuse, or new terminal).",
-    "cmake-tools.configuration.cmake.launchConfig.task.description": "Name of a task from `tasks.json` to run instead of launching the built executable. Accepts either a bare string label or `{ \"name\": \"...\", \"type\": \"...\" }` to disambiguate when multiple providers register tasks with the same name.",
+    "cmake-tools.configuration.cmake.launchConfig.task.description": "Name of a task from `tasks.json` to run instead of launching the built executable. Accepts either a bare string label or `{ \"name\": \"...\", \"type\": \"...\" }` to disambiguate when multiple providers register tasks with the same name. Mutually exclusive with `program`.",
     "cmake-tools.configuration.cmake.launchConfig.program.description": "Path to a custom program to run instead of the built executable. Supports `${command:cmake.launchTargetPath}` and other VS Code variable substitutions. Mutually exclusive with `task`.",
-    "cmake-tools.configuration.cmake.launchConfig.args.description": "Arguments to pass to the custom `program`. Each entry is shell-quoted before being sent to the integrated terminal.",
-    "cmake-tools.configuration.cmake.launchConfig.cwd.description": "Working directory for the custom `program`. Defaults to the directory of the built executable.",
-    "cmake-tools.configuration.cmake.launchConfig.environment.description": "Environment variables to set when running the custom `program`. Array of `{ \"name\": ..., \"value\": ... }` objects, mirroring `cmake.debugConfig.environment`.",
+    "cmake-tools.configuration.cmake.launchConfig.args.description": "Arguments to pass to the custom `program` (ignored in `task` mode). Each entry is shell-quoted before being sent to the integrated terminal.",
+    "cmake-tools.configuration.cmake.launchConfig.cwd.description": "Working directory for the custom `program` (ignored in `task` mode). Defaults to the directory of the built executable.",
+    "cmake-tools.configuration.cmake.launchConfig.environment.description": "Environment variables to set when running the custom `program` (ignored in `task` mode). Array of `{ \"name\": ..., \"value\": ... }` objects, mirroring `cmake.debugConfig.environment`.",
     "cmake-tools.launchConfig.task.notFound": "Task '{0}' referenced by cmake.launchConfig was not found.",
     "cmake-tools.launchConfig.task.executeFailed": "Failed to execute task \"{0}\" referenced by cmake.launchConfig: {1}",
     "cmake-tools.launchConfig.task.ambiguous": "Multiple tasks named '{0}' found; using the first. Specify 'type' in cmake.launchConfig.task to disambiguate.",
@@ -265,6 +265,7 @@
     "cmake-tools.launchConfig.debugConfigShadow.message": "cmake.launchConfig is set, so cmake.debugConfig.args, cmake.debugConfig.cwd, and cmake.debugConfig.environment will be ignored on the Run-Without-Debugging path. (cmake.debugConfig still applies when debugging.)",
     "cmake-tools.launchConfig.debugConfigShadow.openSettings": "Open Settings",
     "cmake-tools.launchConfig.debugConfigShadow.dontShowAgain": "Don't show again",
+    "cmake-tools.launchConfig.task.ignoredFields": "cmake.launchConfig: args, cwd, and environment are ignored in task mode. These settings only apply when using \"program\".",
     "cmake-tools.projectStatus.launchConfig.viaTask": "(via task: {0})",
     "cmake-tools.projectStatus.launchConfig.viaProgram": "(via program: {0})",
     "cmake-tools.configuration.cmake.defaultVariants.overall.description": "Configure the default variant settings.",

src/cmakeProject.ts

@@ -911,6 +911,7 @@ export class CMakeProject {
         this.termCloseSub.dispose();
         this.launchTaskEndSub.dispose();
         this.launchTerminals.forEach(term => term.dispose());
+        this.launchTerminals.clear();
         this.launchTaskExecutions.forEach(exec => exec.terminate());
         this.launchTaskExecutions.clear();
         for (const sub of [
@@ -3537,6 +3538,10 @@ export class CMakeProject {
      * `presentation.panel`/`isBackground` settings.
      */
     private async runLaunchAsTask(_executable: ExecutableTarget, cfg: LaunchConfig): Promise<void> {
+        if (cfg.args?.length || cfg.cwd || cfg.environment?.length) {
+            log.warning(localize('launchConfig.task.ignoredFields',
+                'cmake.launchConfig: args, cwd, and environment are ignored in task mode. These settings only apply when using "program".'));
+        }
         const ref: { name: string; type?: string } =
             typeof cfg.task === 'string' ? { name: cfg.task } : cfg.task!;
         const all = await vscode.tasks.fetchTasks(ref.type ? { type: ref.type } : undefined);

src/ui/projectStatus.ts

@@ -1132,6 +1132,7 @@ class LaunchTarget extends Node {
         }
     }
 
+    /** Releases the `config.onChange('launchConfig', ...)` subscription registered in `initialize()`. */
     dispose(): void {
         vscode.Disposable.from(...this.disposables).dispose();
     }