-
Notifications
You must be signed in to change notification settings - Fork 526
fix: suppress CMake file auto-reconfigure during command-initiated saves #4803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/fix-test-button-unsaved-cmakelists
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−1
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a373c3f
Initial plan
Copilot 1914ccd
fix: suppress CMakeLists.txt auto-reconfigure during command-initiate…
Copilot 9e952e8
restore accidentally deleted .npmrc file
Copilot 9024141
Merge branch 'main' into copilot/fix-test-button-unsaved-cmakelists
hanniavalera 1e9653b
Merge branch 'main' into copilot/fix-test-button-unsaved-cmakelists
hanniavalera 33e6a5f
rename _suppressCMakeListsReconfigure to _suppressCMakeFileReconfigure
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is a user-visible regression fix (avoids “Configuration is already in progress” when a command triggers saveAll with dirty CMake files), but there doesn’t appear to be coverage for it in the existing VS Code extension end-to-end tests. Adding a test that dirties CMakeLists.txt (or an included .cmake), triggers a command that calls maybeAutoSaveAll() (e.g., runTests/build), and asserts no overlapping configure is started would help prevent regressions.