Agent Debug: Remove dead code and default file logging to off (#4400)

* Chat Debug: Remove dead code and turn off flag by default

* rename

* migrate

* test fix

Author: vijayupadya

package.json

@@ -4525,21 +4525,21 @@
 							"onExp"
 						]
 					},
-					"github.copilot.chat.chatDebug.fileLogging.enabled": {
+					"github.copilot.chat.agentDebugLog.fileLogging.enabled": {
 						"type": "boolean",
-						"default": true,
-						"markdownDescription": "%github.copilot.config.chatDebug.fileLogging.enabled%",
+						"default": false,
+						"markdownDescription": "%github.copilot.config.agentDebugLog.fileLogging.enabled%",
 						"tags": [
 							"advanced",
 							"experimental",
 							"onExp"
 						]
 					},
-					"github.copilot.chat.chatDebug.fileLogging.flushIntervalMs": {
+					"github.copilot.chat.agentDebugLog.fileLogging.flushIntervalMs": {
 						"type": "number",
 						"default": 4000,
 						"minimum": 2000,
-						"markdownDescription": "%github.copilot.config.chatDebug.fileLogging.flushIntervalMs%",
+						"markdownDescription": "%github.copilot.config.agentDebugLog.fileLogging.flushIntervalMs%",
 						"tags": [
 							"advanced",
 							"experimental"

package.nls.json

@@ -373,8 +373,8 @@
 	"github.copilot.config.editRecording.enabled": "Enable edit recording for analysis.",
 	"github.copilot.config.inlineChat.selectionRatioThreshold": "Threshold at which to switch editing strategies for inline chat. When a selection porition of code matches a parse tree node, only that is presented to the language model. This speeds up response times but might have lower quality results. Requires having a parse tree for the document and the `inlineChat.enableV2` setting. Values must be between 0 and 1, where 0 means off and 1 means the selection perfectly matches a parse tree node.",
 	"github.copilot.config.debug.requestLogger.maxEntries": "Maximum number of entries to keep in the request logger for debugging purposes.",
-	"github.copilot.config.chatDebug.fileLogging.enabled": "Enable writing chat debug events to JSONL files on disk for diagnostics. When disabled, the built-in `troubleshoot` skill is also disabled. Requires VS Code reload.",
-	"github.copilot.config.chatDebug.fileLogging.flushIntervalMs": "How often (in milliseconds) buffered debug log entries are flushed to disk. Lower values provide more up-to-date logs at the cost of more frequent disk writes.",
+	"github.copilot.config.agentDebugLog.fileLogging.enabled": "Enable writing chat debug events to JSONL files on disk for diagnostics. When disabled, the built-in `troubleshoot` skill is also disabled. Requires VS Code reload.",
+	"github.copilot.config.agentDebugLog.fileLogging.flushIntervalMs": "How often (in milliseconds) buffered debug log entries are flushed to disk. Lower values provide more up-to-date logs at the cost of more frequent disk writes.",
 	"github.copilot.config.inlineEdits.diagnosticsContextProvider.enabled": "Enable diagnostics context provider for next edit suggestions.",
 	"github.copilot.config.inlineEdits.chatSessionContextProvider.enabled": "Enable chat session context provider for next edit suggestions.",
 	"github.copilot.config.codesearch.agent.enabled": "Enable code search capabilities in agent mode.",