Live debug log entries for NES inline edit requests (#4649)

* Enhance inline edit logging with live updates and dynamic content resolution

* Fix "In progress" not clearing by using explicit completion flag

The "In progress" indicator was inferred from result/error fields being unset,
but many terminal code paths (markAsNoSuggestions, setIsSkipped, early returns
in the provider) never set those fields. Replace with an explicit _isCompleted
flag set via markCompleted() in the finally block, which always runs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address PR review comments for live debug log entries

- Dispose per-entry subscriptions when entries are evicted from RequestLogger
- Throttle tree refreshes (200ms debounce) while keeping document updates immediate
- Fire 'latest' document change event when the updated entry is the most recent
- Use resolveMarkdownContent() in TestLoggedRequestInfo.toJSON()
- Add fireDidChange() to all state-mutating methods in InlineEditRequestLogContext
- Prune _liveRequestIds when evicting entries in InlineEditLogger
- Add isVisible predicate to IMarkdownContentRequest for dynamic tree filtering

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: ulugbekna

src/extension/inlineEdits/vscode-node/inlineCompletionProvider.ts

@@ -273,6 +273,7 @@ export class InlineCompletionProviderImpl extends Disposable implements InlineCo
 		const documentVersion = (isNotebookCell(document.uri) ? findNotebook(document.uri, workspace.notebookDocuments)?.version : undefined) || document.version;
 		const logContext = new InlineEditRequestLogContext(doc.id.uri, documentVersion, context);
 		logContext.recordingBookmark = this.model.debugRecorder.createBookmark();
+		this.logger.addLive(logContext);
 
 		const telemetryBuilder = new NextEditProviderTelemetryBuilder(this._gitExtensionService, this._notebookService, this._workspaceService, this.model.nextEditProvider.ID, doc, this.model.debugRecorder, logContext.recordingBookmark);
 		telemetryBuilder.setOpportunityId(context.requestUuid);
@@ -477,6 +478,7 @@ export class InlineCompletionProviderImpl extends Disposable implements InlineCo
 
 			throw e;
 		} finally {
+			logContext.markCompleted();
 			requestCancellationTokenSource.dispose();
 			this.logger.add(logContext);
 		}

src/extension/inlineEdits/vscode-node/parts/inlineEditLogger.ts

@@ -9,14 +9,38 @@ import { Disposable } from '../../../../util/vs/base/common/lifecycle';
 
 export class InlineEditLogger extends Disposable {
 	private readonly _requests: InlineEditRequestLogContext[] = [];
+	private readonly _liveRequestIds = new Set<number>();
 
 	constructor(
 		@IRequestLogger private readonly _requestLogger: IRequestLogger,
 	) {
 		super();
 	}
 
+	/**
+	 * Add a live log entry that appears immediately in the tree with dynamic content.
+	 * Content and icon are resolved on-demand from the logContext, and the entry
+	 * refreshes automatically as the logContext state changes.
+	 */
+	addLive(request: InlineEditRequestLogContext): void {
+		this._liveRequestIds.add(request.requestId);
+		this._requestLogger.addEntry({
+			type: LoggedRequestKind.MarkdownContentRequest,
+			debugName: request.getDebugName(),
+			icon: () => request.getIcon(),
+			startTimeMs: request.time,
+			markdownContent: () => request.toLogDocument(),
+			onDidChange: request.onDidChange,
+			isVisible: () => request.includeInLogTree,
+		});
+		this._pushRequest(request);
+	}
+
 	add(request: InlineEditRequestLogContext): void {
+		if (this._liveRequestIds.has(request.requestId)) {
+			return; // already added as a live entry
+		}
+
 		if (!request.includeInLogTree) {
 			return;
 		}
@@ -28,10 +52,16 @@ export class InlineEditLogger extends Disposable {
 			startTimeMs: request.time,
 			markdownContent: request.toLogDocument(),
 		});
-		this._requests.push(request);
+		this._pushRequest(request);
+	}
 
+	private _pushRequest(request: InlineEditRequestLogContext): void {
+		this._requests.push(request);
 		if (this._requests.length > 100) {
-			this._requests.shift();
+			const evicted = this._requests.shift();
+			if (evicted) {
+				this._liveRequestIds.delete(evicted.requestId);
+			}
 		}
 	}
 

src/extension/log/vscode-node/requestLogTree.ts

@@ -13,7 +13,7 @@ import * as vscode from 'vscode';
 import { IVSCodeExtensionContext } from '../../../platform/extContext/common/extensionContext';
 import { outputChannel } from '../../../platform/log/vscode/outputChannelLogTarget';
 import { CapturingToken } from '../../../platform/requestLogger/common/capturingToken';
-import { ChatRequestScheme, ILoggedElementInfo, ILoggedRequestInfo, ILoggedToolCall, IRequestLogger, LoggedInfo, LoggedInfoKind, LoggedRequestKind } from '../../../platform/requestLogger/node/requestLogger';
+import { ChatRequestScheme, ILoggedElementInfo, ILoggedRequestInfo, ILoggedToolCall, IRequestLogger, LoggedInfo, LoggedInfoKind, LoggedRequestKind, resolveMarkdownIcon } from '../../../platform/requestLogger/node/requestLogger';
 import { filterMap } from '../../../util/common/arrays';
 import { assert, assertNever } from '../../../util/vs/base/common/assert';
 import { Disposable, toDisposable } from '../../../util/vs/base/common/lifecycle';
@@ -600,6 +600,13 @@ class ChatRequestProvider extends Disposable implements vscode.TreeDataProvider<
 			const tokenToPrompt = new Map<CapturingToken, ChatPromptItem>();
 
 			for (const currReq of this.requestLogger.getRequests()) {
+				// Skip entries that are dynamically hidden (e.g. skipped/cancelled live NES requests)
+				if (currReq.kind === LoggedInfoKind.Request &&
+					currReq.entry.type === LoggedRequestKind.MarkdownContentRequest &&
+					currReq.entry.isVisible && !currReq.entry.isVisible()) {
+					continue;
+				}
+
 				const currReqTreeItem = this.logToTreeItem(currReq);
 
 				if (!currReq.token) {
@@ -784,7 +791,8 @@ class ChatRequestItem extends vscode.TreeItem {
 		this.id = info.id;
 
 		if (info.entry.type === LoggedRequestKind.MarkdownContentRequest) {
-			this.iconPath = info.entry.icon === undefined ? undefined : new vscode.ThemeIcon(info.entry.icon.id);
+			const resolvedIcon = resolveMarkdownIcon(info.entry);
+			this.iconPath = resolvedIcon === undefined ? undefined : new vscode.ThemeIcon(resolvedIcon.id);
 			const startTimeStr = new Date(info.entry.startTimeMs).toLocaleTimeString([], { hour: '2-digit', minute: '2-digit' });
 			this.description = startTimeStr;
 		} else {

src/extension/prompt/vscode-node/requestLoggerImpl.ts

@@ -16,13 +16,14 @@ import { ContextManagementResponse } from '../../../platform/networking/common/a
 import { IResponseDelta, isOpenAiFunctionTool } from '../../../platform/networking/common/fetch';
 import { IEndpointBody } from '../../../platform/networking/common/networking';
 import { CapturingToken } from '../../../platform/requestLogger/common/capturingToken';
-import { AbstractRequestLogger, ChatRequestScheme, ILoggedElementInfo, ILoggedRequestInfo, ILoggedToolCall, LoggedInfo, LoggedInfoKind, LoggedRequest, LoggedRequestKind } from '../../../platform/requestLogger/node/requestLogger';
+import { AbstractRequestLogger, ChatRequestScheme, ILoggedElementInfo, ILoggedRequestInfo, ILoggedToolCall, LoggedInfo, LoggedInfoKind, LoggedRequest, LoggedRequestKind, resolveMarkdownContent } from '../../../platform/requestLogger/node/requestLogger';
 import { ThinkingData } from '../../../platform/thinking/common/thinking';
 import { createFencedCodeBlock } from '../../../util/common/markdown';
 import { assertNever } from '../../../util/vs/base/common/assert';
 import { Codicon } from '../../../util/vs/base/common/codicons';
-import { Emitter, Event } from '../../../util/vs/base/common/event';
+import { Emitter } from '../../../util/vs/base/common/event';
 import { Iterable } from '../../../util/vs/base/common/iterator';
+import { IDisposable } from '../../../util/vs/base/common/lifecycle';
 import { generateUuid } from '../../../util/vs/base/common/uuid';
 import { IInstantiationService } from '../../../util/vs/platform/instantiation/common/instantiation';
 import { renderDataPartToString, renderToolResultToStringNoBudget } from './requestLoggerToolResult';
@@ -138,7 +139,7 @@ class LoggedRequestInfo implements ILoggedRequestInfo {
 			return {
 				...baseInfo,
 				startTime: new Date(this.entry.startTimeMs).toISOString(),
-				content: this.entry.markdownContent
+				content: resolveMarkdownContent(this.entry)
 			};
 		}
 
@@ -274,7 +275,9 @@ export class RequestLogger extends AbstractRequestLogger {
 
 	private _didRegisterLinkProvider = false;
 	private readonly _entries: LoggedInfo[] = [];
+	private readonly _entryDisposables = new Map<string, IDisposable>();
 	private _workspaceEditRecorder: WorkspaceEditRecorder | undefined;
+	private readonly _onDidChangeDocument = this._register(new Emitter<Uri>());
 
 	constructor(
 		@ILogService private readonly _logService: ILogService,
@@ -285,7 +288,7 @@ export class RequestLogger extends AbstractRequestLogger {
 
 
 		this._register(workspace.registerTextDocumentContentProvider(ChatRequestScheme.chatRequestScheme, {
-			onDidChange: Event.map(this.onDidChangeRequests, () => Uri.parse(ChatRequestScheme.buildUri({ kind: 'latest' }))),
+			onDidChange: this._onDidChangeDocument.event,
 			provideTextDocumentContent: (uri) => {
 				const parseResult = ChatRequestScheme.parseUri(uri.toString());
 				if (!parseResult) { return `Invalid URI: ${uri}`; }
@@ -409,6 +412,30 @@ export class RequestLogger extends AbstractRequestLogger {
 				if (ok) {
 					this._ensureLinkProvider();
 
+					// Subscribe to live entry changes for dynamic content/icon refresh
+					if (entry.type === LoggedRequestKind.MarkdownContentRequest && entry.onDidChange) {
+						let treeRefreshTimeout: ReturnType<typeof setTimeout> | undefined;
+						const subscription = entry.onDidChange(() => {
+							// Always update the virtual document immediately for streaming content
+							this._onDidChangeDocument.fire(Uri.parse(ChatRequestScheme.buildUri({ kind: 'request', id })));
+
+							// Also refresh the "latest" document if this is the most recent entry
+							if (this._entries.at(-1)?.id === id) {
+								this._onDidChangeDocument.fire(Uri.parse(ChatRequestScheme.buildUri({ kind: 'latest' })));
+							}
+
+							// Throttle tree refreshes to avoid frequent expensive updates on streaming changes
+							if (treeRefreshTimeout !== undefined) {
+								clearTimeout(treeRefreshTimeout);
+							}
+							treeRefreshTimeout = setTimeout(() => {
+								this._onDidChangeRequests.fire();
+								treeRefreshTimeout = undefined;
+							}, 200);
+						});
+						this._entryDisposables.set(id, subscription);
+					}
+
 					let extraData: string;
 					if (entry.type === LoggedRequestKind.MarkdownContentRequest) {
 						extraData = 'markdown';
@@ -457,9 +484,14 @@ export class RequestLogger extends AbstractRequestLogger {
 		this._entries.push(entry);
 		const maxEntries = this._configService.getConfig(ConfigKey.Advanced.RequestLoggerMaxEntries);
 		if (this._entries.length > maxEntries) {
-			this._entries.shift();
+			const evicted = this._entries.shift();
+			if (evicted) {
+				this._entryDisposables.get(evicted.id)?.dispose();
+				this._entryDisposables.delete(evicted.id);
+			}
 		}
 		this._onDidChangeRequests.fire();
+		this._onDidChangeDocument.fire(Uri.parse(ChatRequestScheme.buildUri({ kind: 'latest' })));
 		return true;
 	}
 
@@ -570,7 +602,7 @@ export class RequestLogger extends AbstractRequestLogger {
 
 	private _renderRequestToMarkdown(id: string, entry: LoggedRequest): string {
 		if (entry.type === LoggedRequestKind.MarkdownContentRequest) {
-			return entry.markdownContent;
+			return resolveMarkdownContent(entry);
 		}
 
 		const result: string[] = [];

src/platform/inlineEdits/common/inlineEditLogContext.ts

@@ -8,6 +8,7 @@ import type { InlineCompletionContext } from 'vscode';
 import * as yaml from 'yaml';
 import { ErrorUtils } from '../../../util/common/errors';
 import { isCancellationError } from '../../../util/vs/base/common/errors';
+import { Emitter, Event } from '../../../util/vs/base/common/event';
 import { ThemeIcon } from '../../../util/vs/base/common/themables';
 import { SerializedLineEdit } from '../../../util/vs/editor/common/core/edits/lineEdit';
 import { SerializedEdit } from './dataTypes/editUtils';
@@ -39,6 +40,22 @@ export class InlineEditRequestLogContext {
 		return this._isVisible;
 	}
 
+	private _isCompleted: boolean = false;
+
+	/** Mark this request as completed (no longer in progress). */
+	markCompleted(): void {
+		this._isCompleted = true;
+		this.fireDidChange();
+	}
+
+	private readonly _onDidChange = new Emitter<void>();
+	/** Fires when state changes, allowing live log entries to refresh their content. */
+	public readonly onDidChange: Event<void> = this._onDidChange.event;
+
+	protected fireDidChange(): void {
+		this._onDidChange.fire();
+	}
+
 	constructor(
 		public readonly filePath: string,
 		public readonly version: number,
@@ -51,6 +68,10 @@ export class InlineEditRequestLogContext {
 		const lines: string[] = [];
 		lines.push('# ' + this.getMarkdownTitle() + ` (Request #${this.requestId})`);
 
+		if (!this._isCompleted) {
+			lines.push('\n⏳ **In progress…**\n');
+		}
+
 		lines.push('💡 Tip: double-click anywhere to open this file as text to copy-paste content into an issue.\n');
 
 		lines.push('<details><summary>Explanation for icons</summary>\n');
@@ -219,20 +240,23 @@ export class InlineEditRequestLogContext {
 	setRequestInput(nextEditRequest: StatelessNextEditRequest): void {
 		this._isVisible = true;
 		this._nextEditRequest = nextEditRequest;
+		this.fireDidChange();
 	}
 
 	private _resultEdit: RootedLineEdit | string | undefined = undefined;
 
 	setResult(resultEditOrPatchString: RootedLineEdit | string) {
 		this._isVisible = true;
 		this._resultEdit = resultEditOrPatchString;
+		this.fireDidChange();
 	}
 
 	protected _diagnosticsResultEdit: RootedLineEdit | undefined = undefined;
 
 	setDiagnosticsResult(resultEdit: RootedLineEdit) {
 		this._isVisible = true;
 		this._diagnosticsResultEdit = resultEdit;
+		this.fireDidChange();
 	}
 
 	private _nesTypePicked: 'llm' | 'diagnostics' | undefined;
@@ -286,12 +310,14 @@ export class InlineEditRequestLogContext {
 
 		this._isVisible = true;
 		this._icon = Icon.database;
+		this.fireDidChange();
 	}
 
 	private _endpointInfo: { url: string; modelName: string } | undefined;
 
 	public setEndpointInfo(url: string, modelName: string): void {
 		this._endpointInfo = { url, modelName };
+		this.fireDidChange();
 	}
 
 	public get endpointInfo(): { url: string; modelName: string } | undefined {
@@ -301,6 +327,7 @@ export class InlineEditRequestLogContext {
 	private _headerRequestId: string | undefined = undefined;
 	public setHeaderRequestId(headerRequestId: string): void {
 		this._headerRequestId = headerRequestId;
+		this.fireDidChange();
 	}
 	get headerRequestId(): string | undefined {
 		return this._headerRequestId;
@@ -319,6 +346,7 @@ export class InlineEditRequestLogContext {
 		} else {
 			this._prompt = stringifyChatMessages(prompt);
 		}
+		this.fireDidChange();
 	}
 
 	private _icon: Icon.t | undefined;
@@ -330,16 +358,19 @@ export class InlineEditRequestLogContext {
 	public setIsSkipped() {
 		this._isVisible = false;
 		this._icon = Icon.skipped;
+		this.fireDidChange();
 	}
 
 	public markAsFromCache() {
 		this._isVisible = true;
 		this._icon = Icon.database;
+		this.fireDidChange();
 	}
 
 	public markAsNoSuggestions() {
 		this._isVisible = true;
 		this._icon = Icon.circleSlash;
+		this.fireDidChange();
 	}
 
 	private error: unknown | undefined = undefined;
@@ -354,6 +385,7 @@ export class InlineEditRequestLogContext {
 		} else {
 			this._icon = Icon.error;
 		}
+		this.fireDidChange();
 	}
 
 	/**
@@ -363,6 +395,7 @@ export class InlineEditRequestLogContext {
 	setResponse(v: string): void {
 		this._isVisible = true;
 		this.response = v;
+		this.fireDidChange();
 	}
 
 	private fullResponsePromise: Promise<string | undefined> | undefined = undefined;
@@ -379,21 +412,25 @@ export class InlineEditRequestLogContext {
 	private providerStartTime: number | undefined = undefined;
 	setProviderStartTime(): void {
 		this.providerStartTime = Date.now();
+		this.fireDidChange();
 	}
 
 	private providerEndTime: number | undefined = undefined;
 	setProviderEndTime(): void {
 		this.providerEndTime = Date.now();
+		this.fireDidChange();
 	}
 
 	private fetchStartTime: number | undefined = undefined;
 	setFetchStartTime(): void {
 		this.fetchStartTime = Date.now();
+		this.fireDidChange();
 	}
 
 	private fetchEndTime: number | undefined = undefined;
 	setFetchEndTime(): void {
 		this.fetchEndTime = Date.now();
+		this.fireDidChange();
 	}
 
 	/**
@@ -409,6 +446,7 @@ export class InlineEditRequestLogContext {
 		this._isVisible = true;
 		this._responseResults = v;
 		this._icon ??= Icon.lightbulbFull;
+		this.fireDidChange();
 	}
 
 	getDebugName(): string {
@@ -429,6 +467,7 @@ export class InlineEditRequestLogContext {
 	private _trace: string[] = [];
 	trace(msg: string): void {
 		this._trace.push(msg);
+		this.fireDidChange();
 	}
 
 	private _renderTraceDiagram(): string[] {
@@ -572,6 +611,7 @@ export class InlineEditRequestLogContext {
 	private _logs: string[] = [];
 	addLog(content: string): void {
 		this._logs.push(content.replace('\n', '\\n').replace('\t', '\\t').replace('`', '\`') + '\n');
+		this.fireDidChange();
 	}
 
 	private _rebaseFailure: MarkdownLoggable | undefined;