Remove test generation commands and related configurations from Copilot Chat (#3937)

* Remove test generation commands and related configurations from Copilot Chat

* Remove unused TestGenLensContribution import from contributions.ts

Author: jrieken

.vscode/settings.json

@@ -138,7 +138,6 @@
 		"scoredEdits.w.json": "https://microsoft.github.io/vscode-workbench-recorder-viewer/?editRating",
 		"workspaceRecording.jsonl": "https://microsoft.github.io/vscode-workbench-recorder-viewer/?jsonl=true",
 	},
-	"github.copilot.chat.generateTests.codeLens": true,
 	"explorer.fileNesting.patterns": {
 		"vscode.d.ts": "vscode.proposed.*.ts",
 	},

package.json

@@ -2349,18 +2349,6 @@
 				"enablement": "!github.copilot.interactiveSession.disabled && !editorReadonly",
 				"category": "Chat"
 			},
-			{
-				"command": "github.copilot.chat.generateDocs",
-				"title": "%github.copilot.command.generateDocs%",
-				"enablement": "!github.copilot.interactiveSession.disabled && !editorReadonly",
-				"category": "Chat"
-			},
-			{
-				"command": "github.copilot.chat.generateTests",
-				"title": "%github.copilot.command.generateTests%",
-				"enablement": "!github.copilot.interactiveSession.disabled && !editorReadonly",
-				"category": "Chat"
-			},
 			{
 				"command": "github.copilot.chat.fix",
 				"title": "%github.copilot.command.fixThis%",
@@ -3507,14 +3495,6 @@
 							"experimental"
 						]
 					},
-					"github.copilot.chat.generateTests.codeLens": {
-						"type": "boolean",
-						"default": false,
-						"description": "%github.copilot.config.generateTests.codeLens%",
-						"tags": [
-							"experimental"
-						]
-					},
 					"github.copilot.chat.setupTests.enabled": {
 						"type": "boolean",
 						"default": true,
@@ -4527,10 +4507,20 @@
 				}
 			],
 			"editor/context": [
+				{
+					"command": "github.copilot.chat.fix",
+					"when": "!github.copilot.interactiveSession.disabled && !editorReadonly && editorSelectionHasDiagnostics",
+					"group": "1_chat@4"
+				},
 				{
 					"command": "github.copilot.chat.explain",
 					"when": "!github.copilot.interactiveSession.disabled",
-					"group": "1_chat@4"
+					"group": "1_chat@5"
+				},
+				{
+					"command": "github.copilot.chat.review",
+					"when": "config.github.copilot.chat.reviewSelection.enabled && !github.copilot.interactiveSession.disabled && resourceScheme != 'vscode-chat-code-block'",
+					"group": "1_chat@6"
 				},
 				{
 					"command": "github.copilot.chat.copilotCLI.addFileReference",
@@ -4543,28 +4533,6 @@
 					"when": "github.copilot.chat.copilotCLI.hasSession && editorHasSelection && !inOutput && resourceScheme != 'vscode-webview' && resourceScheme != 'webview-panel'"
 				}
 			],
-			"editor/context/chat": [
-				{
-					"command": "github.copilot.chat.fix",
-					"when": "!github.copilot.interactiveSession.disabled && !editorReadonly",
-					"group": "copilotAction@1"
-				},
-				{
-					"command": "github.copilot.chat.review",
-					"when": "config.github.copilot.chat.reviewSelection.enabled && !github.copilot.interactiveSession.disabled && resourceScheme != 'vscode-chat-code-block'",
-					"group": "copilotAction@2"
-				},
-				{
-					"command": "github.copilot.chat.generateDocs",
-					"when": "!github.copilot.interactiveSession.disabled && !editorReadonly",
-					"group": "copilotGenerate@1"
-				},
-				{
-					"command": "github.copilot.chat.generateTests",
-					"when": "!github.copilot.interactiveSession.disabled && !editorReadonly",
-					"group": "copilotGenerate@2"
-				}
-			],
 			"chat/editor/inlineGutter": [
 				{
 					"command": "github.copilot.chat.explain",

package.nls.json

@@ -26,8 +26,6 @@
 	"github.copilot.command.unhelpfulReviewSuggestion": "Unhelpful",
 	"github.copilot.command.fixThis": "Fix",
 	"github.copilot.command.generateThis": "Generate This",
-	"github.copilot.command.generateDocs": "Generate Docs",
-	"github.copilot.command.generateTests": "Generate Tests",
 	"github.copilot.command.openUserPreferences": "Open User Preferences",
 	"github.copilot.command.openMemoryFolder": "Open Memory Folder",
 	"github.copilot.command.sendChatFeedback": "Send Chat Feedback",
@@ -158,7 +156,6 @@
 	"github.copilot.config.pullRequestDescriptionGeneration.instructions": "A set of instructions that will be added to Copilot requests that generate pull request titles and descriptions.\nInstructions can come from: \n- a file in the workspace: `{ \"file\": \"fileName\" }`\n- text in natural language: `{ \"text\": \"Always include a list of key changes.\" }`\n\nNote: Keep your instructions short and precise. Poor instructions can degrade Copilot's quality and performance.",
 	"github.copilot.config.pullRequestDescriptionGeneration.instruction.text": "Text instructions that will be added to Copilot requests that generate pull request titles and descriptions.",
 	"github.copilot.config.pullRequestDescriptionGeneration.instruction.file": "A path to a file with instructions that will be added to Copilot requests that generate pull request titles and descriptions.",
-	"github.copilot.config.generateTests.codeLens": "Show 'Generate tests' code lens for symbols that are not covered by current test coverage information.",
 	"github.copilot.config.notebook.followCellExecution": "Controls whether the currently executing cell is revealed into the viewport upon execution from Copilot.",
 	"github.copilot.config.notebook.enhancedNextEditSuggestions": "Controls whether to use an enhanced approach for generating next edit suggestions in notebook cells.",
 	"github.copilot.config.imageUpload.enabled": "Enables the use of image upload URLs in chat requests instead of raw base64 strings.",

src/extension/configuration/vscode-node/configurationMigration.ts

@@ -152,16 +152,6 @@ ConfigurationMigrationRegistry.registerConfigurationMigrations([{
 	}
 }]);
 
-ConfigurationMigrationRegistry.registerConfigurationMigrations([{
-	key: 'github.copilot.chat.experimental.generateTests.codeLens',
-	migrateFn: async (value: any) => {
-		return [
-			['github.copilot.chat.generateTests.codeLens', { value }],
-			['github.copilot.chat.experimental.generateTests.codeLens', { value: undefined }]
-		];
-	}
-}]);
-
 ConfigurationMigrationRegistry.registerConfigurationMigrations([{
 	key: 'github.copilot.chat.planAgent.model',
 	migrateFn: async (value: any) => {

src/extension/extension/vscode-node/contributions.ts

@@ -29,7 +29,6 @@ import { GitHubMcpContrib } from '../../githubMcp/vscode-node/githubMcp.contribu
 import { IgnoredFileProviderContribution } from '../../ignore/vscode-node/ignoreProvider';
 import { JointCompletionsProviderContribution } from '../../inlineEdits/vscode-node/jointInlineCompletionProvider';
 import { FixTestFailureContribution } from '../../intents/vscode-node/fixTestFailureContributions';
-import { TestGenLensContribution } from '../../intents/vscode-node/testGenLens';
 import { ExtensionStateCommandContribution } from '../../log/vscode-node/extensionStateCommand';
 import { FetcherTelemetryContribution, LoggingActionsContrib } from '../../log/vscode-node/loggingActions';
 import { RequestLogTree } from '../../log/vscode-node/requestLogTree';
@@ -110,7 +109,6 @@ export const vscodeNodeContributions: IExtensionContributionFactory[] = [
 */
 export const vscodeNodeChatContributions: IExtensionContributionFactory[] = [
 	asContributionFactory(ConfigurationMigrationContribution),
-	asContributionFactory(TestGenLensContribution),
 	asContributionFactory(RequestLogTree),
 	asContributionFactory(OnboardTerminalTestsContribution),
 	asContributionFactory(ToolsContribution),

src/extension/inlineChat/vscode-node/inlineChatCodeActions.ts

@@ -84,6 +84,10 @@ export class QuickFixesProvider implements vscode.CodeActionProvider {
 			codeActions.push(altTextQuickFixes);
 		}
 
+		if (vscode.workspace.getConfiguration('inlineChat').get('affordance') !== 'off') {
+			return codeActions;
+		}
+
 		if (this.reviewService.isCodeFeedbackEnabled() && !activeTextEditor.selection.isEmpty) {
 			const reviewAction = new AICodeAction(vscode.l10n.t('Review'), QuickFixesProvider.reviewKind);
 			reviewAction.command = {

src/extension/inlineChat/vscode-node/inlineChatCommands.ts

@@ -27,9 +27,7 @@ import * as path from '../../../util/vs/base/common/path';
 import { URI } from '../../../util/vs/base/common/uri';
 import { IInstantiationService, ServicesAccessor } from '../../../util/vs/platform/instantiation/common/instantiation';
 import { Intent } from '../../common/constants';
-import { InlineDocIntent } from '../../intents/node/docIntent';
 import { explainIntentPromptSnippet } from '../../intents/node/explainIntent';
-import { GenerateTests } from '../../intents/vscode-node/testGenAction';
 import { ChatParticipantRequestHandler } from '../../prompt/node/chatParticipantRequestHandler';
 import { sendReviewActionTelemetry } from '../../prompt/node/feedbackGenerator';
 import { CurrentSelection } from '../../prompts/node/panel/currentSelection';
@@ -240,21 +238,6 @@ ${message}`,
 	const doGenerate = () => {
 		return vscode.commands.executeCommand('vscode.editorChat.start', { message: '/generate ' });
 	};
-	const doGenerateDocs = () => {
-		return vscode.commands.executeCommand('vscode.editorChat.start', { message: `/${InlineDocIntent.ID} `, autoSend: true, initialRange: vscode.window.activeTextEditor?.selection });
-	};
-	const doGenerateTests = (arg?: unknown) => {
-		// @ulugbekna: `github.copilot.chat.generateTests` is invoked from editor context menu, which means
-		// 	the first arguments can be a vscode.Uri
-		const context =
-			(arg && typeof arg === 'object' &&
-				'document' in arg && arg.document && typeof arg.document === 'object' && 'getText' in arg.document &&
-				'selection' in arg && arg.selection instanceof vscode.Range
-			)
-				? arg as { document: vscode.TextDocument; selection: vscode.Range }
-				: undefined;
-		return instaService.createInstance(GenerateTests).runCommand(context);
-	};
 	const doFix = () => {
 		const activeDocument = vscode.window.activeTextEditor;
 		if (!activeDocument) {
@@ -305,8 +288,6 @@ ${message}`,
 	disposables.add(vscode.commands.registerCommand('github.copilot.chat.review.next', thread => goToNextReview(thread, +1)));
 	disposables.add(vscode.commands.registerCommand('github.copilot.chat.review.current', thread => goToNextReview(thread, 0)));
 	disposables.add(vscode.commands.registerCommand('github.copilot.chat.generate', doGenerate));
-	disposables.add(vscode.commands.registerCommand('github.copilot.chat.generateDocs', doGenerateDocs));
-	disposables.add(vscode.commands.registerCommand('github.copilot.chat.generateTests', doGenerateTests));
 	disposables.add(vscode.commands.registerCommand('github.copilot.chat.fix', doFix));
 	disposables.add(vscode.commands.registerCommand('github.copilot.chat.generateAltText', doGenerateAltText));
 	// register code actions