This repository was archived by the owner on May 20, 2026. It is now read-only.
nes: logContext: show correct proposed edits#1045
Merged
ulugbekna merged 1 commit intoOct 1, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes logging to display the correct proposed edits in the log context. The main change involves moving the call to logContext.setResult() to occur before any early returns so that the proposed edit is properly logged even when the operation doesn't complete normally.
Key changes:
- Moved
logContext.setResult()call earlier in the flow to ensure proposed edits are logged - Removed unused
getBacktickSectionmethod and its associated tests - Refactored
determinePromptingStrategymethod to inline parameter fetching
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/extension/inlineEdits/node/nextEditProvider.ts | Moved logContext.setResult() call to ensure proposed edits are logged before early returns |
| src/extension/xtab/node/xtabProvider.ts | Removed unused getBacktickSection method and refactored determinePromptingStrategy to inline config fetching |
| src/extension/xtab/test/node/xtabProvider.spec.ts | Removed tests for the deleted getBacktickSection method |
bpasero
previously approved these changes
Sep 15, 2025
Contributor
|
@ulugbekna red CI |
ulugbekna
force-pushed
the
ulugbekna/nes-show-correct-proposed-edit-logContext
branch
from
0b971bc to
33c4b15
Compare
bpasero
approved these changes
Oct 1, 2025
ulugbekna
deleted the
ulugbekna/nes-show-correct-proposed-edit-logContext
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.