add additional metadata for thinking parts#1395
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds metadata to thinking parts to indicate when reasoning is complete. The changes emit a special "reasoning stop" thinking part with vscode_reasoning_done: true metadata when thinking transitions end.
- Tracks thinking state with a boolean flag to detect when thinking ends
- Moves thinking delta processing earlier in the flow to properly emit completion metadata
- Applies the same pattern to both the chat response stream and language model response handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/extension/prompt/node/pseudoStartStopConversationCallback.ts | Adds thinking state tracking and emits reasoning completion metadata in chat response processing |
| src/extension/conversation/vscode-node/languageModelAccess.ts | Mirrors the same thinking completion logic for language model responses |
karthiknadig
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emits a reasoning stop thinking part which will let us know when thinking is done