-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add provider ordering hint for chat model picker #4972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kevin-m-kent
wants to merge
8
commits into
microsoft:main
Choose a base branch
from
kevin-m-kent:kevin-m-kent/model-picker-ordering
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+36
−1
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
05642dc
Add model picker vendor ordering experiment
kevin-m-kent 42d47f6
Use fine-grained vendor priority with featured model boosting
kevin-m-kent 0589edb
Fix: use getExperimentBasedConfig for ExperimentBased setting
kevin-m-kent b83d8c7
Use provider ordering without hardcoded featured models
kevin-m-kent 402380f
Update proposed API definitions
kevin-m-kent 22c3ec5
Avoid depending on proposed d.ts for vendorPriority
kevin-m-kent 9fef0f1
Revert vscode dts baseline drift\n\nCo-authored-by: Copilot <22355621…
kevin-m-kent 67e1e99
Move model picker setting to experimental section\n\nCo-authored-by: …
kevin-m-kent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getVendorPrioritydoesn't match the setting description ("...OpenAI → Anthropic → Gemini...") and will not prioritize BYOK Gemini models because their vendor/provider name is'Gemini'(seeGeminiNativeBYOKLMProvider.providerName = 'Gemini'). Consider handling'gemini'(and/or more robust matching) so Gemini models actually get priority 2 when this setting is enabled.