This repository was archived by the owner on May 20, 2026. It is now read-only.
provide more terminal tools to subagent#5050
Closed
meganrogge wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the execution subagent’s terminal capabilities by adding additional terminal-related tool names to the tool registry and allowing the execution subagent tool-calling loop to use them, aligning with the goal of enabling richer execution workflows (microsoft/vscode#308048).
Changes:
- Add
send_to_terminalandkill_terminalto theToolNameenum and categorize them for the virtual tool grouping system. - Allow the execution subagent tool-calling loop to use
get_terminal_output,send_to_terminal, andkill_terminalin addition torun_in_terminal.
Show a summary per file
| File | Description |
|---|---|
src/extension/tools/common/toolNames.ts |
Adds new terminal tool identifiers and categorizes them so they’re treated as built-in tools in the virtual tool grouping system. |
src/extension/prompt/node/executionSubagentToolCallingLoop.ts |
Expands the execution subagent allowlist to include additional terminal tools. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of microsoft/vscode#308048
Expand execution subagent's allowed tools to include
get_terminal_output,send_to_terminal, andkill_terminalso it can actively manage terminals instead of relying on notifications (which are only passed to the main agent)