Skip to content

Fix read_cell_output incorrectly reporting all outputs as too large #5093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oded-ist wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −3
Open

Fix read_cell_output incorrectly reporting all outputs as too large #5093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/extension/prompts/node/panel/toolCalling.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,6 @@ const toolsCalledInParallel = new Set<ToolName>([
ToolName.GetErrors,
ToolName.GetScmChanges,
ToolName.GetNotebookSummary,
ToolName.ReadCellOutput,
ToolName.InstallExtension,
ToolName.FetchWebPage,
]);
Expand Down
4 changes: 2 additions & 2 deletions src/extension/tools/node/runNotebookCellTool.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ export class RunNotebookCellOutput extends PromptElement<IRunNotebookCellOutputP
|| item.mime === 'application/vnd.code.notebook.stderr'
|| item.mime === 'application/json');
if (textItem) {
if (getCharLimit(textItem.data.byteLength) > sizing.tokenBudget / this.props.sizeLimitRatio) {
if (textItem.data.byteLength > getCharLimit(sizing.tokenBudget / this.props.sizeLimitRatio)) {
return <Tag name={`cell-output`} attrs={{ mimeType: textItem.mime }}>
Output {index + 1}: Output is too large to be used as context in the language model, but the user should be able to see it in the notebook.<br />
<br />
Expand All @@ -394,7 +394,7 @@ export class RunNotebookCellOutput extends PromptElement<IRunNotebookCellOutputP
</Tag>;
}

const largeOutput = output.items.find((item) => getCharLimit(item.data.byteLength) > sizing.tokenBudget / this.props.sizeLimitRatio);
const largeOutput = output.items.find((item) => item.data.byteLength > getCharLimit(sizing.tokenBudget / this.props.sizeLimitRatio));
if (largeOutput) {
return <Tag name={`cell-output`} attrs={{ mimeType: largeOutput.mime }}>
Output {index + 1}: Output is too large to be used as context in the language model, but the user should be able to see it in the notebook.<br />
Expand Down