Skip to content

Commit 01cfad9

Browse files
committed
Fix some comments.
1 parent 6532902 commit 01cfad9

4 files changed

Lines changed: 13 additions & 13 deletions

File tree

Extension/src/Debugger/configurationProvider.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ export class DebugConfigurationProvider implements vscode.DebugConfigurationProv
358358

359359
// LLDB-DAP supports attaching to process by pid or by name.
360360
// If they do specify 'program', then we can check to see if there
361-
// is a process that matches, or they are using 'waitFor' (on Linux/OSX).
361+
// is a process that matches, or they are using 'waitFor' (on Linux/macOS).
362362
if (config.program) {
363363
// If they specified 'program', get the tasks that match that.
364364
const items = (await attachItemsProvider.getAttachItems(token)).filter(each => processMatches(config.program, each.label, each.fullPath));
@@ -991,12 +991,12 @@ export class DebugConfigurationProvider implements vscode.DebugConfigurationProv
991991
// Get debug configurations for all debugger types.
992992
let configs: CppDebugConfiguration[] = [];
993993
if (isWindows) {
994-
// When on windows - prefer cppvsdbg.
994+
// When on Windows - prefer cppvsdbg.
995995
configs.push(...await this.provideDebugConfigurationsForType(DebuggerType.cppvsdbg, folder));
996996
}
997997

998998
if (!isWindows && await findLldbDap()) {
999-
// Only include lldb-dap tasks if it's not windows and lldb-dap is actually available.
999+
// Only include lldb-dap tasks if it's not Windows and lldb-dap is actually available.
10001000
configs.push(...await this.provideDebugConfigurationsForType(DebuggerType.cpplldb, folder));
10011001
}
10021002

@@ -1205,7 +1205,7 @@ export class ConfigurationAssetProvider {
12051205
case 'linux':
12061206
return new LinuxConfigurationProvider();
12071207
default:
1208-
return new ConfigurationAssetProvider(); // at least this will return empty results if the platform is not recognized.
1208+
return new ConfigurationAssetProvider(); // At least this will return empty results if the platform is not recognized.
12091209
}
12101210
}
12111211
}

Extension/src/Debugger/debugAdapterDescriptorFactory.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,11 @@ export class CpplldbDebugAdapterDescriptorFactory extends AbstractDebugAdapterDe
8282
return null;
8383
}
8484

85-
// Prepare the command to run the lldb dap executable.
85+
// Prepare the command to run the lldb-dap executable.
8686
const debuggerArgs = session.configuration.debuggerArgs || [];
8787

8888
// Future: add support for pipeTransport (so that the lldb-dap executable can be run on a remote machine or wsl).
89-
// Future: add support for --server mode (so that the lldb dap executable can be run in server mode).
89+
// Future: add support for --server mode (so that the lldb-dap executable can be run in server mode).
9090

9191
// Prepare the command to run the lldb-dap executable.
9292
return new vscode.DebugAdapterExecutable(adapter, [...debuggerArgs]);

Extension/src/Debugger/lldb-dap.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ import { CppDebugConfiguration, DebuggerType } from './configurations';
1212
import { findLldbDapImpl } from './lldb-dap-worker';
1313
export { isValidLldbDap } from './lldb-dap-worker';
1414

15-
/** Translates the cpplldb configuration to the lldb dap configuration.
15+
/** Translates the cpplldb configuration to the lldb-dap configuration.
1616
* Note: this modifies the existing configuration object in place.
1717
*
1818
* @param config The cpplldb configuration to translate.
19-
* @returns The translated lldb dap configuration.
19+
* @returns The translated lldb-dap configuration.
2020
*/
2121
export function translateToLldbDap(config: CppDebugConfiguration) {
2222
// Adapt the cpplldb config to the lldb-dap config.
@@ -87,9 +87,9 @@ export async function findLldbDap() {
8787
// This code must only run in the main thread.
8888
if (isMainThread && !remote) {
8989
try {
90-
// find the entry point for the worker thread.
90+
// Find the entry point for the worker thread.
9191
const file = resolve(__dirname.substring(0, __dirname.lastIndexOf('dist')), "dist", "src", "Debugger", 'lldb-dap-worker.js');
92-
// create the worker and connection.
92+
// Create the worker and connection.
9393
remote = startRemoting(startWorker(file), {
9494
// These are the functions that the main thread exposes to the worker thread.
9595
log,
@@ -100,7 +100,7 @@ if (isMainThread && !remote) {
100100
});
101101

102102
if (!isWindows) {
103-
// If we are not on Windows, we'll start it searching for the lldb dap executable as early as possible.
103+
// If we are not on Windows, we'll start it searching for the lldb-dap executable as early as possible.
104104
// Mainly, because the LLDB-DAP debugger isn't a common standalone debugger for Windows.
105105
void findLldbDap();
106106
}

Extension/src/common-remote-safe.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,9 @@ export function appendLine(message: string | Promise<string>): void {
119119
}
120120
}
121121

122-
/** When on windows, ensures that the given executable name ends in an '.exe'.
122+
/** When on Windows, ensures that the given executable name ends in an '.exe'.
123123
* @param executableName The name of the executable to check.
124-
* @returns The executable name with .exe appended if on windows and the name does not already end in an '.exe'.
124+
* @returns The executable name with .exe appended if on Windows and the name does not already end in an '.exe'.
125125
*/
126126
export function executableName(executableName: string) {
127127
return isWindows && !/\.exe$/i.test(executableName) ? `${executableName}.exe` : executableName;

0 commit comments

Comments
 (0)