Merge pull request #9290 from microsoft/main

michelleangela · web-flow · commit f31caa30f41c · 2022-05-09T17:52:14.000-07:00
1.10.1 insiders
diff --git a/.github/workflows/by-design-closer-debugger .yml b/.github/workflows/by-design-closer-debugger .yml
@@ -23,4 +23,4 @@ jobs:
           labels: by design,debugger
           ignoreLabels: language service,internal
           closeDays: 0
-          closeComment: "This issue has been closed automatically because it's labeled as 'by design'."
+          closeComment: "This issue has been closed because the described behavior was determined to be by design."
diff --git a/.github/workflows/by-design-closer.yml b/.github/workflows/by-design-closer.yml
@@ -23,6 +23,6 @@ jobs:
           labels: by design
           ignoreLabels: debugger,Feature Request,more info needed,internal
           closeDays: 60
-          closeComment: "This issue has been closed automatically because it's labeled as 'by design' and has not had recent activity."
+          closeComment: "This issue has been closed because the described behavior was determined to be by design."
           pingDays: 80
           pingComment: "Hey @${assignee}, this issue might need further attention.\n\n@${author}, you can help us out by closing this issue if it is no longer relevant."
diff --git a/.github/workflows/duplicate-closer.yml b/.github/workflows/duplicate-closer.yml
@@ -23,6 +23,6 @@ jobs:
           labels: duplicate
           ignoreLabels: debugger,Feature Request,more info needed,by design,internal
           closeDays: 60
-          closeComment: "This issue has been closed automatically because it's labeled as a 'duplicate' and has not had recent activity."
+          closeComment: "This issue has been closed because it is a duplicate of another issue we are tracking."
           pingDays: 80
           pingComment: "Hey @${assignee}, this issue might need further attention.\n\n@${author}, you can help us out by closing this issue if it is no longer relevant."
diff --git a/.github/workflows/enhancement-closer-no-milestone.yml b/.github/workflows/enhancement-closer-no-milestone.yml
@@ -25,6 +25,6 @@ jobs:
           addLabels: more votes needed
           closeDays: 60
           maximumVotes: 2
-          closeComment: "This feature request is being closed due to insufficient upvotes.  When enough upvotes are received, this issue will be eligible for our backlog."
+          closeComment: "This feature request is being closed due to insufficient upvotes. Please leave a 👍-upvote or 👎-downvote reaction on the issue to help us prioritize it. When enough upvotes are received, this issue will be eligible for our backlog."
           setMilestoneId: 30
           ignoreMilestoneNames: "*"
diff --git a/.github/workflows/enhancement-closer-triage.yml b/.github/workflows/enhancement-closer-triage.yml
@@ -25,6 +25,6 @@ jobs:
           addLabels: more votes needed
           closeDays: 60
           maximumVotes: 2
-          closeComment: "This feature request is being closed due to insufficient upvotes.  When enough upvotes are received, this issue will be eligible for our backlog."
+          closeComment: "This feature request is being closed due to insufficient upvotes. Please leave a 👍-upvote or 👎-downvote reaction on the issue to help us prioritize it. When enough upvotes are received, this issue will be eligible for our backlog."
           milestoneName: Triage
           milestoneId: 30
diff --git a/.github/workflows/external-closer-debugger.yml b/.github/workflows/external-closer-debugger.yml
@@ -23,4 +23,4 @@ jobs:
           labels: external,debugger
           ignoreLabels: language service,internal
           closeDays: 0
-          closeComment: "This issue has been closed automatically because it's labeled as 'external'."
+          closeComment: "This issue has been closed because it is external or not applicable to the extension."
diff --git a/.github/workflows/feature-request-closer-no-milestone.yml b/.github/workflows/feature-request-closer-no-milestone.yml
@@ -25,6 +25,6 @@ jobs:
           addLabels: more votes needed
           closeDays: 60
           maximumVotes: 2
-          closeComment: "This feature request is being closed due to insufficient upvotes.  When enough upvotes are received, this issue will be eligible for our backlog."
+          closeComment: "This feature request is being closed due to insufficient upvotes. Please leave a 👍-upvote or 👎-downvote reaction on the issue to help us prioritize it. When enough upvotes are received, this issue will be eligible for our backlog."
           setMilestoneId: 30
           ignoreMilestoneNames: "*"
diff --git a/.github/workflows/feature-request-closer-triage.yml b/.github/workflows/feature-request-closer-triage.yml
@@ -25,6 +25,6 @@ jobs:
           addLabels: more votes needed
           closeDays: 60
           maximumVotes: 2
-          closeComment: "This feature request is being closed due to insufficient upvotes.  When enough upvotes are received, this issue will be eligible for our backlog."
+          closeComment: "This feature request is being closed due to insufficient upvotes. Please leave a 👍-upvote or 👎-downvote reaction on the issue to help us prioritize it. When enough upvotes are received, this issue will be eligible for our backlog."
           milestoneName: Triage
           milestoneId: 30
diff --git a/.github/workflows/investigate-closer-debugger.yml b/.github/workflows/investigate-closer-debugger.yml
@@ -23,4 +23,4 @@ jobs:
           labels: investigate,debugger
           ignoreLabels: language service,internal
           closeDays: 180
-          closeComment: "This issue has been closed automatically because it has not had recent activity."
+          closeComment: "This issue has been closed as lower priority. We're sorry if this issue still impacts you but unfortunately we're not able to address this. We will accept a pull request from the community if it's applicable for this issue."
diff --git a/.github/workflows/investigate-costing-closer-debugger.yml b/.github/workflows/investigate-costing-closer-debugger.yml
@@ -23,4 +23,4 @@ jobs:
           labels: "investigate: costing,debugger"
           ignoreLabels: language service,internal
           closeDays: 180
-          closeComment: "This issue has been closed automatically because it has not had recent activity."
+          closeComment: "This issue has been closed as lower priority. We're sorry if this issue still impacts you but unfortunately we're not able to address this. We will accept a pull request from the community if it's applicable for this issue."
diff --git a/.github/workflows/more-info-needed-closer-debugger.yml b/.github/workflows/more-info-needed-closer-debugger.yml
@@ -24,6 +24,6 @@ jobs:
           ignoreLabels: language service,internal
           involves: wardengnaw,pieandcakes,calgagi
           closeDays: 14
-          closeComment: "This issue has been closed automatically because it needs more information and has not had recent activity."
+          closeComment: "This issue has been closed because it needs more information and has not had recent activity."
           pingDays: 7
           pingComment: "Hey @${assignee}, this issue might need further attention.\n\n@${author}, you can help us out by closing this issue if the problem no longer exists, or adding more information."
diff --git a/.github/workflows/more-info-needed-closer.yml b/.github/workflows/more-info-needed-closer.yml
@@ -23,6 +23,6 @@ jobs:
           labels: more info needed
           ignoreLabels: debugger,internal
           closeDays: 60
-          closeComment: "This issue has been closed automatically because it needs more information and has not had recent activity."
+          closeComment: "This issue has been closed because it needs more information and has not had recent activity."
           pingDays: 80
           pingComment: "Hey @${assignee}, this issue might need further attention.\n\n@${author}, you can help us out by closing this issue if the problem no longer exists, or adding more information."
diff --git a/.github/workflows/question-closer-debugger.yml b/.github/workflows/question-closer-debugger.yml
@@ -24,6 +24,6 @@ jobs:
           ignoreLabels: language service,internal
           involves: wardengnaw,pieandcakes,calgagi
           closeDays: 14
-          closeComment: "This issue has been closed automatically because it's labeled as a 'question' and has not had recent activity."
+          closeComment: "This issue has been closed because it is a question and has not had recent activity."
           pingDays: 7
           pingComment: "Hey @${assignee}, this issue might need further attention.\n\n@${author}, you can help us out by closing this issue if the question has been answered."
diff --git a/.github/workflows/question-closer.yml b/.github/workflows/question-closer.yml
@@ -23,6 +23,6 @@ jobs:
           labels: question
           ignoreLabels: debugger,internal
           closeDays: 60
-          closeComment: "This issue has been closed automatically because it's labeled as a 'question' and has not had recent activity."
+          closeComment: "This issue has been closed because it is a question and has not had recent activity."
           pingDays: 80
           pingComment: "Hey @${assignee}, this issue might need further attention.\n\n@${author}, you can help us out by closing this issue if the question has been answered."
diff --git a/Extension/CHANGELOG.md b/Extension/CHANGELOG.md
@@ -1,5 +1,17 @@
 # C/C++ for Visual Studio Code Change Log
 
+## Version 1.10.1: May 10, 2022
+### Enhancements
+* Generate launch.json when adding a new debug configuration. [#9100](https://github.com/microsoft/vscode-cpptools/issues/9100)
+* Prioritize the "folder" option when doing a `#include` completion. [#9222](https://github.com/microsoft/vscode-cpptools/issues/9222)
+* Add compiler path to debug configuration details. [PR #9264](https://github.com/microsoft/vscode-cpptools/pull/9264)
+
+### Bug Fixes
+* Fix handling of `@response` files for clang-tidy on Windows. [#8843](https://github.com/microsoft/vscode-cpptools/issues/8843),  [#9032](https://github.com/microsoft/vscode-cpptools/issues/9032), [#9102](https://github.com/microsoft/vscode-cpptools/issues/9102)
+* Fix cpptools-srv zombie processes. [#9261](https://github.com/microsoft/vscode-cpptools/issues/9261)
+* Fix `C_Cpp.codeAnalysis.clangTidy.useBuildPath` adding "compile_commands.json" to the `-p` argument. [#9273](https://github.com/microsoft/vscode-cpptools/issues/9273)
+* Fix Go to Definition on a `#include` with an absolute path. [#9287](https://github.com/microsoft/vscode-cpptools/issues/9287)
+
 ## Version 1.10.0: April 21, 2022
 ### New Feature
 * Added support for setting values on top-level watch window expressions. [#9019](https://github.com/microsoft/vscode-cpptools/issues/9019)
diff --git a/Extension/package.json b/Extension/package.json
@@ -2,7 +2,7 @@
   "name": "cpptools",
   "displayName": "C/C++",
   "description": "C/C++ IntelliSense, debugging, and code browsing.",
-  "version": "1.10.0-main",
+  "version": "1.10.1-main",
   "publisher": "ms-vscode",
   "icon": "LanguageCCPP_color_128x.png",
   "readme": "README.md",
@@ -50,7 +50,6 @@
     "onLanguage:cuda-cpp",
     "onCommand:extension.pickNativeProcess",
     "onCommand:extension.pickRemoteNativeProcess",
-    "onCommand:C_Cpp.BuildAndDebugActiveFile",
     "onCommand:C_Cpp.RestartIntelliSenseForFile",
     "onCommand:C_Cpp.ConfigurationEditJSON",
     "onCommand:C_Cpp.ConfigurationEditUI",
@@ -2752,6 +2751,12 @@
         "title": "%c_cpp.command.BuildAndRunFile.title%",
         "category": "C/C++",
         "icon": "$(run)"
+      },
+      {
+        "command": "C_Cpp.AddDebugConfiguration",
+        "title": "%c_cpp.command.AddDebugConfiguration.title%",
+        "category": "C/C++",
+        "icon": "$(debug-configure)"      
       }
     ],
     "keybindings": [
@@ -3883,31 +3888,43 @@
           "group": "navigation@1"
         }
       ],
+      "editor/title": [
+        {
+          "command": "C_Cpp.AddDebugConfiguration",
+          "when": "editorLangId == 'c' && config.C_Cpp.debugShortcut && BuildAndDebug.isSourceFile && BuildAndDebug.isFolderOpen || editorLangId == 'cpp' && config.C_Cpp.debugShortcut && BuildAndDebug.isSourceFile && BuildAndDebug.isFolderOpen || editorLangId == 'cuda-cpp' && config.C_Cpp.debugShortcut && BuildAndDebug.isSourceFile && BuildAndDebug.isFolderOpen",
+          "group": "navigation"
+        }
+      ],
       "editor/context": [
         {
           "when": "editorLangId == 'c' || editorLangId == 'cpp' || editorLangId == 'cuda-cpp'",
           "command": "C_Cpp.SwitchHeaderSource",
-          "group": "other1_navigation@1"
+          "group": "custom1@1"
         },
         {
           "when": "editorLangId == 'c' || editorLangId == 'cpp' || editorLangId == 'cuda-cpp'",
           "command": "workbench.action.gotoSymbol",
-          "group": "other1_navigation@3"
+          "group": "custom1@2"
         },
         {
           "when": "editorLangId == 'c' || editorLangId == 'cpp' || editorLangId == 'cuda-cpp'",
           "command": "workbench.action.showAllSymbols",
-          "group": "other1_navigation@4"
+          "group": "custom1@3"
         },
         {
-          "when": "editorLangId == 'c' || editorLangId == 'cpp' || editorLangId == 'cuda-cpp'",
           "command": "C_Cpp.RunCodeAnalysisOnActiveFile",
-          "group": "other2@2"
+          "when": "editorLangId == 'c' || editorLangId == 'cpp' || editorLangId == 'cuda-cpp'",
+          "group": "custom2@1"
         },
         {
-          "when": "editorLangId == 'c' || editorLangId == 'cpp' || editorLangId == 'cuda-cpp'",
           "command": "C_Cpp.RestartIntelliSenseForFile",
-          "group": "other2@3"
+          "when": "editorLangId == 'c' || editorLangId == 'cpp' || editorLangId == 'cuda-cpp'",
+          "group": "custom2@2"
+        },
+        {
+          "command": "C_Cpp.AddDebugConfiguration",
+          "when": "editorLangId == 'c' && config.C_Cpp.debugShortcut && BuildAndDebug.isSourceFile && BuildAndDebug.isFolderOpen || editorLangId == 'cpp' && config.C_Cpp.debugShortcut && BuildAndDebug.isSourceFile && BuildAndDebug.isFolderOpen || editorLangId == 'cuda-cpp' && config.C_Cpp.debugShortcut && BuildAndDebug.isSourceFile && BuildAndDebug.isFolderOpen",
+          "group": "custom2@3"
         }
       ],
       "commandPalette": [
diff --git a/Extension/package.nls.json b/Extension/package.nls.json
@@ -27,6 +27,7 @@
     "c_cpp.command.ClearCodeAnalysisSquiggles.title": "Clear Code Analysis Squiggles",
     "c_cpp.command.BuildAndDebugFile.title": "Debug C/C++ File",
     "c_cpp.command.BuildAndRunFile.title": "Run C/C++ File",
+    "c_cpp.command.AddDebugConfiguration.title": "Add Debug Configuration",
     "c_cpp.configuration.maxConcurrentThreads.markdownDescription": { "message": "The maximum number of concurrent threads to use for language service processing. The value is a hint and may not always be used. The default of `null` (empty) uses the number of logical processors available.", "comment": [ "Markdown text between `` should not be translated or localized (they represent literal text) and the capitalization, spacing, and punctuation (including the ``) should not be altered." ] },
     "c_cpp.configuration.maxCachedProcesses.markdownDescription": { "message": "The maximum number of cached processes to use for language service processing. The default of `null` (empty) uses twice the number of logical processors available.", "comment": [ "Markdown text between `` should not be translated or localized (they represent literal text) and the capitalization, spacing, and punctuation (including the ``) should not be altered." ] },
     "c_cpp.configuration.maxMemory.markdownDescription": { "message": "The maximum memory (in MB) available for language service processing. Fewer processes will be cached and run concurrently after this memory usage is exceeded. The default of `null` (empty) uses the system's free memory.", "comment": [ "Markdown text between `` should not be translated or localized (they represent literal text) and the capitalization, spacing, and punctuation (including the ``) should not be altered." ] },
diff --git a/Extension/src/Debugger/configurationProvider.ts b/Extension/src/Debugger/configurationProvider.ts
diff --git a/Extension/src/Debugger/extension.ts b/Extension/src/Debugger/extension.ts
diff --git a/Extension/src/LanguageServer/client.ts b/Extension/src/LanguageServer/client.ts
diff --git a/Extension/src/LanguageServer/cppBuildTaskProvider.ts b/Extension/src/LanguageServer/cppBuildTaskProvider.ts
diff --git a/Extension/src/common.ts b/Extension/src/common.ts
