Conversation
|
@microsoft-github-policy-service agree |
|
We don't want to make any breaking changes to the custom data format, just additions. So simply add a new 'baseline' (or `baseline-compatibility') property on the same level as browsers. The value set should be well defined, maybe an enum and a description. This can then go in the schema: https://github.com/microsoft/vscode-CSS-languageservice/blob/main/docs/customData.schema.json and also in the documentation. |
|
Thanks @aeschli. I've reverted the |
|
If you open it in in VS Code you will get validation. |
|
Ok great, I've added this to my local settings and I can confirm that there are no validation warnings in "json.schemas": [
{
"fileMatch": [
"**/web-data/data/browsers.css-data.json"
],
"url": "/Users/rviscomi/git/vscode-css-languageservice/docs/customData.schema.json"
}
] |
|
Thanks @rviscomi ! |
Progress on microsoft/vscode-css-languageservice#427
npm run update-sourcescompute-baselinedependencybrowsersfieldnpm run generate-dataI think this also fixes a bug where some pseudo-elements and pseudo-classes might have
()suffixes that need to get stripped out to match the feature IDs in BCD.See PR microsoft/vscode-css-languageservice#428 for the corresponding hovercard UI changes