Ignore commented <UserSecretsId> tag in .csproj (#4268)

FiftyNine · web-flow · commit 263672fe7397 · 2024-04-03T16:02:30.000-04:00
diff --git a/src/tasks/netcore/NetCoreTaskHelper.ts b/src/tasks/netcore/NetCoreTaskHelper.ts
@@ -195,7 +195,9 @@ export class NetCoreTaskHelper implements TaskHelper {
 
     private async inferUserSecrets(helperOptions: NetCoreTaskOptions): Promise<boolean> {
         const contents = await fse.readFile(helperOptions.appProject);
-        return UserSecretsRegex.test(contents.toString());
+        // Remove comments so we don't match a commented tag
+        const noComments = contents.toString().replace(/<!--.*?-->/gs, "");
+        return UserSecretsRegex.test(noComments);
     }
 
     private async inferVolumes(folder: WorkspaceFolder, runOptions: DockerRunOptions, helperOptions: NetCoreTaskOptions, ssl: boolean, userSecrets: boolean): Promise<DockerContainerVolume[]> {

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,9 @@ export class NetCoreTaskHelper implements TaskHelper {`
`195`	`195`
`196`	`196`	`private async inferUserSecrets(helperOptions: NetCoreTaskOptions): Promise<boolean> {`
`197`	`197`	`const contents = await fse.readFile(helperOptions.appProject);`
`198`		`- return UserSecretsRegex.test(contents.toString());`
	`198`	`+ // Remove comments so we don't match a commented tag`
	`199`	`+ const noComments = contents.toString().replace(/<!--.*?-->/gs, "");`
	`200`	`+ return UserSecretsRegex.test(noComments);`
`199`	`201`	`}`
`200`	`202`
`201`	`203`	`private async inferVolumes(folder: WorkspaceFolder, runOptions: DockerRunOptions, helperOptions: NetCoreTaskOptions, ssl: boolean, userSecrets: boolean): Promise<DockerContainerVolume[]> {`