docs: use discrete for background progress#9666
Open
Rohan5commit wants to merge 1 commit intomicrosoft:mainfrom
Open
docs: use discrete for background progress#9666Rohan5commit wants to merge 1 commit intomicrosoft:mainfrom
Rohan5commit wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Status Bar UX guideline to use the correct term discrete (not discreet) when describing background progress, keeping the guidance accurate and consistent.
Changes:
- Replace “discreet” with “discrete” in the background progress guidance text.
- Replace “discreet” with “discrete” in the accompanying example caption.
| ### Progress Status Bar item | ||
|
|
||
| When needing to show discreet progress (progress happening in the background), it's recommended to show a Status Bar item with the loading icon (you can also add spin animation). If progress needs to be elevated for user attention, we recommend moving to a progress notification. | ||
| When needing to show discrete progress (progress happening in the background), it's recommended to show a Status Bar item with the loading icon (you can also add spin animation). If progress needs to be elevated for user attention, we recommend moving to a progress notification. |
There was a problem hiding this comment.
This sentence is hard to parse and is not in second person. Consider rewriting to a direct instruction (for example, start with "When you need to show..." and avoid "it's recommended").
Suggested change
| When needing to show discrete progress (progress happening in the background), it's recommended to show a Status Bar item with the loading icon (you can also add spin animation). If progress needs to be elevated for user attention, we recommend moving to a progress notification. | |
| When you need to show discrete progress, or progress that happens in the background, show a Status Bar item with the loading icon. You can also add a spin animation. If you need to elevate progress for user attention, move it to a progress notification. |
|  | ||
|
|
||
| *This example shows a progress Status Bar item that is discreet.* | ||
| *This example shows a progress Status Bar item that is discrete.* |
There was a problem hiding this comment.
The caption uses "discrete", which many readers confuse with "discreet". Consider rephrasing the caption to avoid the ambiguous word (for example, describe it as "background" progress) since the section already defines the concept.
Suggested change
| *This example shows a progress Status Bar item that is discrete.* | |
| *This example shows a progress Status Bar item that shows background progress.* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discretefor background progress wordingRelated issue
Guideline alignment
CONTRIBUTING.mdValidation
git diff --check