perf(azure): throttle parallel tenant sign-in checks with shared concurrency limiter#694
Merged
tnaum-ms merged 4 commits intoJun 23, 2026
Merged
Conversation
Closed
4 tasks
1b357bc to
f32064e
Compare
Collaborator
|
Maintainer note (triage) This branch was rebased onto main and reduced to the minimal change for #688. It reuses the existing shared There was no Copilot review on this PR. The limiter itself is unit-tested; a manual check with a 50+ tenant Azure account is still recommended before merge. |
tnaum-ms
approved these changes
Jun 23, 2026
sajeetharan
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace unbounded
Promise.allfan-outs against the Azure Identity endpoint with a sharedConcurrencyLimiter(concurrency: 5).For corporate users with many tenants, the original code issued unlimited parallel
isSignedIncalls against Microsoft Entra -- the same anti-pattern fixed forestimateDocumentCountin #685.Issue
Fixes #688
Changes
src/plugins/api-shared/azure/tenantSignInLimiter.tsLimitedRunner(concurrency: 5) wrappingcreateConcurrencyLimitersrc/plugins/api-shared/azure/credentialsManagement/SelectAccountStep.tsisSignedIncallssrc/plugins/api-shared/azure/subscriptionFiltering/InitializeFilteringStep.tsisSignedIncallsVerification
npm run build-- TypeScript compilation passesnpm run lint-- ESLint passesnpm run prettier-fix-- formatting confirmed