fix: close micro race window between connect() resolve and abort listener removal#700
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a guard in the abort handler to prevent closing an already-connected MongoClient during the brief window between connect() resolving and the abort listener being removed.
Changes:
- Introduce a
connectedflag tracked across the connect call. - Early-return from
onAbortwhenconnectedis true.
Collaborator
|
Thank you again for this contribution. We are genuinely amazed by both the quality and the volume of improvements you have submitted. We also apologize for the delayed review while the 0.9.0 release was in flight. This race condition fix is thoughtful, precise, and very valuable for connection stability. |
fix: close micro race window between connect() resolve and abort listener removal Add a `connected` flag that is set immediately after `mongoClient.connect()` resolves. The `onAbort` handler now checks this flag before calling `close()`, preventing a late abort from closing an already-connected client during the synchronous window between connect() resolving and removeEventListener firing. Fixes microsoft#644 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> @
tnaum-ms
force-pushed
the
fix-644-race-abort-connect
branch
from
469f262 to
0b66bab
Compare
tnaum-ms
approved these changes
Jun 19, 2026
tnaum-ms
left a comment
tnaum-ms
left a comment
Collaborator
There was a problem hiding this comment.
Thanks again for the excellent contribution. Approved after rebase and full validation pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connectedflag that is set immediately aftermongoClient.connect()resolvesonAborthandler now checks this flag before callingclose(), preventing a late abort from closing an already-connected clientconnect()resolving andremoveEventListenerfiringIssue
Fixes #644
Changes
src/documentdb/ClustersClient.tsconnectedflag; guardonAbortclose with!connectedcheckVerification
connectedflag transitions fromfalsetotrueatomically in the same synchronous tick asconnect()resolvesconnected === false-> close the client (existing behavior preserved)connected === true-> skip close (race window closed)finallyblock still removes the listener for cleanup