docs: document PlaygroundEvaluator lifecycle after killWorker (#645)#706
Merged
Merged
Conversation
hanhan761
force-pushed
the
docs-645-evaluator-lifecycle
branch
from
59c7601 to
ea417ae
Compare
Collaborator
|
Thank you again for this contribution. We are genuinely amazed by both the quality and the volume of improvements you have submitted. We also apologize for the delayed review while the 0.9.0 release was in flight. This documentation update is clear and very helpful for maintainability. |
Add a lifecycle section to the PlaygroundEvaluator class header explaining that the evaluator instance and worker thread have independent lifecycles. After killWorker(), the evaluator stays registered in the pool and the next evaluate() call transparently respawns the worker. Also add a comment at the cancellation site in executePlaygroundCode.ts clarifying that killWorker() terminates the worker but keeps the evaluator. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tnaum-ms
force-pushed
the
docs-645-evaluator-lifecycle
branch
from
ea417ae to
6f46ffd
Compare
tnaum-ms
previously approved these changes
Jun 19, 2026
tnaum-ms
left a comment
tnaum-ms
left a comment
Collaborator
There was a problem hiding this comment.
Thanks again for the excellent contribution. Approved after rebase, doc accuracy tweak, and full validation pass.
sajeetharan
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies the lifecycle split between evaluator instances and worker threads. After
killWorker(), the evaluator instance stays in the per-cluster map — the next Run respawns a fresh worker transparently. This design is intentional but wasn't documented, making it easy to misread.Changes
src/documentdb/playground/PlaygroundEvaluator.tskillWorker()vsshutdown()vsdispose()semanticssrc/commands/playground/executePlaygroundCode.tsevaluatorsMap lifecycleVerification
npm run build— TypeScript compilation passesIssue
Fixes #645
🤖 Generated with Claude Code