fix: surface status bar warning when TS plugin bootstrap fails on read-only extension installs (fixes #637)#720
Merged
tnaum-ms merged 3 commits intoJun 22, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds clearer behavior when the TypeScript plugin stub can’t be installed due to read-only extension installs, preventing repeated bootstrap attempts and surfacing a persistent warning to the user.
Changes:
- Introduces a
tsPluginUnavailableflag to stop future TS bootstrap retries after specific failures. - Detects
EACCES/EROFSand shows a status bar warning describing the limitation. - Keeps transient failures retryable by resetting
tsRestartedonly for non-permission errors.
…d-only extension installs (fixes microsoft#637)
- Replace dead-end status bar button (opened playground) with 'Retry TS Plugin Setup' command that resets the unavailable flag and re-attempts bootstrap - Extract magic number 100 to named TS_PLUGIN_WARNING_PRIORITY constant - Guard command registration to prevent duplicate handlers on repeated failures
tnaum-ms
force-pushed
the
fix-637-readonly-ts-plugin-status-bar
branch
from
a8f8ced to
23200e9
Compare
Collaborator
|
Maintainer note (review-driven changes) Beyond the items Copilot flagged, this branch received a few review-driven fixes that were not part of the original review comments:
Heads-up for reviewers: the read-only (EACCES/EROFS) path still needs a manual test on an actual read-only extension install (Snap, system package, locked/enterprise share) since it cannot be exercised by the unit suite. |
sajeetharan
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the extension is installed in a read-only environment (Snap, system package manager, locked enterprise, network share), the TS plugin stub creation fails with EACCES or EROFS. Currently this fails silently -- telemetry and debug logs capture the error, but users get no visible signal that TypeScript-powered completions are unavailable.
Changes
ensureTsRestartcatch blocktsPluginUnavailableflag to skip automatic future retries (avoiding repeated silent failures)$(warning) DocumentDB TS Plugin) and a tooltip explaining the limitationvscode-documentdb.command.retryTsPluginBootstrapcommand wired to the status bar item's click, so users can manually retry after fixing the underlying permission issueIssue
Fixes #637
Verification
npm run build-- no new errors insrc/documentdb/ClustersExtension.ts