Skip to content

chore: remove applicationinsights-web-basic override after upstream fix release (fixes #614)#725

Merged
tnaum-ms merged 1 commit into
microsoft:mainfrom
hanhan761:chore-614-remove-ai-override
Jun 24, 2026
Merged

chore: remove applicationinsights-web-basic override after upstream fix release (fixes #614)#725
tnaum-ms merged 1 commit into
microsoft:mainfrom
hanhan761:chore-614-remove-ai-override

Conversation

@hanhan761

Copy link
Copy Markdown
Contributor

Summary

The @microsoft/applicationinsights-web-basic override was pinned to ~3.3.4 as a workaround for @vscode/extension-telemetry issue #244. The upstream fix was released in v1.5.2, so the override is no longer needed.

Changes

  • Removed @microsoft/applicationinsights-web-basic: ~3.3.4 from overrides in package.json
  • Updated the //overrides comment to remove the applicationinsights mention

Issue

Fixes #614

Verification

  • npm install completed successfully — dependencies resolve correctly without the override
  • Only package.json changed (2 insertions, 3 deletions)

Copilot AI review requested due to automatic review settings June 2, 2026 14:45
@hanhan761 hanhan761 requested a review from a team as a code owner June 2, 2026 14:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds an LRU-based entry cap to the schema analyzer cache to prevent unbounded memory growth, and simplifies dependency overrides.

Changes:

  • Introduces an LRU eviction mechanism with a default max-entry limit and telemetry for evictions.
  • Updates read/write paths to record access to support LRU behavior.
  • Removes an Application Insights-related dependency override and updates the overrides note.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/documentdb/SchemaStore.ts Adds max-entry limit + LRU tracking/eviction and emits telemetry measurements.
package.json Simplifies overrides by removing an override entry and updating its explanatory note.

Comment thread src/documentdb/SchemaStore.ts
Comment thread src/documentdb/SchemaStore.ts
Comment thread package.json Outdated
@tnaum-ms tnaum-ms added the in-triage-queue We've seen your input and will triage it label Jun 4, 2026
@tnaum-ms tnaum-ms added this to the 0.9.1 milestone Jun 23, 2026
…ix (fixes microsoft#614)

@microsoft/applicationinsights-web-basic was pinned to ~3.3.4 to work
around @vscode/extension-telemetry not declaring applicationinsights-common
as a direct dependency. The fix shipped in extension-telemetry@1.5.2
(microsoft/vscode-extension-telemetry#245).

vscode-azext-utils@4.1.x now depends on extension-telemetry@^1.5.2, so
the override is no longer needed.

Regenerated package-lock.json to collapse the previously nested duplicate
AI packages, recovering ~100-120 KB from the extension bundle.
@tnaum-ms

Copy link
Copy Markdown
Collaborator

Thanks for picking this up, @hanhan761! The core change is exactly right and the prerequisites are all met -- extension-telemetry 1.5.2 is out and vscode-azext-utils 4.1.x has already updated its dependency range to pick it up.

We did a small cleanup before merging. The branch had two independent changes bundled together: the override removal (issue #614) and the SchemaStore LRU eviction (issue #604). The LRU work had already landed on main separately, so keeping it here would have created a conflict. We also noticed the package-lock.json was not updated in the PR -- without regenerating it, the nested duplicate AI packages would have stayed in the lockfile and the bundle size improvement would not have been visible.

We force-pushed a single clean commit that covers only issue #614: removes the override from package.json, updates the comment, and includes the regenerated package-lock.json. The lockfile now resolves applicationinsights-web-basic to a single ^3.4.1 entry (was two nested copies), which recovers the expected ~100-120 KB from the VSIX.

One note for future PRs: we noticed the same pattern of bundling unrelated changes in your other open PRs as well -- sorry for not flagging it sooner. Keeping each PR focused on one issue makes reviews much easier, both for confirming the change matches the issue requirements and for isolating any regressions. No worries at all, just something worth keeping in mind going forward.

Everything passes and we will merge this shortly. Great contribution!

@tnaum-ms tnaum-ms force-pushed the chore-614-remove-ai-override branch from 97e111c to 7e7e28f Compare June 24, 2026 10:30
@tnaum-ms tnaum-ms removed the in-triage-queue We've seen your input and will triage it label Jun 24, 2026
@tnaum-ms tnaum-ms enabled auto-merge June 24, 2026 11:28
@tnaum-ms tnaum-ms merged commit 5c5de2a into microsoft:main Jun 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: remove applicationinsights-web-basic override after upstream fix is released

4 participants