Addressing feedback

Author: vidorteg

.eslintrc.js .eslintrc.mjs.eslintrc.js renamed to .eslintrc.mjs

@@ -672,7 +672,7 @@
         "build-and-lint": "npm run build && npm run lint",
         "watch": "npm run watch-wp",
         "watch-wp": "webpack --watch",
-        "lint": "eslint -c .eslintrc.js */*.ts",
+        "lint": "eslint -c .eslintrc.mjs */*.ts",
         "test": "npm run lint && jest --config package.json --runInBand --env=jsdom"
     },
     "dependencies": {

package.json

@@ -375,7 +375,7 @@ describe("extension", () => {
 
             const newExtension = await import("../src/extension");
             await newExtension.attach(createFakeExtensionContext(), expectedMissingUrl);
-            expect(mocks.vscode.window.showErrorMessage).toHaveBeenCalledWith (expect.stringContaining(expectedMissingUrl));
+            expect(mocks.vscode.window.showErrorMessage).toHaveBeenCalledWith(expect.stringContaining(expectedMissingUrl));
         });
 
         it("shows error if it can't find given target due to missing urls", async () => {
@@ -384,7 +384,7 @@ describe("extension", () => {
 
             const newExtension = await import("../src/extension");
             await newExtension.attach(createFakeExtensionContext(), expectedUrl);
-            expect(mocks.vscode.window.showErrorMessage).toHaveBeenCalledWith (expect.stringContaining(expectedUrl));
+            expect(mocks.vscode.window.showErrorMessage).toHaveBeenCalledWith(expect.stringContaining(expectedUrl));
         });
 
         it("reports telemetry if failed to get targets", async () => {
@@ -709,7 +709,7 @@ describe("extension", () => {
             const newExtension = await import("../src/extension");
 
             await newExtension.attachToCurrentDebugTarget(createFakeExtensionContext());
-            expect(mocks.vscode.window.showErrorMessage).toHaveBeenCalledWith (expect.stringContaining(expectedErrorMessage));
+            expect(mocks.vscode.window.showErrorMessage).toHaveBeenCalledWith(expect.stringContaining(expectedErrorMessage));
         });
 
         it("creates a panel with a constructed url", async () => {

test/extension.test.ts

@@ -21,7 +21,7 @@ describe("launchConfigManager", () => {
             fse.pathExistsSync.mockImplementation(() => false);
             const launchConfigManager = LaunchConfigManager.instance;
             expect(launchConfigManager.getLaunchConfig()).toEqual('None');
-            expect(vscodeMock.commands.executeCommand).toHaveBeenCalledWith ('setContext', 'launchJsonStatus', 'None');
+            expect(vscodeMock.commands.executeCommand).toHaveBeenCalledWith('setContext', 'launchJsonStatus', 'None');
         });
 
         it('updates launchJsonStatus with "Unsupported" when there is no supported debug config', async () => {
@@ -35,7 +35,7 @@ describe("launchConfigManager", () => {
             });
             const launchConfigManager = LaunchConfigManager.instance;
             expect(launchConfigManager.getLaunchConfig()).toEqual('Unsupported');
-            expect(vscodeMock.commands.executeCommand).toHaveBeenCalledWith ('setContext', 'launchJsonStatus', 'Unsupported');
+            expect(vscodeMock.commands.executeCommand).toHaveBeenCalledWith('setContext', 'launchJsonStatus', 'Unsupported');
         });
 
         it('returns a supported debug config when one exists', async () => {
@@ -141,7 +141,7 @@ describe("launchConfigManager", () => {
             vscodeMock.Uri.joinPath = jest.fn();
             const launchConfigManager = LaunchConfigManager.instance;
             launchConfigManager.configureLaunchJson();
-            expect(vscodeMock.WorkspaceConfiguration.update).toHaveBeenCalledWith ('configurations', Array(4).fill(expect.anything()));
+            expect(vscodeMock.WorkspaceConfiguration.update).toHaveBeenCalledWith('configurations', Array(4).fill(expect.anything()));
         });
     });
 

test/launchConfigManager.test.ts

@@ -1037,14 +1037,14 @@ describe("utils", () => {
                 }
             });
 
-            jest.doMock("vscode", () => typeof import("vscode"), { virtual: true });
+            jest.doMock("vscode", () => vscodeMock, { virtual: true });
             jest.resetModules();
         });
 
         it('correctly records all changed extension settings', async () => {
             const reporter = createFakeTelemetryReporter();
             utils.reportExtensionSettings(reporter);
-            expect(reporter.sendTelemetryEvent).toHaveBeenCalledWith ('user/settingsChangedAtLaunch', { isHeadless: 'false' });
+            expect(reporter.sendTelemetryEvent).toHaveBeenCalledWith('user/settingsChangedAtLaunch', { isHeadless: 'false' });
         });
 
         it('correctly sends telemetry event for changed event', async () => {
@@ -1057,7 +1057,7 @@ describe("utils", () => {
                 }
             }};
             utils.reportChangedExtensionSetting(configurationChangedEvent, reporter);
-            expect(reporter.sendTelemetryEvent).toHaveBeenCalledWith ('user/settingsChanged', { isHeadless: 'false' });
+            expect(reporter.sendTelemetryEvent).toHaveBeenCalledWith('user/settingsChanged', { isHeadless: 'false' });
         });
     });
 });