Addressing feedback

Author: vidorteg

.eslintrc.js

@@ -23,7 +23,7 @@ export default [
       globals: {
         ...globals.browser,
         ...globals.node,
-        ...globals.es20222,
+        ...globals.es2022,
       }
     },
     plugins: {

test/devtoolsPanel.test.ts

@@ -232,7 +232,7 @@ describe("devtoolsPanel", () => {
             const expectedMessage = "some message that should be passed through";
             const { callback, thisObj } = getFirstCallback(mockPanel.webview.onDidReceiveMessage);
             callback.call(thisObj, expectedMessage);
-            expect(mockPanelSocket.onMessageFromWebview).toHaveBeenCalledWith (expectedMessage);
+            expect(mockPanelSocket.onMessageFromWebview).toHaveBeenCalledWith(expectedMessage);
         });
 
         it("forwards panel socket messages to the webview", async () => {
@@ -440,7 +440,7 @@ describe("devtoolsPanel", () => {
                 dtp.DevToolsPanel.createOrShow(context, mockTelemetry, "", mockRuntimeConfig);
 
                 await hookedEvents.get("getUrl")!(JSON.stringify(expectedRequest));
-                expect(mockUtils.fetchUri).toHaveBeenCalledWith (expectedRequest.url);
+                expect(mockUtils.fetchUri).toHaveBeenCalledWith(expectedRequest.url);
 
                 expect(mockWebviewEvents.encodeMessageForChannel).toHaveBeenCalledWith(
                     expect.any(Function),
@@ -471,7 +471,7 @@ describe("devtoolsPanel", () => {
                 dtp.DevToolsPanel.createOrShow(context, mockTelemetry, "", mockRuntimeConfig);
 
                 await hookedEvents.get("getUrl")!(JSON.stringify(expectedRequest));
-                expect(mockUtils.fetchUri).toHaveBeenCalledWith (expectedRequest.url);
+                expect(mockUtils.fetchUri).toHaveBeenCalledWith(expectedRequest.url);
                 expect(mockWebviewEvents.encodeMessageForChannel).toHaveBeenCalledWith(
                     expect.any(Function),
                     "getUrl",

test/extension.test.ts

@@ -731,7 +731,7 @@ describe("extension", () => {
 
             await newExtension.attachToCurrentDebugTarget(createFakeExtensionContext());
             expect(mocks.utils.getJsDebugCDPProxyWebsocketUrl).toHaveBeenCalled();
-            expect(mocks.vscode.window.showErrorMessage).toHaveBeenCalledWith (expect.stringContaining('Error Message'));
+            expect(mocks.vscode.window.showErrorMessage).toHaveBeenCalledWith(expect.stringContaining('Error Message'));
         });
 
         it("shows an error if JsDebugCDPProxyWebSocketUrl is undefined", async () => {
@@ -740,7 +740,7 @@ describe("extension", () => {
 
             await newExtension.attachToCurrentDebugTarget(createFakeExtensionContext());
             expect(mocks.utils.getJsDebugCDPProxyWebsocketUrl).toHaveBeenCalled();
-            expect(mocks.vscode.window.showErrorMessage).toHaveBeenCalledWith (expect.stringContaining('Unable to attach DevTools to current debug session.'));
+            expect(mocks.vscode.window.showErrorMessage).toHaveBeenCalledWith(expect.stringContaining('Unable to attach DevTools to current debug session.'));
         });
     });
 });

test/utils.test.ts

@@ -146,7 +146,7 @@ describe("utils", () => {
             // Ensure that the fetchUri call rejects with the expected reason
             await expect(responsePromise).rejects.toBe(expectedErrorReason);
             expect(promiseRejectCount).toEqual(1);
-            expect(mockOnReturn).toHaveBeenCalledWith ("error", expect.any(Function));
+            expect(mockOnReturn).toHaveBeenCalledWith("error", expect.any(Function));
         });
 
         it("rejects 'statusCode' errors correctly", async () => {
@@ -321,7 +321,7 @@ describe("utils", () => {
             expect(useHttps).toBe(expected.useHttps);
             expect(defaultUrl).toBe(expected.defaultUrl);
             expect(userDataDir).toBe(expected.userDataDir);
-            expect(vscodeMock.workspace.getConfiguration).toHaveBeenCalledWith (utils.SETTINGS_STORE_NAME);
+            expect(vscodeMock.workspace.getConfiguration).toHaveBeenCalledWith(utils.SETTINGS_STORE_NAME);
         });
 
         it("uses user config", async () => {
@@ -1013,7 +1013,7 @@ describe("utils", () => {
 
             for (let i = 0; i < input.length; i++) {
                 utils.reportUrlType(input[i], reporter);
-                expect(reporter.sendTelemetryEvent).toHaveBeenCalledWith ('user/browserNavigation', { 'urlType': expected[i] });
+                expect(reporter.sendTelemetryEvent).toHaveBeenCalledWith('user/browserNavigation', { 'urlType': expected[i] });
             }
         });
     });
@@ -1022,7 +1022,7 @@ describe("utils", () => {
         it('correctly lists extension types in the workspace', async () => {
             const reporter = createFakeTelemetryReporter();
             await utils.reportFileExtensionTypes(reporter);
-            expect(reporter.sendTelemetryEvent).toHaveBeenCalledWith ('workspace/metadata', undefined, {"css": 1, "html": 0, "js": 1, "json": 1, "jsx": 1, "mjs": 0, "other": 0, "scss": 0, "total": 4, "ts": 0});
+            expect(reporter.sendTelemetryEvent).toHaveBeenCalledWith('workspace/metadata', undefined, {"css": 1, "html": 0, "js": 1, "json": 1, "jsx": 1, "mjs": 0, "other": 0, "scss": 0, "total": 4, "ts": 0});
         });
     });