Skip to content

Commit 8a05bb7

Browse files
CsCherrYYCsCherrYY
committed
mix create project modes
1 parent 0135073 commit 8a05bb7

10 files changed

Lines changed: 76 additions & 55 deletions

‎extension/package.json‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -326,11 +326,6 @@
326326
"category": "Gradle",
327327
"title": "Create a Gradle Java Project..."
328328
},
329-
{
330-
"command": "gradle.createProjectAdvanced",
331-
"category": "Gradle",
332-
"title": "Create a Gradle Java Project... (Advanced)"
333-
},
334329
{
335330
"command": "gradle.runTasks",
336331
"category": "Gradle",

‎extension/src/commands/Commands.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ import { GradleTaskProvider } from "../tasks";
7373
import { isJavaExtEnabled } from "../util/javaExtension";
7474
import { GradleDaemonsTreeDataProvider, GradleTasksTreeDataProvider, RecentTasksTreeDataProvider } from "../views";
7575
import { Command } from "./Command";
76-
import { COMMAND_CREATE_PROJECT, COMMAND_CREATE_PROJECT_ADVANCED, CreateProjectCommand } from "./CreateProjectCommand";
76+
import { COMMAND_CREATE_PROJECT, CreateProjectCommand } from "./CreateProjectCommand";
7777
import { HideStoppedDaemonsCommand, HIDE_STOPPED_DAEMONS } from "./HideStoppedDaemonsCommand";
7878
import { COMMAND_RELOAD_JAVA_PROJECT, ReloadJavaProjectsCommand } from "./ReloadJavaProjectsCommand";
7979
import { COMMAND_RUN_TASKS, RunTasksCommand } from "./RunTasksCommand";
@@ -186,7 +186,6 @@ export class Commands {
186186
this.registerCommand(SHOW_STOPPED_DAEMONS, new ShowStoppedDaemonsCommand(this.gradleDaemonsTreeDataProvider));
187187
this.registerCommand(HIDE_STOPPED_DAEMONS, new HideStoppedDaemonsCommand(this.gradleDaemonsTreeDataProvider));
188188
this.registerCommand(COMMAND_CREATE_PROJECT, new CreateProjectCommand(this.client), [false]);
189-
this.registerCommand(COMMAND_CREATE_PROJECT_ADVANCED, new CreateProjectCommand(this.client), [true]);
190189
this.registerCommand(COMMAND_RUN_TASKS, new RunTasksCommand(this.gradleTaskProvider));
191190
if (isJavaExtEnabled()) {
192191
this.registerCommand(COMMAND_RELOAD_JAVA_PROJECT, new ReloadJavaProjectsCommand());

‎extension/src/commands/CreateProjectCommand.ts‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import { getProjectOpenBehaviour, ProjectOpenBehaviourValue } from "../util/conf
1212
import { Command } from "./Command";
1313

1414
export const COMMAND_CREATE_PROJECT = "gradle.createProject";
15-
export const COMMAND_CREATE_PROJECT_ADVANCED = "gradle.createProjectAdvanced";
1615

1716
export class CreateProjectCommand extends Command {
1817
constructor(private client: GradleClient) {
@@ -32,7 +31,7 @@ export class CreateProjectCommand extends Command {
3231
canSelectFolders: true,
3332
canSelectMany: false,
3433
});
35-
const isAdvanced = params[0] as boolean;
34+
const isAdvanced = false;
3635
if (targetFolderUri) {
3736
const metadata: IProjectCreationMetadata = {
3837
isAdvanced: isAdvanced,
@@ -43,7 +42,7 @@ export class CreateProjectCommand extends Command {
4342
projectName: path.basename(targetFolderUri[0].fsPath),
4443
sourcePackageName: await this.client.getNormalizedPackageName(path.basename(targetFolderUri[0].fsPath)),
4544
steps: [],
46-
nextStep: isAdvanced ? selectProjectTypeStep : selectScriptDSLStep,
45+
nextStep: selectScriptDSLStep,
4746
client: this.client,
4847
};
4948
const success = await this.runSteps(metadata);
@@ -104,6 +103,10 @@ export class CreateProjectCommand extends Command {
104103
}
105104
step = metadata.steps.pop();
106105
break;
106+
case StepResult.RESTART:
107+
metadata.steps = [];
108+
step = selectProjectTypeStep;
109+
break;
107110
case StepResult.STOP:
108111
return false; // user cancellation
109112
default:
@@ -113,7 +116,6 @@ export class CreateProjectCommand extends Command {
113116
return true;
114117
}
115118

116-
// eslint-disable-next-line @typescript-eslint/no-unused-vars
117119
private async createProject(metadata: IProjectCreationMetadata): Promise<void> {
118120
const cancellationKey = getRunTaskCommandCancellationKey(metadata.targetFolder, "init");
119121
const args: string[] = ["init"];

‎extension/src/createProject/SelectProjectTypeStep.ts‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import * as vscode from "vscode";
55
import { selectScriptDSLStep } from "./SelectScriptDSLStep";
66
import { IProjectCreationMetadata, IProjectCreationStep, ProjectType, StepResult } from "./types";
7+
import { updateTotalSteps } from "./utils";
78

89
export class SelectProjectTypeStep implements IProjectCreationStep {
910
public async run(metadata: IProjectCreationMetadata): Promise<StepResult> {
@@ -25,19 +26,17 @@ export class SelectProjectTypeStep implements IProjectCreationStep {
2526
switch (selectedType.label) {
2627
case "application":
2728
metadata.projectType = ProjectType.JAVA_APPLICATION;
28-
metadata.totalSteps = 5;
2929
break;
3030
case "library":
3131
metadata.projectType = ProjectType.JAVA_LIBRARY;
32-
metadata.totalSteps = 5;
3332
break;
3433
case "Gradle plugin":
3534
metadata.projectType = ProjectType.JAVA_GRADLE_PLUGIN;
36-
metadata.totalSteps = 4; // when creating gradle plugin, we shouldn't specify test framework
3735
break;
3836
default:
3937
resolve(StepResult.STOP);
4038
}
39+
updateTotalSteps(metadata);
4140
metadata.steps.push(selectProjectTypeStep);
4241
metadata.nextStep = selectScriptDSLStep;
4342
resolve(StepResult.NEXT);

‎extension/src/createProject/SelectScriptDSLStep.ts‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import * as vscode from "vscode";
55
import { selectTestFrameworkStep } from "./SelectTestFrameworkStep";
66
import { specifyProjectNameStep } from "./SpecifyProjectNameStep";
77
import { IProjectCreationMetadata, IProjectCreationStep, ProjectType, StepResult } from "./types";
8+
import { createQuickInputButtons, switchToAdvancedLabel, updateTotalSteps } from "./utils";
89

910
export class SelectScriptDSLStep implements IProjectCreationStep {
1011
public async run(metadata: IProjectCreationMetadata): Promise<StepResult> {
@@ -19,16 +20,7 @@ export class SelectScriptDSLStep implements IProjectCreationStep {
1920
pickBox.matchOnDescription = true;
2021
pickBox.ignoreFocusOut = true;
2122
pickBox.items = this.getScriptDSLPickItems();
22-
if (metadata.steps.length) {
23-
pickBox.buttons = [vscode.QuickInputButtons.Back];
24-
disposables.push(
25-
pickBox.onDidTriggerButton((item) => {
26-
if (item === vscode.QuickInputButtons.Back) {
27-
resolve(StepResult.PREVIOUS);
28-
}
29-
})
30-
);
31-
}
23+
pickBox.buttons = createQuickInputButtons(metadata);
3224
disposables.push(
3325
pickBox.onDidAccept(() => {
3426
const selectedScriptDSL = pickBox.selectedItems[0];
@@ -52,6 +44,15 @@ export class SelectScriptDSLStep implements IProjectCreationStep {
5244
resolve(StepResult.NEXT);
5345
}
5446
}),
47+
pickBox.onDidTriggerButton((item) => {
48+
if (item === vscode.QuickInputButtons.Back) {
49+
resolve(StepResult.PREVIOUS);
50+
} else if (item.tooltip === switchToAdvancedLabel) {
51+
metadata.isAdvanced = true;
52+
updateTotalSteps(metadata);
53+
resolve(StepResult.RESTART);
54+
}
55+
}),
5556
pickBox.onDidHide(() => {
5657
resolve(StepResult.STOP);
5758
})

‎extension/src/createProject/SelectTestFrameworkStep.ts‎

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import * as vscode from "vscode";
55
import { specifyProjectNameStep } from "./SpecifyProjectNameStep";
66
import { IProjectCreationMetadata, IProjectCreationStep, StepResult, TestFramework } from "./types";
7+
import { createQuickInputButtons } from "./utils";
78

89
export class SelectTestFrameworkStep implements IProjectCreationStep {
910
public async run(metadata: IProjectCreationMetadata): Promise<StepResult> {
@@ -18,16 +19,7 @@ export class SelectTestFrameworkStep implements IProjectCreationStep {
1819
pickBox.matchOnDescription = true;
1920
pickBox.ignoreFocusOut = true;
2021
pickBox.items = this.getTestFrameworkPickItems();
21-
if (metadata.steps.length) {
22-
pickBox.buttons = [vscode.QuickInputButtons.Back];
23-
disposables.push(
24-
pickBox.onDidTriggerButton((item) => {
25-
if (item === vscode.QuickInputButtons.Back) {
26-
resolve(StepResult.PREVIOUS);
27-
}
28-
})
29-
);
30-
}
22+
pickBox.buttons = createQuickInputButtons(metadata);
3123
disposables.push(
3224
pickBox.onDidAccept(() => {
3325
const selectedTestFramework = pickBox.selectedItems[0];
@@ -54,6 +46,11 @@ export class SelectTestFrameworkStep implements IProjectCreationStep {
5446
resolve(StepResult.NEXT);
5547
}
5648
}),
49+
pickBox.onDidTriggerButton((item) => {
50+
if (item === vscode.QuickInputButtons.Back) {
51+
resolve(StepResult.PREVIOUS);
52+
}
53+
}),
5754
pickBox.onDidHide(() => {
5855
resolve(StepResult.STOP);
5956
})

‎extension/src/createProject/SpecifyProjectNameStep.ts‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import * as vscode from "vscode";
55
import { specifySourcePackageNameStep } from "./SpecifySourcePackageNameStep";
66
import { IProjectCreationMetadata, IProjectCreationStep, StepResult } from "./types";
7+
import { createQuickInputButtons, switchToAdvancedLabel, updateTotalSteps } from "./utils";
78

89
export class SpecifyProjectNameStep implements IProjectCreationStep {
910
public async run(metadata: IProjectCreationMetadata): Promise<StepResult> {
@@ -19,16 +20,7 @@ export class SpecifyProjectNameStep implements IProjectCreationStep {
1920
inputBox.value = metadata.projectName;
2021
inputBox.ignoreFocusOut = true;
2122
inputBox.validationMessage = this.isValidProjectName(metadata.projectName);
22-
if (metadata.steps.length) {
23-
inputBox.buttons = [vscode.QuickInputButtons.Back];
24-
disposables.push(
25-
inputBox.onDidTriggerButton((item) => {
26-
if (item === vscode.QuickInputButtons.Back) {
27-
resolve(StepResult.PREVIOUS);
28-
}
29-
})
30-
);
31-
}
23+
inputBox.buttons = createQuickInputButtons(metadata);
3224
disposables.push(
3325
inputBox.onDidChangeValue(() => {
3426
inputBox.validationMessage = this.isValidProjectName(inputBox.value);
@@ -42,6 +34,15 @@ export class SpecifyProjectNameStep implements IProjectCreationStep {
4234
metadata.nextStep = !metadata.isAdvanced ? undefined : specifySourcePackageNameStep;
4335
resolve(StepResult.NEXT);
4436
}),
37+
inputBox.onDidTriggerButton((item) => {
38+
if (item === vscode.QuickInputButtons.Back) {
39+
resolve(StepResult.PREVIOUS);
40+
} else if (item.tooltip === switchToAdvancedLabel) {
41+
metadata.isAdvanced = true;
42+
updateTotalSteps(metadata);
43+
resolve(StepResult.RESTART);
44+
}
45+
}),
4546
inputBox.onDidHide(() => {
4647
resolve(StepResult.STOP);
4748
})

‎extension/src/createProject/SpecifySourcePackageNameStep.ts‎

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
import * as vscode from "vscode";
55
import { IProjectCreationMetadata, IProjectCreationStep, StepResult } from "./types";
6-
import { asyncDebounce } from "./utils";
6+
import { asyncDebounce, createQuickInputButtons } from "./utils";
77

88
export class SpecifySourcePackageNameStep implements IProjectCreationStep {
99
public static GET_NORMALIZED_PACKAGE_NAME = "getNormalizedPackageName";
@@ -33,16 +33,7 @@ export class SpecifySourcePackageNameStep implements IProjectCreationStep {
3333
inputBox.placeholder = "e.g. " + normalizedName;
3434
inputBox.value = normalizedName as string;
3535
inputBox.ignoreFocusOut = true;
36-
if (metadata.steps.length) {
37-
inputBox.buttons = [vscode.QuickInputButtons.Back];
38-
disposables.push(
39-
inputBox.onDidTriggerButton((item) => {
40-
if (item === vscode.QuickInputButtons.Back) {
41-
resolve(StepResult.PREVIOUS);
42-
}
43-
})
44-
);
45-
}
36+
inputBox.buttons = createQuickInputButtons(metadata);
4637
disposables.push(
4738
inputBox.onDidChangeValue(async () => {
4839
const normalizedName = await getNormalizedPackageNameTrigger(inputBox.value);
@@ -66,6 +57,11 @@ export class SpecifySourcePackageNameStep implements IProjectCreationStep {
6657
resolve(StepResult.NEXT);
6758
}
6859
}),
60+
inputBox.onDidTriggerButton((item) => {
61+
if (item === vscode.QuickInputButtons.Back) {
62+
resolve(StepResult.PREVIOUS);
63+
}
64+
}),
6965
inputBox.onDidHide(() => {
7066
resolve(StepResult.STOP);
7167
})

‎extension/src/createProject/types.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ export enum StepResult {
2525
NEXT,
2626
STOP,
2727
PREVIOUS,
28+
// used for switching mode and restart all steps
29+
RESTART,
2830
}
2931

3032
export enum ProjectType {

‎extension/src/createProject/utils.ts‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33

44
/* eslint-disable @typescript-eslint/no-explicit-any */
55
import { debounce } from "lodash";
6+
import { QuickInputButton, QuickInputButtons, ThemeIcon } from "vscode";
7+
import { IProjectCreationMetadata, ProjectType } from "./types";
8+
9+
export const switchToAdvancedLabel = "Switch to advanced mode...";
610

711
export function asyncDebounce(func: any, wait: any, bind: any) {
812
const debounced = debounce(async (resolve, reject, bindSelf, args) => {
@@ -22,3 +26,28 @@ export function asyncDebounce(func: any, wait: any, bind: any) {
2226

2327
return returnFunc;
2428
}
29+
30+
export function updateTotalSteps(metadata: IProjectCreationMetadata): void {
31+
if (!metadata.isAdvanced) {
32+
metadata.totalSteps = 2;
33+
} else if (metadata.projectType === ProjectType.JAVA_GRADLE_PLUGIN) {
34+
// when creating gradle plugin, we shouldn't specify test framework
35+
metadata.totalSteps = 4;
36+
} else {
37+
metadata.totalSteps = 5;
38+
}
39+
}
40+
41+
export function createQuickInputButtons(metadata: IProjectCreationMetadata): QuickInputButton[] {
42+
const buttons: QuickInputButton[] = [];
43+
if (metadata.steps.length) {
44+
buttons.push(QuickInputButtons.Back);
45+
}
46+
if (!metadata.isAdvanced) {
47+
buttons.push({
48+
iconPath: new ThemeIcon("settings-gear"),
49+
tooltip: switchToAdvancedLabel,
50+
});
51+
}
52+
return buttons;
53+
}

0 commit comments

Comments
 (0)