Forward css.format.* settings to js-beautify's CSS sub-formatter#238
Merged
aeschli merged 1 commit intomicrosoft:mainfrom Apr 10, 2026
Merged
Conversation
The HTML formatter uses js-beautify which already supports CSS formatting options via a css sub-object, but HTMLFormatConfiguration never passed them through. This caused css.format.newlineBetweenSelectors, newlineBetweenRules, and other CSS settings to be ignored when formatting embedded CSS in <style> tags. - Add EmbeddedCSSFormatConfiguration interface to HTMLFormatConfiguration - Map camelCase CSS options to snake_case js-beautify options in htmlFormatter - Add css property to IBeautifyHTMLOptions type declaration - Add tests for embedded CSS formatting options Fixes microsoft/vscode#283316
Contributor
Author
|
@microsoft-github-policy-service agree |
aeschli
approved these changes
Apr 10, 2026
Collaborator
|
Thanks @NikhiltGhalme ! |
jrieken
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTML formatter uses js-beautify which already supports CSS formatting options via a css sub-object, but HTMLFormatConfiguration never passed them through. This caused css.format.newlineBetweenSelectors, newlineBetweenRules, and other CSS settings to be ignored when formatting embedded CSS in <style> tags.
Fixes microsoft/vscode#283316