feat: integrate the flow

FluoriteCafe-work · FluoriteCafe-work · commit 050304690467 · 2025-09-10T13:53:59.000+08:00
diff --git a/src/upgrade/display/notificationManager.ts b/src/upgrade/display/notificationManager.ts
@@ -2,32 +2,48 @@
 // Licensed under the MIT license.
 
 import { commands, window } from "vscode";
-import type { FileIssues } from "../type";
-import { buildFixPrompt, buildMessage } from "../utility";
+import type { UpgradeIssue } from "../type";
+import { buildFixPrompt } from "../utility";
 import { Commands } from "../../commands";
 
 class NotificationManager {
     private hasShown = false;
 
-
-    async refresh(issues: FileIssues) {
-        const targetIssue = Object.values(issues)[0];
-
-        if (!targetIssue) {
+    async triggerNotification(projectIssues: Record<string, UpgradeIssue[]>) {
+        if (!this.shouldShow()) {
             return;
         }
 
-        if (this.hasShown) {
-            return;
+        const lines = [
+            "Fix the following version issues:",
+        ];
+        for (const [pomPath, issues] of Object.entries(projectIssues)) {
+            lines.push("");
+            lines.push(`For project "${pomPath}":`);
+            const linesForCurrentProject = new Set<string>();
+            for (const issue of issues) {
+                linesForCurrentProject.add(buildFixPrompt(issue));
+            }
+            lines.push(...linesForCurrentProject);
+            lines.push("\n");
         }
 
+        const prompt = lines.join("\n");
+        const projectCount = Object.keys(projectIssues).length;
+        const issueCount = Object.values(projectIssues).map(x => x.length).reduce((a, b) => a + b, 0);
+
         const buttonText = "Upgrade";
-        const selection = await window.showInformationMessage(buildMessage(targetIssue), buttonText);
+        const selection = await window.showInformationMessage(`${issueCount} version issue(s) found in ${projectCount} project(s).`, buttonText);
         this.hasShown = true;
         if (selection === buttonText) {
-            commands.executeCommand(Commands.VIEW_TRIGGER_JAVA_UPGRADE_TOOL, buildFixPrompt(targetIssue));
+            commands.executeCommand(Commands.VIEW_TRIGGER_JAVA_UPGRADE_TOOL, prompt);
         }
     }
+
+    private shouldShow() {
+        // TODO: fix
+        return !this.hasShown;
+    }
 }
 
 const notificationManager = new NotificationManager();
diff --git a/src/upgrade/metadataManager.ts b/src/upgrade/metadataManager.ts
@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license.
 
-import type { DependencyCheckMetadata, DependencyCheckResult } from "./type";
+import type { DependencyCheckMetadata, DependencyCheckItem } from "./type";
 import { Upgrade } from "../constants";
 import { buildPackageId } from "./utility";
 import DEPENDENCIES_TO_SCAN from "./dependency.data";
@@ -10,7 +10,7 @@ import DEPENDENCIES_TO_SCAN from "./dependency.data";
 class MetadataManager {
     private dependencyCheckMetadata: DependencyCheckMetadata = DEPENDENCIES_TO_SCAN;
 
-    public getMetadataById(givenPackageId: string): DependencyCheckResult | undefined {
+    public getMetadataById(givenPackageId: string): DependencyCheckItem | undefined {
         const splits = givenPackageId.split(":", 2);
         const groupId = splits[0];
         const artifactId = splits[1] ?? "";
@@ -19,7 +19,6 @@ class MetadataManager {
             return {
                 name: Upgrade.DIAGNOSTICS_NAME_FOR_JAVA_ENGINE,
                 supportedVersion: `>=${Upgrade.LATEST_JAVA_LTS_VESRION}`,
-                packageRuleUsed: buildPackageId(Upgrade.DIAGNOSTICS_GROUP_ID_FOR_JAVA_ENGINE, "*"),
             };
         }
 
@@ -28,7 +27,7 @@ class MetadataManager {
         return this.getMetadata(packageId) ?? this.getMetadata(packageIdWithWildcardArtifactId);
     }
 
-    private getMetadata(packageRuleUsed: string): DependencyCheckResult | undefined {
+    private getMetadata(packageRuleUsed: string) {
         return this.dependencyCheckMetadata[packageRuleUsed] ? {
             ...this.dependencyCheckMetadata[packageRuleUsed], packageRuleUsed
         } : undefined;
diff --git a/src/upgrade/type.ts b/src/upgrade/type.ts
@@ -1,6 +1,5 @@
 export type DependencyCheckItem = { name: string, supportedVersion: string };
 export type DependencyCheckMetadata = Record<string, DependencyCheckItem>;
-export type DependencyCheckResult = DependencyCheckItem & { packageRuleUsed: string };
 
 export enum UpgradeReason {
     END_OF_LIFE,
@@ -14,6 +13,4 @@ export type UpgradeIssue = {
     reason: UpgradeReason;
     currentVersion: string;
     suggestedVersion?: string;
-};
-
-export type FileIssues = Record</* packageId */string, UpgradeIssue>;
+};
diff --git a/src/upgrade/upgradeManager.ts b/src/upgrade/upgradeManager.ts
@@ -12,6 +12,7 @@ import { instrumentOperationAsVsCodeCommand } from "vscode-extension-telemetry-w
 import { Commands } from "../commands";
 import metadataManager from "./metadataManager";
 import { buildPackageId } from "./utility";
+import notificationManager from "./display/notificationManager";
 
 const DEFAULT_UPGRADE_PROMPT = "Upgrade Java project dependency";
 
@@ -65,20 +66,22 @@ async function getProjectIssues(projectNode: INodeData): Promise<UpgradeIssue[]>
     const issues: UpgradeIssue[] = [];
     issues.push(...getJavaIssues(projectNode));
     const packageData = await Jdtls.getPackageData({ kind: NodeKind.Project, projectUri: projectNode.uri });
-    packageData
-        .filter(x => x.kind === NodeKind.Container)
-        .forEach(async (packageContainer) => {
-            const packages = await Jdtls.getPackageData({
-                kind: NodeKind.Container,
-                projectUri: projectNode.uri,
-                path: packageContainer.path,
-            });
-            packages.forEach(
-                (pkg) => {
-                    issues.push(...getDependencyIssues(pkg))
-                }
-            );
-        });
+    await Promise.allSettled(
+        packageData
+            .filter(x => x.kind === NodeKind.Container)
+            .map(async (packageContainer) => {
+                const packages = await Jdtls.getPackageData({
+                    kind: NodeKind.Container,
+                    projectUri: projectNode.uri,
+                    path: packageContainer.path,
+                });
+                packages.forEach(
+                    (pkg) => {
+                        issues.push(...getDependencyIssues(pkg))
+                    }
+                );
+            })
+    );
     return issues;
 }
 
@@ -110,17 +113,23 @@ class UpgradeManager {
         const projectIssues: Record</* pomPath */string, UpgradeIssue[]> = {};
         const uri = folder.uri.toString();
         const projects = await Jdtls.getProjects(uri);
-        projects.forEach(async (projectNode) => {
+        let hasIssues = false;
+        await Promise.allSettled(projects.map(async (projectNode) => {
             const pomPath = projectNode.metaData?.PomPath as string | undefined;
             if (!pomPath) {
                 return;
             }
 
             const issues = await getProjectIssues(projectNode);
+            if (issues.length > 0) {
+                hasIssues = true;
+            }
             projectIssues[pomPath] = issues;
-        });
+        }));
 
-        // TODO: show notification
+        if (hasIssues) {
+            notificationManager.triggerNotification(projectIssues);
+        }
     }
 
 
diff --git a/src/upgrade/utility.ts b/src/upgrade/utility.ts
@@ -1,23 +1,6 @@
 import { Uri } from "vscode";
 import { UpgradeReason, type UpgradeIssue } from "./type";
 
-export function buildMessage(issue: UpgradeIssue): string {
-    const { packageId, packageDisplayName, currentVersion, reason } = issue;
-    const name = packageDisplayName ?? packageId;
-
-    switch (reason) {
-        case UpgradeReason.END_OF_LIFE: {
-            return `Your project dependency ${name} (${currentVersion}) is in end-of-life. Consider upgrading using GitHub Copilot for better security and performance.`;
-        }
-        case UpgradeReason.CVE: {
-            return `Your project dependency ${name} (${currentVersion}) has CVE. Consider upgrading using GitHub Copilot for better security.`;
-        }
-        case UpgradeReason.ENGINE_TOO_OLD: {
-            return `Your project Java version (${currentVersion}) is too old. Consider upgrading using GitHub Copilot for better performance and features.`;
-        }
-    }
-}
-
 export function buildFixPrompt(issue: UpgradeIssue): string {
     const { packageId, packageDisplayName, reason, suggestedVersion } = issue;
     const name = packageDisplayName ?? packageId;
@@ -28,13 +11,13 @@ export function buildFixPrompt(issue: UpgradeIssue): string {
 
     switch (reason) {
         case UpgradeReason.END_OF_LIFE: {
-            return [`Upgrade the package ${name} using Java Upgrade Tool.`, ...suffix].join(" ");
+            return [`Upgrade the package ${name}.`, ...suffix].join(" ");
         }
         case UpgradeReason.CVE: {
-            return [`Upgrade the package ${name} to resolve CVE using Java Upgrade Tool.`, ...suffix].join(" ");
+            return [`Upgrade the package ${name} to address CVE issues.`, ...suffix].join(" ");
         }
         case UpgradeReason.ENGINE_TOO_OLD: {
-            return [`Upgrade Java version using Java Upgrade Tool.`, ...suffix].join(" ");
+            return [`Upgrade the version of Java.`, ...suffix].join(" ");
         }
     }
 }
