chore: improve java upgrade telemetry tracking and extension installation flow (#1030)

* Add source/install telemetry and drop unreliable activation check

Follow-up to v0.27.5 telemetry analysis
(devdiv-azure-service-dmitryr/azure-java-migration-copilot-vscode-extension#5979):

- Add a source field (SOURCE_CVE / SOURCE_JAVA_UPGRADE) to the
  upgradeNotification.show event so NOTIFY-level data can be split by
  CVE vs upgrade and aligned with downstream funnel stages.
- Emit an installSucceeded event (with the initial extensionState, so
  fresh installs and updates can be told apart) right after
  installExtension resolves.
- Drop the post-install getExtensionState re-check that produced false
  activation-timeout results; the not-installed path now reports
  proceeded and returns true after install completes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Drop dedicated installSucceeded telemetry event

Address review: avoid adding a new business operationName for the
install step. Install success is already implied by the subsequent
upgradeFlow.result event under the same operation ID.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Track install-success as a dimension on the result event

Address review: instead of a dedicated installSucceeded operationName,
reuse the stable java.dependency.upgradeFlow.result event and mark the
install step with an upgradeFlowStep dimension (plus extensionState so
fresh installs and updates can be told apart). Easier to query and evolve.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Label install step by action instead of pre-install state

Address review: extensionState was the pre-install value, so tagging a
'succeeded' event with 'not-installed'/'outdated' was contradictory.
Replace it with installType ('installed' vs 'updated') derived from the
pre-install state, which is unambiguous and avoids an unreliable
post-install state recompute (the original activation-race bug).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Don't prompt to enable extension in upgrade flow

extensions.getExtension() returns undefined both when the extension is
disabled and when it is freshly installed but not yet activated, so the
'seems disabled, enable it manually' prompt is misleading right after a
successful install. Skip it on the upgrade path; the function and the
modernization caller are left unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Wait for extension registration via onDidChange instead of fixed sleep

Replace the fixed 2s wait after a fresh install with an event-driven
wait: resolve immediately if the extension is already registered,
otherwise listen on extensions.onDidChange and proceed as soon as it
appears, with a 5s timeout fallback. Returns as early as possible while
still bounding the wait.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Frank Liu <haital@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: wenyt <75360946+wenytang-ms@users.noreply.github.com>

Author: 4 people

src/upgrade/display/notificationManager.ts

@@ -93,6 +93,7 @@ class NotificationManager implements IUpgradeIssuesRenderer {
                 sendInfo(operationId, {
                     operationName: "java.dependency.upgradeNotification.show",
                     extensionState,
+                    source: hasCVEIssue ? Upgrade.SOURCE_CVE : Upgrade.SOURCE_JAVA_UPGRADE,
                 });
 
                 const buttons = hasCVEIssue

src/upgrade/utility.ts

@@ -197,6 +197,11 @@ export async function checkOrInstallAppModExtensionForUpgrade(
         }
 
         await commands.executeCommand("workbench.extensions.installExtension", ExtensionName.APP_MODERNIZATION_FOR_JAVA);
+        sendInfo(operationId, {
+            operationName: "java.dependency.upgradeFlow.result",
+            upgradeFlowStep: "installSucceeded",
+            installType: state === "outdated" ? "updated" : "installed",
+        });
 
         if (state === "outdated") {
             // Extension was updated (not freshly installed) — reload required
@@ -219,18 +224,35 @@ export async function checkOrInstallAppModExtensionForUpgrade(
             return false;
         }
 
-        await checkOrPromptToEnableAppModExtension("upgrade");
+        // Wait until the freshly installed extension is registered, returning as
+        // soon as it is ready, or after a 5s timeout fallback at the latest.
+        await waitForExtensionReady(extensionIdToCheck, 5000);
 
-        // Wait briefly for the newly installed extension to activate
-        await new Promise(resolve => setTimeout(resolve, 2000));
-
-        // Re-check if the newly installed extension is active and meets version requirement
-        const newState = getExtensionState(extensionIdToCheck);
-        const canProceed = newState === "up-to-date";
         sendInfo(operationId, {
             operationName: "java.dependency.upgradeFlow.result",
-            upgradeFlowResult: canProceed ? "proceeded" : "activation-timeout",
+            upgradeFlowResult: "proceeded",
         });
-        return canProceed;
+        return true;
     })();
-}
+}
+
+function waitForExtensionReady(extensionId: string, timeoutMs: number): Promise<void> {
+    return new Promise<void>(resolve => {
+        if (extensions.getExtension(extensionId)) {
+            resolve();
+            return;
+        }
+        let timer: NodeJS.Timeout;
+        const disposable = extensions.onDidChange(() => {
+            if (extensions.getExtension(extensionId)) {
+                clearTimeout(timer);
+                disposable.dispose();
+                resolve();
+            }
+        });
+        timer = setTimeout(() => {
+            disposable.dispose();
+            resolve();
+        }, timeoutMs);
+    });
+}