chore(notificationManager): tweak order of shouldShow and hasShown

FluoriteCafe-work · FluoriteCafe-work · commit 478d871575de · 2025-09-16T15:53:59.000+08:00
diff --git a/src/upgrade/display/notificationManager.ts b/src/upgrade/display/notificationManager.ts
@@ -38,14 +38,14 @@ class NotificationManager implements IUpgradeIssuesRenderer {
                 }
                 const issue = issues[0];
 
-                if (this.hasShown) {
+                if (!this.shouldShow()) {
                     return;
                 }
-                this.hasShown = true;
 
-                if (!this.shouldShow()) {
+                if (this.hasShown) {
                     return;
                 }
+                this.hasShown = true;
 
                 const prompt = buildFixPrompt(issue);
                 const notificationMessage = buildNotificationMessage(issue);

Original file line number	Diff line number	Diff line change
`@@ -38,14 +38,14 @@ class NotificationManager implements IUpgradeIssuesRenderer {`
`38`	`38`	`}`
`39`	`39`	`const issue = issues[0];`
`40`	`40`
`41`		`- if (this.hasShown) {`
	`41`	`+ if (!this.shouldShow()) {`
`42`	`42`	`return;`
`43`	`43`	`}`
`44`		`- this.hasShown = true;`
`45`	`44`
`46`		`- if (!this.shouldShow()) {`
	`45`	`+ if (this.hasShown) {`
`47`	`46`	`return;`
`48`	`47`	`}`
	`48`	`+ this.hasShown = true;`
`49`	`49`
`50`	`50`	`const prompt = buildFixPrompt(issue);`
`51`	`51`	`const notificationMessage = buildNotificationMessage(issue);`