Skip to content

Commit 7767d65

Browse files
chore: bring packageRuleUsed for future use
1 parent 7de5583 commit 7767d65

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

src/upgrade/metadataManager.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,13 @@ class MetadataManager {
5757
return {
5858
name: Upgrade.DIAGNOSTICS_NAME_FOR_JAVA_ENGINE,
5959
supportedVersion: `>=${Upgrade.EARLIEST_JAVA_VERSION_NOT_TO_PROMPT}`,
60+
packageRuleUsed: Upgrade.DIAGNOSTICS_GROUP_ID_FOR_JAVA_ENGINE,
6061
};
6162
}
6263

6364
const packageId = buildPackageId(groupId, artifactId);
6465
const packageIdWithWildcardArtifactId = buildPackageId(groupId, "*");
65-
return this.dependencyCheckMetadata[packageId]
66-
?? this.dependencyCheckMetadata[packageIdWithWildcardArtifactId];
66+
return this.getMetadata(packageId) ?? this.getMetadata(packageIdWithWildcardArtifactId);
6767
}
6868

6969
public async tryRefreshMetadata(context: ExtensionContext) {
@@ -85,6 +85,12 @@ class MetadataManager {
8585
this.dependencyCheckMetadata = metadata.data ?? {};
8686
}
8787
}
88+
89+
private getMetadata(packageRuleUsed: string): DependencyCheckResult | undefined {
90+
return this.dependencyCheckMetadata[packageRuleUsed] ? {
91+
...this.dependencyCheckMetadata[packageRuleUsed], packageRuleUsed
92+
} : undefined;
93+
}
8894
}
8995

9096
const metadataManager = new MetadataManager();

src/upgrade/type.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export type MementoItem<T> = {
77
}
88

99
export type DependencyCheckItem = { name: string, supportedVersion: string };
10-
export type DependencyCheckResult = DependencyCheckItem;
10+
export type DependencyCheckResult = DependencyCheckItem & { packageRuleUsed: string };
1111
export type DependencyCheckMetadata = Record<string, DependencyCheckItem>;
1212

1313
export enum UpgradeReason {

0 commit comments

Comments
 (0)