chore: rename java.dependency.enableDependencyDiagnostics

...  to java.dependency.enableDependencyCheckup` as `Diagnostics` is used as a VSCode-specific concept

Author: FluoriteCafe-work

package.json

@@ -333,9 +333,9 @@
           "description": "%configuration.java.dependency.packagePresentation%",
           "default": "flat"
         },
-        "java.dependency.enableDependencyDiagnostics": {
+        "java.dependency.enableDependencyCheckup": {
           "type": "boolean",
-          "description": "%configuration.java.dependency.enableDependencyDiagnostics%",
+          "description": "%configuration.java.dependency.enableDependencyCheckup%",
           "default": true
         },
         "java.project.exportJar.targetPath": {

package.nls.json

@@ -45,7 +45,7 @@
   "configuration.java.dependency.autoRefresh": "Synchronize Java Projects explorer with changes",
   "configuration.java.dependency.refreshDelay": "The delay time (ms) the auto refresh is invoked when changes are detected",
   "configuration.java.dependency.packagePresentation": "Package presentation mode: flat or hierarchical",
-  "configuration.java.dependency.enableDependencyDiagnostics": "Show reminders when your Java runtimes or dependencies need an upgrade.",
+  "configuration.java.dependency.enableDependencyCheckup": "Show reminders when your Java runtimes or dependencies need an upgrade.",
   "configuration.java.project.explorer.showNonJavaResources": "When enabled, the explorer shows non-Java resources.",
   "configuration.java.project.exportJar.targetPath.customization": "The output path of the exported jar. Leave it empty if you want to manually pick the output location.",
   "configuration.java.project.exportJar.targetPath.workspaceFolder": "Export the jar file into the workspace folder. Its name is the same as the folder's.",

src/settings.ts

@@ -58,8 +58,8 @@ export class Settings {
         workspace.getConfiguration("java.dependency").update("packagePresentation", PackagePresentation.Hierarchical, false);
     }
 
-    public static disableWorkspaceDependencyDiagnostics() {
-        return workspace.getConfiguration("java.dependency").update("enableDependencyDiagnostics", false, ConfigurationTarget.Workspace);
+    public static disableWorkspaceDependencyCheckup() {
+        return workspace.getConfiguration("java.dependency").update("enableDependencyCheckup", false, ConfigurationTarget.Workspace);
     }
 
     public static switchNonJavaResourceFilter(enabled: boolean): void {
@@ -112,8 +112,8 @@ export class Settings {
         return workspace.getConfiguration("java.dependency").get("refreshDelay", 2000);
     }
 
-    public static getEnableDependencyDiagnostics() {
-        return workspace.getConfiguration("java.dependency").get("enableDependencyDiagnostics", true);
+    public static getEnableDependencyCheckup() {
+        return workspace.getConfiguration("java.dependency").get("enableDependencyCheckup", true);
     }
 
     public static getExportJarTargetPath(): string {

src/upgrade/display/notificationManager.ts

@@ -67,7 +67,7 @@ class NotificationManager implements IUpgradeIssuesRenderer {
                         break;
                     }
                     case BUTTON_TEXT_DONT_SHOW_AGAIN: {
-                        Settings.disableWorkspaceDependencyDiagnostics();
+                        Settings.disableWorkspaceDependencyCheckup();
                         break;
                     }
                 }
@@ -76,7 +76,7 @@ class NotificationManager implements IUpgradeIssuesRenderer {
     }
 
     private shouldShow() {
-        return Settings.getEnableDependencyDiagnostics()
+        return Settings.getEnableDependencyCheckup()
             && ((this.getSessionCount() ?? 0) >= 0);
     }
 

src/upgrade/upgradeManager.ts

@@ -15,8 +15,8 @@ import assessmentManager from "./assessmentManager";
 const DEFAULT_UPGRADE_PROMPT = "Upgrade Java project dependency to latest version.";
 
 
-function shouldCheckUpgrade() {
-    return Settings.getEnableDependencyDiagnostics()
+function shouldRunCheckup() {
+    return Settings.getEnableDependencyCheckup()
         && !!extensions.getExtension(ExtensionName.APP_MODERNIZATION_UPGRADE_FOR_JAVA);
 }
 
@@ -39,17 +39,17 @@ class UpgradeManager {
     }
 
     public static scan() {
-        if (!shouldCheckUpgrade()) {
+        if (!shouldRunCheckup()) {
             return;
         }
         workspace.workspaceFolders?.forEach((folder) =>
-            UpgradeManager.checkUpgradableComponents(folder)
+            UpgradeManager.runDependencyCheckup(folder)
         );
     }
 
-    private static async checkUpgradableComponents(folder: WorkspaceFolder) {
+    private static async runDependencyCheckup(folder: WorkspaceFolder) {
         return (instrumentOperation("java.dependency.diagnoseDependencyIssues",
-            async () => {
+            async (_operationId: string) => {
                 if (!await languageServerApiManager.ready()) {
                     return;
                 }