Skip to content

Commit a8de401

Browse files
chore: revise strings
1 parent 9d60eb8 commit a8de401

File tree

5 files changed

+13
-11
lines changed

5 files changed

+13
-11
lines changed

package.nls.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"contributes.commands.java.view.package.deleteFilePermanently": "Delete Permanently",
3838
"contributes.commands.java.view.fileExplorer.newPackage": "New Java Package...",
3939
"contributes.commands.java.view.menus.file.newJavaClass": "New Java File",
40-
"contributes.commands.java.view.triggerJavaUpgradeTool": "Upgrade with Java Upgrade Tool",
40+
"contributes.commands.java.view.triggerJavaUpgradeTool": "Upgrade dependencies",
4141
"contributes.submenus.javaProject.new": "New",
4242
"configuration.java.dependency.showMembers": "Show the members in the explorer",
4343
"configuration.java.dependency.syncWithFolderExplorer": "Link Java Projects Explorer with the active editor",

src/upgrade/upgradeCodeActionProvider.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,11 @@ export default class UpgradeCodeActionProvider implements CodeActionProvider {
2525
continue;
2626
}
2727
const metadata = metadataManager.getMetadataByPackageId(issue.rulePackageId);
28+
if (!metadata) {
29+
continue;
30+
}
2831
const action = new CodeAction(
29-
metadata ?
30-
`Fix: Upgrade ${metadata.name} with Java Upgrade Tool` :
31-
`Fix: Upgrade with Java Upgrade Tool`,
32+
`Fix: Upgrade ${metadata.name}`,
3233
CodeActionKind.QuickFix
3334
);
3435

src/upgrade/upgradeCodeLensProvider.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,9 @@ export default class UpgradeCodeLensProvider implements CodeLensProvider {
1818
return;
1919
}
2020
const codeLens = new CodeLens(new Range(0, 0, 0, 0), {
21-
title: `Upgrade ${metadata.name} with Java Upgrade Tool`,
21+
title: "Upgrade",
2222
command: Commands.VIEW_TRIGGER_JAVA_UPGRADE_TOOL,
23+
tooltip: `Upgrade ${metadata.name} with GitHub Copilot`,
2324
arguments: [buildFixPrompt(issue)],
2425
});
2526

@@ -28,8 +29,8 @@ export default class UpgradeCodeLensProvider implements CodeLensProvider {
2829
.filter((x): x is CodeLens => Boolean(x))
2930
.sort((a, b) => {
3031
// always show Java engine upgrade first
31-
if (a.command?.title === `Upgrade ${Upgrade.DIAGNOSTICS_NAME_FOR_JAVA_ENGINE} with Java Upgrade Tool`) return -1;
32-
if (b.command?.title === `Upgrade ${Upgrade.DIAGNOSTICS_NAME_FOR_JAVA_ENGINE} with Java Upgrade Tool`) return 1;
32+
if (a.command?.title === `Upgrade ${Upgrade.DIAGNOSTICS_NAME_FOR_JAVA_ENGINE}`) return -1;
33+
if (b.command?.title === `Upgrade ${Upgrade.DIAGNOSTICS_NAME_FOR_JAVA_ENGINE}`) return 1;
3334
return (a.command?.title ?? "") < (b.command?.title ?? "") ? -1 : 1;
3435
})
3536
.slice(0, 1); // give 1 Code Lens action at most

src/upgrade/upgradeManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import UpgradeCodeActionProvider from "./upgradeCodeActionProvider";
1616
import UpgradeCodeLensProvider from "./upgradeCodeLensProvider";
1717
import { buildPackageId } from "./utility";
1818

19-
const DEFAULT_UPGRADE_PROMPT = "Upgrade project dependency version with Java Upgrade Tool";
19+
const DEFAULT_UPGRADE_PROMPT = "Upgrade Java project dependency";
2020

2121
class UpgradeManager {
2222
public initialize(context: ExtensionContext) {

src/upgrade/utility.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ export function buildMessage(issue: UpgradeIssue): string {
1010

1111
switch (reason) {
1212
case UpgradeReason.END_OF_LIFE: {
13-
return `Your project dependency ${name} (${currentVersion}) is in end-of-life. Consider upgrading using Java Upgrade Tool for better security and performance.`
13+
return `Your project dependency ${name} (${currentVersion}) is in end-of-life. Consider upgrading using GitHub Copilot for better security and performance.`
1414
}
1515
case UpgradeReason.CVE: {
16-
return `Your project dependency ${name} (${currentVersion}) has CVE. Consider upgrading using Java Upgrade Tool for better security.`
16+
return `Your project dependency ${name} (${currentVersion}) has CVE. Consider upgrading using GitHub Copilot for better security.`
1717
}
1818
case UpgradeReason.ENGINE_TOO_OLD: {
19-
return `Your project Java version (${currentVersion}) is too old. Consider upgrading using Java Upgrade Tool for better performance and features.`
19+
return `Your project Java version (${currentVersion}) is too old. Consider upgrading using GitHub Copilot for better performance and features.`
2020
}
2121
}
2222
}

0 commit comments

Comments
 (0)