Skip to content

Commit a9d1dbe

Browse files
author
Ye Zhu
committed
Fix comments
1 parent 744fea2 commit a9d1dbe

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

src/upgrade/assessmentManager.ts

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -183,17 +183,15 @@ async function getAllDependencies(projectNode: INodeData): Promise<PackageDescri
183183
})
184184
);
185185

186-
return allPackages
187-
.map(x => {
188-
if (x.status === "fulfilled") {
189-
return x.value;
190-
}
191-
sendInfo("", {
192-
operationName: "java.dependency.assessmentManager.getAllDependencies.packageDataFailure",
193-
});
194-
return [];
195-
})
196-
.flat();
186+
const fulfilled = allPackages.filter((x): x is PromiseFulfilledResult<PackageDescription[]> => x.status === "fulfilled");
187+
const failedPackageCount = allPackages.length - fulfilled.length;
188+
if (failedPackageCount > 0) {
189+
sendInfo("", {
190+
operationName: "java.dependency.assessmentManager.getAllDependencies.rejected",
191+
failedPackageCount: String(failedPackageCount),
192+
});
193+
}
194+
return fulfilled.map(x => x.value).flat();
197195
}
198196

199197
async function getCVEIssues(dependencies: PackageDescription[]): Promise<UpgradeIssue[]> {

0 commit comments

Comments
 (0)