refactor: address PR review comments

- Remove unused imports in fileOperations.test.ts and libraries.test.ts
- Clean up skipped test bodies and dead beforeEach in libraries.test.ts
- Fix JSDoc comment in vscodeOperator.ts to reflect actual CSS fallbacks
- Increase Playwright timeout from 180s to 240s for LS readiness margin
- Remove cliArgs spread from Electron launch (avoid CLI-only flags)
- Remove VSIX install from globalSetup (extensionDevelopmentPath suffices)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: wenytang-ms

test/e2e/fixtures/baseTest.ts

@@ -16,7 +16,7 @@
  */
 
 import { _electron, test as base, type Page } from "@playwright/test";
-import { downloadAndUnzipVSCode, resolveCliArgsFromVSCodeExecutablePath } from "@vscode/test-electron";
+import { downloadAndUnzipVSCode } from "@vscode/test-electron";
 import * as fs from "fs-extra";
 import * as os from "os";
 import * as path from "path";
@@ -79,7 +79,12 @@ export const test = base.extend<TestFixtures>({
 
         // 2. Resolve VS Code executable.
         const vscodePath = await downloadAndUnzipVSCode(vscodeVersion);
-        const [, ...cliArgs] = resolveCliArgsFromVSCodeExecutablePath(vscodePath);
+        // resolveCliArgsFromVSCodeExecutablePath returns CLI-specific args
+        // (e.g. --ms-enable-electron-run-as-node) that are unsuitable for
+        // Electron UI launch. Extract only --extensions-dir and --user-data-dir.
+        const vscodeTestDir = path.join(EXTENSION_ROOT, ".vscode-test");
+        const extensionsDir = path.join(vscodeTestDir, "extensions");
+        const userDataDir = path.join(vscodeTestDir, "user-data");
 
         // 3. Launch VS Code as an Electron app.
         const electronApp = await _electron.launch({
@@ -95,7 +100,8 @@ export const test = base.extend<TestFixtures>({
                 "--password-store=basic",
                 // Suppress notifications that block UI interactions
                 "--disable-telemetry",
-                ...cliArgs,
+                `--extensions-dir=${extensionsDir}`,
+                `--user-data-dir=${userDataDir}`,
                 `--extensionDevelopmentPath=${EXTENSION_ROOT}`,
                 projectDir,
             ],

test/e2e/globalSetup.ts

@@ -3,12 +3,14 @@
 
 import { downloadAndUnzipVSCode, resolveCliArgsFromVSCodeExecutablePath } from "@vscode/test-electron";
 import * as childProcess from "child_process";
-import * as path from "path";
 
 /**
  * Global setup runs once before all test files.
- * It downloads VS Code, then installs the redhat.java extension and our own
- * VSIX so that every test run starts from an identical, pre-provisioned state.
+ * It downloads VS Code and installs the redhat.java extension so that
+ * every test run starts from an identical, pre-provisioned state.
+ *
+ * Our own extension is loaded at launch time via --extensionDevelopmentPath
+ * (see baseTest.ts), so there is no need to install a VSIX here.
  */
 export default async function globalSetup(): Promise<void> {
     // Download VS Code stable (or the version configured via VSCODE_VERSION env).
@@ -29,19 +31,4 @@ export default async function globalSetup(): Promise<void> {
     // Install the Language Support for Java extension from the Marketplace.
     console.log("[globalSetup] Installing redhat.java extension…");
     childProcess.execFileSync(cli, [...cliArgs, "--install-extension", "redhat.java"], execOptions);
-
-    // Install our own VSIX if one exists (built by `vsce package`).
-    const vsixGlob = path.join(__dirname, "..", "..", "*.vsix");
-    const glob = require("glob");
-    const vsixFiles: string[] = glob.sync(vsixGlob);
-    if (vsixFiles.length > 0) {
-        const vsix = vsixFiles[0];
-        console.log(`[globalSetup] Installing VSIX ${path.basename(vsix)}…`);
-        childProcess.execFileSync(cli, [...cliArgs, "--install-extension", vsix], {
-            ...execOptions,
-            timeout: 60_000,
-        });
-    } else {
-        console.log("[globalSetup] No VSIX found — extension will be loaded via extensionDevelopmentPath");
-    }
 }

test/e2e/playwright.config.ts

@@ -10,7 +10,7 @@ export default defineConfig({
         ? [["list"], ["junit", { outputFile: path.join(__dirname, "..", "..", "test-results", "e2e-results.xml") }]]
         : "list",
     // Java Language Server can take 2-3 minutes to fully index on first run.
-    timeout: 180_000,
+    timeout: 240_000,
     // Run tests sequentially — launching multiple VS Code instances is too resource-heavy.
     workers: 1,
     // Allow one retry in CI to handle transient environment issues.

test/e2e/tests/fileOperations.test.ts

@@ -11,8 +11,6 @@
  *  - java.view.package.moveFileToTrash
  */
 
-import * as fs from "fs-extra";
-import * as path from "path";
 import { test, expect } from "../fixtures/baseTest";
 import { Timeout, VSCode } from "../utils/constants";
 import JavaOperator from "../utils/javaOperator";

test/e2e/tests/libraries.test.ts

@@ -10,28 +10,15 @@
  *  - java.project.create
  */
 
-import * as fs from "fs-extra";
-import * as os from "os";
-import * as path from "path";
-import { test, expect } from "../fixtures/baseTest";
-import { Timeout, VSCode } from "../utils/constants";
-import JavaOperator from "../utils/javaOperator";
-import VscodeOperator from "../utils/vscodeOperator";
+import { test } from "../fixtures/baseTest";
 
 test.describe("Libraries & Project Creation", () => {
 
     test.describe("invisible project library management", () => {
 
         test.use({ testProjectDir: "invisible" });
 
-        test.beforeEach(async ({ page }) => {
-            await VscodeOperator.dismissModalDialog(page);
-            await JavaOperator.openFile(page, "App.java");
-            await JavaOperator.waitForJavaLSReady(page);
-            await JavaOperator.focusJavaProjects(page);
-        });
-
-        test.skip("add and remove JAR library", async ({ page }) => {
+        test.skip("add and remove JAR library", async () => {
             // Skip: the addLibraries command opens a native OS file dialog
             // (vscode.window.showOpenDialog) which Playwright cannot automate.
             // This test requires Electron dialog mocking support.
@@ -42,38 +29,11 @@ test.describe("Libraries & Project Creation", () => {
 
         test.use({ testProjectDir: "invisible" });
 
-        test.skip("java.project.create with no build tools", async ({ page }) => {
+        test.skip("java.project.create with no build tools", async () => {
             // Skip: after selecting "No build tools", scaffoldSimpleProject()
             // calls vscode.window.showOpenDialog() which opens a native OS file
             // dialog that Playwright cannot automate. This test requires
             // Electron dialog mocking support.
-            await VscodeOperator.dismissModalDialog(page);
-            await JavaOperator.openFile(page, "App.java");
-            await JavaOperator.waitForJavaLSReady(page);
-
-            // Create a temp folder for the new project
-            const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "java-new-project-"));
-
-            await VscodeOperator.executeCommand(page, "Java: Create Java Project");
-            // The build-tool quick pick may take a moment to appear
-            await page.waitForTimeout(Timeout.TREE_EXPAND);
-
-            // Select "No build tools"
-            await VscodeOperator.selectQuickPickItem(page, "No build tools");
-
-            // The project location dialog uses a native file picker on some platforms.
-            // Enter the project name when prompted.
-            await VscodeOperator.fillQuickInput(page, "helloworld");
-
-            // Wait for project files to be created
-            await page.waitForTimeout(Timeout.TREE_EXPAND * 2);
-
-            // Clean up
-            try {
-                fs.rmSync(tmpDir, { force: true, recursive: true });
-            } catch {
-                // Ignore cleanup errors
-            }
         });
     });
 });

test/e2e/utils/vscodeOperator.ts

@@ -4,8 +4,9 @@
 /**
  * Generic VS Code UI helpers built on Playwright Page.
  *
- * All methods use ARIA roles / labels rather than CSS classes so that they
- * survive VS Code version upgrades.
+ * These helpers prefer ARIA roles / labels over CSS classes where possible
+ * to better survive VS Code version upgrades, but some fall back to CSS
+ * selectors when needed.
  */
 
 import { Page } from "@playwright/test";