Skip to content

Commit b06302e

Browse files
wenytang-msCopilot
andcommitted
test(e2e): address Copilot review on header comments
Two header comments were internally inconsistent with the plan body: 1. java-dep-export-jar.yaml line 21-22 said 'we set it via workspaceSettings' but the setup block actually uses user-level \settings:\. The detailed rationale further down already explains the user-level choice; the upstream summary now matches. 2. java-dep-project-creation.yaml line 35-36 said the template ships 'plus an empty lib/ ensure-dir'. The template directory in the repo contains only README.md, .vscode/settings.json and src/App.java — the empty lib/ is created at runtime by scaffoldSimpleProject via \ se.ensureDir(path.join(projectRoot, 'lib'))\ (projectController.ts:185), not by the template copy. Reworded to make the distinction explicit. Doc-only changes; YAML behaviour and assertions unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 2e5553e commit b06302e

2 files changed

Lines changed: 14 additions & 9 deletions

File tree

test/e2e-plans/java-dep-export-jar.yaml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@
1717
# a. generateClasspaths → multi-select quick-pick if >1 dependency item
1818
# b. showSaveDialog → only if outputPath === "" (skipped when
1919
# java.project.exportJar.targetPath is set
20-
# to a non-empty value; we set it via
21-
# workspaceSettings to keep the output
22-
# filename deterministic)
20+
# to a non-empty value; we set it via a
21+
# user-level `settings:` block to keep the
22+
# output filename deterministic — see the
23+
# setup section below for why user-level
24+
# and not workspaceSettings)
2325
# c. Jdtls.exportJar → writes the jar file
2426
#
2527
# Verification strategy

test/e2e-plans/java-dep-project-creation.yaml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,18 @@
3232
#
3333
# Verification strategy
3434
# ─────────────────────
35-
# `templates/invisible-project/` ships exactly three files (plus an empty
36-
# `lib/` ensure-dir):
35+
# `templates/invisible-project/` ships exactly three files:
3736
# - README.md
3837
# - .vscode/settings.json
3938
# - src/App.java
40-
# We assert two of them (the .vscode settings file and App.java) on disk.
41-
# Notably absent: `.classpath` / `.project` — invisible projects rely on
42-
# `java.import.generatesMetadataFilesAtProjectRoot` (off by default in the
43-
# template), so testing for .classpath would yield a false negative.
39+
# In addition, `scaffoldSimpleProject` (projectController.ts:185) creates
40+
# an empty `lib/` directory at runtime via `fse.ensureDir`, so a freshly
41+
# scaffolded project on disk has the three template files plus `lib/`.
42+
# We assert two of the template files (the .vscode settings file and
43+
# App.java) on disk. Notably absent: `.classpath` / `.project` — invisible
44+
# projects rely on `java.import.generatesMetadataFilesAtProjectRoot` (off
45+
# by default in the template), so testing for .classpath would yield a
46+
# false negative.
4447
#
4548
# Usage:
4649
# npx autotest run test/e2e-plans/java-dep-project-creation.yaml --vsix <path-to-vsix>

0 commit comments

Comments
 (0)