fix: context menu click with hover+focused wait, auto-dismiss native dialogs

Root causes found and fixed:
1. Context menu click requires hover first to trigger VS Code's menu
   focus state (.action-item.focused), then click works reliably.
2. redhat.java shows an Electron native dialog (dialog.showMessageBox)
   for refactoring confirmation on file rename. Playwright Page API
   cannot interact with native dialogs. Monkey-patch showMessageBox
   in the Electron main process to auto-return OK.

Verified locally: both rename and delete tests pass.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: wenytang-ms

test/e2e/fixtures/baseTest.ts

@@ -103,6 +103,15 @@ export const test = base.extend<TestFixtures>({
 
         const page = await electronApp.firstWindow();
 
+        // Auto-dismiss Electron native dialogs (e.g. redhat.java refactoring
+        // confirmation "wants to make refactoring changes"). These dialogs are
+        // outside the renderer DOM and cannot be handled via Playwright Page API.
+        // Monkey-patch dialog.showMessageBox in the main process to auto-click OK.
+        await electronApp.evaluate(({ dialog }) => {
+            dialog.showMessageBox = async () => ({ response: 0, checkboxChecked: true });
+            dialog.showMessageBoxSync = () => 0;
+        });
+
         // Dismiss any startup notifications/dialogs before handing off to tests
         await page.waitForTimeout(3_000);
         await dismissAllNotifications(page);

test/e2e/tests/fileOperations.test.ts

@@ -69,20 +69,18 @@ test.describe("File Operations", () => {
         // Expand to AppToRename
         await JavaOperator.expandTreePath(page, "my-app", "src/main/java", "com.mycompany.app");
 
-        // Select AppToRename in the tree and invoke rename via context menu.
-        // The command is hidden from the command palette (when: false)
-        // and keyboard shortcut requires focusedView which is unreliable,
-        // so context menu is the only reliable UI path.
+        // Right-click AppToRename to select it AND open the context menu.
+        // We do NOT left-click first because that opens the file in the editor
+        // and steals focus away from the tree view.
         const appToRename = page.getByRole(VSCode.TREE_ITEM_ROLE, { name: "AppToRename" }).first();
-        await appToRename.click();
-        await page.waitForTimeout(Timeout.CLICK);
-
-        await VscodeOperator.selectContextMenuItem(page, appToRename, "Rename");
+        await VscodeOperator.selectContextMenuItem(page, appToRename, /^Rename/);
 
         // The extension shows a showInputBox (quick-input) for the new name
         await VscodeOperator.fillQuickInput(page, "AppRenamed");
 
-        // Handle confirmation dialog if it appears
+        // Handle extension's own rename confirmation dialog if it appears.
+        // The Electron native refactoring dialog from redhat.java is
+        // auto-dismissed by the showMessageBox monkey-patch in baseTest.ts.
         try {
             await VscodeOperator.clickDialogButton(page, "OK", 5_000);
         } catch {
@@ -98,11 +96,9 @@ test.describe("File Operations", () => {
         await JavaOperator.collapseFileExplorer(page);
         await JavaOperator.expandTreePath(page, "my-app", "src/main/java", "com.mycompany.app");
 
-        // Select AppToDelete and invoke delete via context menu.
+        // Right-click AppToDelete directly (no left-click to avoid opening
+        // the file and losing tree focus).
         const appToDelete = page.getByRole(VSCode.TREE_ITEM_ROLE, { name: "AppToDelete" }).first();
-        await appToDelete.click();
-        await page.waitForTimeout(Timeout.CLICK);
-
         await VscodeOperator.selectContextMenuItem(page, appToDelete, /^Delete/);
 
         // Confirm deletion in dialog

test/e2e/utils/vscodeOperator.ts

@@ -169,24 +169,22 @@ export default class VscodeOperator {
     /**
      * Right-clicks an element and selects an item from the context menu.
      *
-     * VS Code Electron context menus do not respond to Playwright's
-     * `.click()` or `.dispatchEvent()` — the menu stays open. Instead,
-     * we locate the menu item by role and use raw `page.mouse.click()`
-     * with the element's bounding-box coordinates, which sends CDP-level
-     * mouse events that Electron handles correctly.
+     * Scopes the search to `.monaco-menu-container .monaco-menu` to avoid
+     * matching menubar items. Hovers the item first to trigger VS Code's
+     * menu focus, then waits for the `.focused` CSS class before clicking.
      */
-    static async selectContextMenuItem(page: Page, target: ReturnType<Page["locator"]>, menuItemLabel: string | RegExp): Promise<void> {
+    static async selectContextMenuItem(page: Page, target: ReturnType<Page["locator"]>, menuItemName: string | RegExp): Promise<void> {
         await target.click({ button: "right" });
-        const menu = page.locator(".monaco-menu-container");
+        const menu = page.locator(".monaco-menu-container .monaco-menu");
         await menu.waitFor({ state: "visible", timeout: 5_000 });
-        const menuItem = menu.getByRole("menuitem", { name: menuItemLabel });
+        const menuItem = menu.getByRole("menuitem", { name: menuItemName });
         await menuItem.first().waitFor({ state: "visible", timeout: 5_000 });
-        // Use raw mouse click at the centre of the element's bounding box.
-        const box = await menuItem.first().boundingBox();
-        if (!box) {
-            throw new Error(`Could not get bounding box for menu item "${menuItemLabel}"`);
-        }
-        await page.mouse.click(box.x + box.width / 2, box.y + box.height / 2);
+        await menuItem.first().hover();
+        await page.locator(".monaco-menu-container .action-item.focused").waitFor({
+            state: "visible",
+            timeout: 5_000,
+        });
+        await menuItem.first().click();
         await page.waitForTimeout(Timeout.CLICK);
     }
 
@@ -242,6 +240,19 @@ export default class VscodeOperator {
         await page.waitForTimeout(Timeout.CLICK);
     }
 
+    /**
+     * Clicks a button inside a notification toast (e.g. refactoring confirmations
+     * from extensions that use `window.showInformationMessage` with action buttons).
+     */
+    static async clickNotificationButton(page: Page, buttonLabel: string, timeoutMs = 10_000): Promise<void> {
+        const notification = page.locator(".notification-toast");
+        await notification.first().waitFor({ state: "visible", timeout: timeoutMs });
+        const btn = notification.getByRole(VSCode.BUTTON_ROLE, { name: buttonLabel });
+        await btn.first().waitFor({ state: "visible", timeout: timeoutMs });
+        await btn.first().click();
+        await page.waitForTimeout(Timeout.CLICK);
+    }
+
     // -----------------------------------------------------------------------
     //  Editor
     // -----------------------------------------------------------------------