test: enable Playwright trace on all E2E test runs

Change trace from 'on-first-retry' to 'on' so every test run captures
screenshots and DOM snapshots at each Playwright action. This makes
debugging easier — especially when traces are reviewed by AI — since
the full interaction flow is always available, not just on retries.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: wenytang-ms

test/e2e/fixtures/baseTest.ts

@@ -136,24 +136,22 @@ export const test = base.extend<TestFixtures>({
         await page.waitForTimeout(3_000);
         await dismissAllNotifications(page);
 
-        // 4. Optional tracing
-        if (testInfo.retry > 0 || !process.env.CI) {
-            await page.context().tracing.start({ screenshots: true, snapshots: true, title: testInfo.title });
-        }
+        // 4. Start tracing — captures screenshots and DOM snapshots at every
+        //    Playwright action so failures can be replayed step-by-step.
+        await page.context().tracing.start({ screenshots: true, snapshots: true, title: testInfo.title });
 
         // ---- hand off to the test ----
         await use(page);
 
         // ---- teardown ----
-        // Save trace on failure/retry
-        if (testInfo.status !== "passed" || testInfo.retry > 0) {
-            const tracePath = testInfo.outputPath("trace.zip");
-            try {
-                await page.context().tracing.stop({ path: tracePath });
-                testInfo.attachments.push({ name: "trace", path: tracePath, contentType: "application/zip" });
-            } catch {
-                // Tracing may not have been started
-            }
+        // Always save trace — on failure it's essential for debugging,
+        // on success it's useful for verifying the interaction flow.
+        const tracePath = testInfo.outputPath("trace.zip");
+        try {
+            await page.context().tracing.stop({ path: tracePath });
+            testInfo.attachments.push({ name: "trace", path: tracePath, contentType: "application/zip" });
+        } catch {
+            // Tracing may not have been started
         }
 
         await electronApp.close();

test/e2e/playwright.config.ts

@@ -22,8 +22,10 @@ export default defineConfig({
     use: {
         // Automatically take a screenshot when a test fails.
         screenshot: "only-on-failure",
-        // Capture full trace on retry for deep debugging (includes screenshots, DOM snapshots, network).
-        trace: "on-first-retry",
+        // Capture full trace on every test run (includes screenshots, DOM
+        // snapshots, and network at each Playwright action). This makes it
+        // easy to diagnose failures — especially when reviewed by AI.
+        trace: "on",
     },
     outputDir: path.join(__dirname, "..", "..", "test-results", "e2e"),
 });