fix: centralize Java version checks on ProjectNode creation

Author: FluoriteCafe-work

src/promotionProvider.ts

@@ -23,12 +23,10 @@ export class PromotionProvider {
 
     private haveAlreadyPrompted = false;
 
-    public checkJavaVersion(data: INodeData[]) {
-        for (const i of data) {
-            const javaVersion = i.metaData?.MaxSourceVersion;
-            if (javaVersion && javaVersion < EARLIEST_JAVA_VERSION_NOT_TO_PROMPT) {
-                this.triggerJavaVersionUpgrade(javaVersion);
-            }
+    public checkJavaVersion(data: INodeData) {
+        const javaVersion = data.metaData?.MaxSourceVersion;
+        if (javaVersion && javaVersion < EARLIEST_JAVA_VERSION_NOT_TO_PROMPT) {
+            this.triggerJavaVersionUpgrade(javaVersion);
         }
     }
 

src/views/dependencyDataProvider.ts

@@ -200,8 +200,8 @@ export class DependencyDataProvider implements TreeDataProvider<ExplorerNode> {
                     this._rootItems = rootItems;
                 } else {
                     const result: INodeData[] = await Jdtls.getProjects(folders[0].uri.toString());
-                    PromotionProvider.getInstance().checkJavaVersion(result);
                     result.forEach((project) => {
+                        PromotionProvider.getInstance().checkJavaVersion(project);
                         rootItems.push(new ProjectNode(project, undefined));
                     });
                     this._rootItems = rootItems;

src/views/nodeFactory.ts

@@ -17,6 +17,7 @@ import { PackageRootNode } from "./packageRootNode";
 import { ProjectNode } from "./projectNode";
 import { WorkspaceNode } from "./workspaceNode";
 import { HierarchicalPackageNodeData } from "../java/hierarchicalPackageNodeData";
+import { PromotionProvider } from "../promotionProvider";
 
 export class NodeFactory {
     /**
@@ -33,6 +34,7 @@ export class NodeFactory {
                 case NodeKind.Workspace:
                     return new WorkspaceNode(nodeData, parent);
                 case NodeKind.Project:
+                    PromotionProvider.getInstance().checkJavaVersion(nodeData);
                     return new ProjectNode(nodeData, parent);
                 case NodeKind.Container:
                     if (!parent || !project) {