perf: improve Java LSP tool result handoff by wenytang-ms · Pull Request #1031 · microsoft/vscode-java-dependency

wenytang-ms · 2026-06-09T06:23:36Z

Summary

This draft updates the Java LSP Copilot tool contract so successful symbol and file-outline results are easier to consume by downstream tools, especially VS Code Copilot's built-in read_file.

Recent telemetry analysis showed that raw findSymbol -> findSymbol is not a reliable problem metric by itself because most adjacent pairs are likely same-round/batch tool calls. The PR therefore avoids prescriptive next-step hints and focuses on factual, read-file-compatible result fields.

Changes

lsp_java_findSymbol now returns structured location fields plus a direct read_file adapter:
- file
- startLine
- endLine
- range
- readFileInput: { filePath, offset, limit }
Removed the ambiguous location: path:line field from findSymbol; file is the canonical handoff field for lsp_java_getFileStructure.
lsp_java_getFileStructure now returns a top-level file and per-symbol read ranges:
- startLine
- endLine
- range
- readFileRange: { offset, limit }
Added limit to lsp_java_getFileStructure to control payload size:
- default: 20
- max: 60
- returns truncated: true when capped
Improved multi-root relative path handling when asRelativePath includes the workspace folder name.
Updated LM tool metadata, skill docs, and Java chat instructions to describe the structured handoff.

Expected experiment signal

This PR is not expected to eliminate all findSymbol -> findSymbol transitions. Same-round/batch symbol lookups can still be valid.

Expected improvements:

Higher findSymbol -> readFile when source is needed.
Higher findSymbol -> readFile/getFileStructure within the next few tool calls.
Lower delayed findSymbol -> findSymbol repeat rate, especially pairs with delta > 1s or delta > 5s.
Lower generic search fallback after successful small findSymbol results.
Smaller getFileStructure payloads while preserving getFileStructure -> readFile consumption.

Metrics that should not be treated as primary success criteria:

Raw immediate findSymbol -> findSymbol, because it is inflated by batch/parallel tool calls.
Forcing findSymbol to always be followed by read_file; lsp_java_getFileStructure, additional symbol lookup, or generic search can still be valid depending on the task.

Intentional non-goals

No nextStep field in tool results; next-tool selection remains with the model.
No outlineInput; file is the single path handoff field.
No speculative path:line parsing in lsp_java_getFileStructure; findSymbol no longer returns a path:line field that would encourage this misuse.

Validation

npm run compile
npm run tslint
npm test currently fails in existing Library Controller tests because toReferencedLibraryPath / toReferencedLibraryExcludePath are not exported from extension_bundle_1; unrelated to this LSP tool change.

Return structured file and line fields from findSymbol so the model can consume precise ranges without repeating symbol search. Accept line-suffixed Java locations in file structure resolution and document outlineInput handoff. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR improves the Java LSP Copilot tools’ result “handoff” so downstream steps (e.g., read_file / lsp_java_getFileStructure) can consume lsp_java_findSymbol output more directly, and so file resolution is more tolerant of Java-style path:line inputs and multi-root workspaces.

Changes:

Enhanced lsp_java_findSymbol payload with file, startLine, endLine, and outlineInput, and added a nextStep hint to reduce unnecessary repeat tool calls.
Made file URI resolution tolerate Java location suffixes (e.g., src/Foo.java:42) and improved multi-root relative-path handling when the workspace folder name is included.
Updated skill docs, instrument instructions, and tool metadata to prefer outlineInput/file handoff patterns.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/copilot/tools/javaContextTools.ts	Adds Java `path:line` tolerance, improves multi-root relative resolution, and enriches `findSymbol` results with additional fields and guidance.
resources/skills/java-lsp-tools/SKILL.md	Documents the updated `findSymbol` output fields and the preferred handoff flow using `outlineInput`/`file`.
resources/instruments/javaLspContext.instructions.md	Updates Java chat instructions to prefer `read_file` with `file`/`range` and `getFileStructure` with `outlineInput`.
package.json	Updates tool metadata/schema descriptions to reflect new fields and tolerated `path:line` inputs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Use normalized relative paths consistently when resolving file structure inputs and classify truncated findSymbol responses before small exact-result guidance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Keep the PR focused on the evidence-backed findSymbol handoff contract. Do not claim getFileStructure accepts path:line inputs without telemetry proving that case. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Keep findSymbol results as structured location data and leave next-tool choice to the model. The payload still exposes file, line, range, and outlineInput for downstream consumption without embedding result-level routing guidance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove the redundant outlineInput field and keep findSymbol output focused on factual location data: file, startLine, endLine, and range. getFileStructure can consume the returned file when broader file outline context is needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/copilot/tools/javaContextTools.ts:344

The PR description says lsp_java_findSymbol will add an outlineInput field and a top-level nextStep hint, but the tool output here only includes file/startLine/endLine/readFileInput and returns { results, total }. If those fields are required for handoff, they should be included in the actual payload.

            const results = symbols.slice(0, limit).map(s => {
                const file = vscode.workspace.asRelativePath(s.location.uri);
                const { startLine, endLine } = toInclusiveLineRange(s.location.range);
                return {
                    name: s.name,
                    kind: vscode.SymbolKind[s.kind],
                    container: s.containerName || undefined,
                    file,
                    startLine,
                    endLine,
                    readFileInput: toReadFileInput(file, startLine, endLine),
                    location: `${file}:${startLine}`,
                    range: `L${startLine}-${endLine}`,
                };
            });
            resultCount = results.length;
            const findSymbolPayload = { results, total: symbols.length };
            responseCharCount = getResponseCharCount(findSymbolPayload);
            return toResult(findSymbolPayload);

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

modelDescription is sent to the model on every request, so condense both tool descriptions and the uri param description while keeping the read_file (offset/limit) handoff and no-re-search guidance intact. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

…ol name - Use nullish coalescing + Math.floor for getFileStructure limit so an explicit 0 and fractional values are handled correctly. - Use the full lsp_java_findSymbol tool name in the Java LSP instructions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

wenytang-ms changed the title ~~Improve Java LSP tool result handoff~~ perf: improve Java LSP tool result handoff Jun 9, 2026

wenytang-ms requested a review from Copilot June 9, 2026 07:59

Copilot started reviewing on behalf of wenytang-ms June 9, 2026 07:59 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread src/copilot/tools/javaContextTools.ts

Comment thread src/copilot/tools/javaContextTools.ts Outdated

Address Java LSP handoff review comments

e5f1e9d

Use normalized relative paths consistently when resolving file structure inputs and classify truncated findSymbol responses before small exact-result guidance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

wenytang-ms marked this pull request as ready for review June 10, 2026 04:47

wenytang-ms requested review from chagong and testforstephen as code owners June 10, 2026 04:47

wenytang-ms and others added 5 commits June 10, 2026 13:59

Remove speculative Java location suffix handling

6222334

Keep the PR focused on the evidence-backed findSymbol handoff contract. Do not claim getFileStructure accepts path:line inputs without telemetry proving that case. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Return read_file input from Java symbol lookup

4d7d167

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge branch 'main' into experiment/lsp-tool-contract-tuning

fe1b167

wenytang-ms requested a review from Copilot June 10, 2026 08:31

Copilot started reviewing on behalf of wenytang-ms June 10, 2026 08:31 View session

Copilot AI reviewed Jun 10, 2026

View reviewed changes

Comment thread src/copilot/tools/javaContextTools.ts

Comment thread resources/skills/java-lsp-tools/SKILL.md Outdated

wenytang-ms and others added 5 commits June 10, 2026 16:47

Add read ranges to Java file structure

a690020

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Tighten Java file structure limit

285b780

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove ambiguous Java symbol location field

467198e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge branch 'main' into experiment/lsp-tool-contract-tuning

35f41d8

wenytang-ms requested a review from Copilot June 11, 2026 05:15

Copilot started reviewing on behalf of wenytang-ms June 11, 2026 05:16 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Comment thread src/copilot/tools/javaContextTools.ts Outdated

Comment thread resources/instruments/javaLspContext.instructions.md Outdated

chagong approved these changes Jun 11, 2026

View reviewed changes

wenytang-ms merged commit 395d5cc into main Jun 11, 2026
33 checks passed

wenytang-ms deleted the experiment/lsp-tool-contract-tuning branch June 11, 2026 05:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: improve Java LSP tool result handoff#1031

perf: improve Java LSP tool result handoff#1031
wenytang-ms merged 13 commits into
mainfrom
experiment/lsp-tool-contract-tuning

wenytang-ms commented Jun 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

wenytang-ms commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Expected experiment signal

Intentional non-goals

Validation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wenytang-ms commented Jun 9, 2026 •

edited

Loading