Skip to content

Update wording for Java 21 #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FluoriteCafe-work merged 4 commits into from
Nov 7, 2025
Merged

Update wording for Java 21 #930

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
972e13f
chore: update wording on Java 21
FluoriteCafe-work Nov 7, 2025
8cde963
chore: typo
FluoriteCafe-work Nov 7, 2025
b10edc5
chore: bump to 0.26.4
FluoriteCafe-work Nov 7, 2025
419c8ce
docs: update changelog
FluoriteCafe-work Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "vscode-java-dependency",
"displayName": "Project Manager for Java",
"description": "%description%",
"version": "0.26.3",
"version": "0.26.4",
"publisher": "vscjava",
"preview": false,
"aiKey": "5c642b22-e845-4400-badb-3f8509a70777",
Expand Down
8 changes: 4 additions & 4 deletions src/upgrade/dependency.metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
import { Upgrade } from "../constants";
import { UpgradeReason, type DependencyCheckMetadata } from "./type";

const LATEST_JAVA_LTS_VESRION = 21;
const MATURE_JAVA_LTS_VERSION = 21;

export const DEPENDENCY_JAVA_RUNTIME = {
"name": "Java Runtime",
"reason": UpgradeReason.JRE_TOO_OLD,
"supportedVersion": `>=${LATEST_JAVA_LTS_VESRION}`,
"supportedVersion": `>=${MATURE_JAVA_LTS_VERSION}`,
"suggestedVersion": {
"name": `Java ${LATEST_JAVA_LTS_VESRION}`,
"description": "latest LTS version",
"name": `Java ${MATURE_JAVA_LTS_VERSION}`,
"description": "LTS version",
},
} as const;

Expand Down
4 changes: 2 additions & 2 deletions src/upgrade/utility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export function buildNotificationMessage(issue: UpgradeIssue, hasExtension: bool
const upgradeWord = hasExtension ? "upgrade" : `install ${ExtensionName.APP_MODERNIZATION_EXTENSION_NAME} extension and upgrade`;

if (packageId === Upgrade.PACKAGE_ID_FOR_JAVA_RUNTIME) {
return `This project is using an older Java runtime (${currentVersion}). Would you like to ${upgradeWord} it to ${suggestedVersionName} (latest LTS)?`;
return `This project is using an older Java runtime (${currentVersion}). Would you like to ${upgradeWord} it to ${suggestedVersionName} (LTS)?`;
}

switch (reason) {
Expand All @@ -57,7 +57,7 @@ export function buildFixPrompt(issue: UpgradeIssue): string {
switch (reason) {
case UpgradeReason.JRE_TOO_OLD: {
const { suggestedVersion: { name: suggestedVersionName } } = issue;
return `upgrade java runtime to the latest LTS version ${suggestedVersionName} using java upgrade tools`;
return `upgrade java runtime to the LTS version ${suggestedVersionName} using java upgrade tools`;
}
case UpgradeReason.END_OF_LIFE:
case UpgradeReason.DEPRECATED: {
Expand Down
Loading