Skip to content

Commit 316f0f5

Browse files
committed
fix: add fallback for --design-unit CSS variable
@vscode-elements/elements does not define --design-unit (was provided by @vscode/webview-ui-toolkit). Add fallback value of 4 so spacing utilities (mr-*, ml-*, pt-*, etc.) resolve correctly.
1 parent 2ba72b4 commit 316f0f5

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

src/project-settings/assets/classpath/style.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
}
5252

5353
&[open][position='above'] #add-new-jdk {
54-
margin: calc(var(--design-unit) * 1px) 0;
54+
margin: calc(var(--design-unit, 4) * 1px) 0;
5555
}
5656

5757
p {
@@ -66,7 +66,7 @@
6666
display: flex;
6767
align-items: flex-end;
6868
.codicon {
69-
margin-right: calc(var(--design-unit) * 1px);
69+
margin-right: calc(var(--design-unit, 4) * 1px);
7070
}
7171
}
7272
}
@@ -87,7 +87,7 @@
8787
align-items: center;
8888
}
8989
.setting-section-grid-cell-left {
90-
padding-right: calc(var(--design-unit) * 4px);
90+
padding-right: calc(var(--design-unit, 4) * 4px);
9191
}
9292
.setting-section-grid-cell-readonly {
9393
justify-content: space-between;
@@ -119,7 +119,7 @@
119119
}
120120

121121
.setting-list-actions {
122-
height: calc(var(--design-unit) * 8px);
122+
height: calc(var(--design-unit, 4) * 8px);
123123
}
124124

125125
// Ghost/icon button style (transparent background, like old appearance="icon")

src/project-settings/assets/utils.scss

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,36 @@
11
@for $i from 0 through 12 {
22
.pl-#{$i} {
3-
padding-left: calc(var(--design-unit) * #{$i}px);
3+
padding-left: calc(var(--design-unit, 4) * #{$i}px);
44
}
55

66
.pr-#{$i} {
7-
padding-right: calc(var(--design-unit) * #{$i}px);
7+
padding-right: calc(var(--design-unit, 4) * #{$i}px);
88
}
99

1010
.pt-#{$i} {
11-
padding-top: calc(var(--design-unit) * #{$i}px);
11+
padding-top: calc(var(--design-unit, 4) * #{$i}px);
1212
}
1313

1414
.pb-#{$i} {
15-
padding-bottom: calc(var(--design-unit) * #{$i}px);
15+
padding-bottom: calc(var(--design-unit, 4) * #{$i}px);
1616
}
1717
}
1818

1919
@for $i from 0 through 12 {
2020
.ml-#{$i} {
21-
margin-left: calc(var(--design-unit) * #{$i}px);
21+
margin-left: calc(var(--design-unit, 4) * #{$i}px);
2222
}
2323

2424
.mr-#{$i} {
25-
margin-right: calc(var(--design-unit) * #{$i}px);
25+
margin-right: calc(var(--design-unit, 4) * #{$i}px);
2626
}
2727

2828
.mt-#{$i} {
29-
margin-top: calc(var(--design-unit) * #{$i}px);
29+
margin-top: calc(var(--design-unit, 4) * #{$i}px);
3030
}
3131

3232
.mb-#{$i} {
33-
margin-bottom: calc(var(--design-unit) * #{$i}px);
33+
margin-bottom: calc(var(--design-unit, 4) * #{$i}px);
3434
}
3535
}
3636

0 commit comments

Comments
 (0)