Skip to content

Commit d9843d7

Browse files
wenytang-msCopilot
andcommitted
test: fix close-all-editors palette label
The previous label 'Workbench: Close All Editors' does not exist in VS Code's command palette - the actual visible label is 'View: Close All Editors'. The palette fuzzy match silently produced no result, so Enter dismissed the palette and the test step 'passed' in ~830ms without actually closing the webview. Subsequent verifyWebview assertions still passed because getWebviewText concatenates innerText from all iframe.webview frames, so prior webview content leaked into later checks. Use the exact palette label so the editor area is genuinely cleared between webviews, confirmed by inspecting *_after.png screenshots. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 7a969d9 commit d9843d7

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

test-plans/java-webview-migration.yaml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ steps:
8484
timeout: 30
8585

8686
- id: "close-help-center"
87-
action: "run command Workbench: Close All Editors"
87+
action: "run command View: Close All Editors"
8888

8989
# ══════════════════════════════════════════════════════════════════════
9090
# 2. Tips for Beginners (java.gettingStarted)
@@ -109,7 +109,7 @@ steps:
109109
timeout: 30
110110

111111
- id: "close-beginner-tips"
112-
action: "run command Workbench: Close All Editors"
112+
action: "run command View: Close All Editors"
113113

114114
# ══════════════════════════════════════════════════════════════════════
115115
# 3. Install New JDK (java.installJdk)
@@ -133,7 +133,7 @@ steps:
133133
timeout: 30
134134

135135
- id: "close-install-jdk"
136-
action: "run command Workbench: Close All Editors"
136+
action: "run command View: Close All Editors"
137137

138138
# ══════════════════════════════════════════════════════════════════════
139139
# 4. Configure Java Runtime (java.runtime)
@@ -159,7 +159,7 @@ steps:
159159
timeout: 30
160160

161161
- id: "close-java-runtime"
162-
action: "run command Workbench: Close All Editors"
162+
action: "run command View: Close All Editors"
163163

164164
# ══════════════════════════════════════════════════════════════════════
165165
# 5. Project Settings (java.projectSettings)
@@ -186,7 +186,7 @@ steps:
186186
timeout: 30
187187

188188
- id: "close-project-settings"
189-
action: "run command Workbench: Close All Editors"
189+
action: "run command View: Close All Editors"
190190

191191
# ══════════════════════════════════════════════════════════════════════
192192
# 6. Configure Classpath (java.classpathConfiguration)
@@ -210,7 +210,7 @@ steps:
210210
timeout: 30
211211

212212
- id: "close-classpath-config"
213-
action: "run command Workbench: Close All Editors"
213+
action: "run command View: Close All Editors"
214214

215215
# ══════════════════════════════════════════════════════════════════════
216216
# 7. Formatter Settings (java.formatterSettings)
@@ -238,7 +238,7 @@ steps:
238238
contains: "CodeFormatterProfile"
239239

240240
- id: "close-profile-file-before-formatter"
241-
action: "run command Workbench: Close All Editors"
241+
action: "run command View: Close All Editors"
242242

243243
- id: "open-formatter-settings"
244244
action: "run command Java: Open Java Formatter Settings with Preview"
@@ -260,7 +260,7 @@ steps:
260260
timeout: 45
261261

262262
- id: "close-formatter-settings"
263-
action: "run command Workbench: Close All Editors"
263+
action: "run command View: Close All Editors"
264264

265265
# ══════════════════════════════════════════════════════════════════════
266266
# 8. Overview (java.overview)
@@ -283,4 +283,4 @@ steps:
283283
timeout: 30
284284

285285
- id: "close-overview"
286-
action: "run command Workbench: Close All Editors"
286+
action: "run command View: Close All Editors"

0 commit comments

Comments
 (0)