Updated Content Security Policy to be more strict#306
Closed
zzeebbii wants to merge 1 commit into
Closed
Conversation
- No script, image or styles are being loaded right now, so it can be set to none. Later it can be updated if required.
|
|
Member
|
@jdneo please help take a look. |
jdneo
requested changes
Feb 16, 2020
jdneo
left a comment
jdneo
left a comment
Member
There was a problem hiding this comment.
I'm afraid this won't work. If you open the Getting Started page, you will get an warning like following:
[Embedded Page] Refused to execute inline script because it violates the following Content Security Policy directive: "default-src 'none'". Either the 'unsafe-inline' keyword, a hash ('sha256-JFinOq+GM9ozZBqjltSr0PP7/fN3NmpyjSvRGddk43k='), or a nonce ('nonce-...') is required to enable inline execution. Note also that 'script-src' was not explicitly set, so 'default-src' is used as a fallback.
Maybe a better way to fix this issue is to use the nonce mechanism: https://github.com/microsoft/vscode-extension-samples/blob/master/webview-sample/src/extension.ts#L194-L207
Author
|
I will continue working on this one. |
Contributor
|
clean out-of-date PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #171. As no resources are being used by the extension right now, so default source can be none. Later if the extension needs some image, script or style then the policy can be updated.