Skip to content

Commit 87dc281

Browse files
authored
chore: update tas-client for proper disposal (#2332)
* chore: update tas-client for proper disposal Closes microsoft/tas-client#74 * bump
1 parent b53b28c commit 87dc281

3 files changed

Lines changed: 22 additions & 20 deletions

File tree

package-lock.json

Lines changed: 20 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080
"signale": "^1.4.0",
8181
"source-map-support": "^0.5.21",
8282
"to-absolute-glob": "^3.0.0",
83-
"vscode-tas-client": "^0.1.84",
83+
"vscode-tas-client": "^0.1.86",
8484
"ws": "^8.17.1"
8585
},
8686
"devDependencies": {

src/telemetry/vscodeExperimentationService.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,7 @@ export class VSCodeExperimentationService implements IJsDebugExpService, IDispos
5252
}
5353

5454
dispose(): void {
55-
// See microsoft/tas-client#74
56-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
57-
const polling = (this.service as any)?.pollingService;
58-
polling?.StopPolling();
55+
this.service?.dispose();
5956
}
6057

6158
/**

0 commit comments

Comments
 (0)