Skip to content

2019-09: vocabulary gating not applied to completion/hover/document symbols #330

Description

@aeschli

Found while reviewing #308 (JSON Schema 2019-09 support).

Problem

JSONDocument.getMatchingSchemas gained an activeVocabularies parameter, but the callers do not pass it:

  • src/services/jsonCompletion.ts (doc.getMatchingSchemas(schema.schema, node.offset))
  • src/services/jsonHover.ts
  • src/services/jsonDocumentSymbols.ts

As a result, completion and hover ignore vocabulary-disabled keywords, which is inconsistent with validation (which does thread schema.activeVocabularies).

Suggested direction

Thread resolvedSchema.activeVocabularies through the completion/hover/document-symbol code paths.

Severity

Medium — inconsistent behavior between validation and IntelliSense.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions