Skip to content

Add regression coverage for dependencies in schemas without $schema #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+14 −0
Draft

Add regression coverage for dependencies in schemas without $schema #334

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b720f17
Initial plan
Copilot Jul 6, 2026
77c9c3b
Add regression coverage for undeclared dependencies schemas
Copilot Jul 6, 2026
1656857
Clarify inferred-draft dependencies regression coverage
Copilot Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/test/parser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ suite('JSON Parser', () => {
return jsonDoc.validate(textDoc, schema, undefined, draft);
}

function validateWithInferredDraft(jsonDoc: JSONDocument, textDoc: TextDocument, schema: JSONSchema) {
return jsonDoc.validate(textDoc, schema);
}

function assertObject(node: ASTNode, expectedProperties: string[]) {
assert.equal(node.type, 'object');
assert.equal((<ObjectASTNode>node).properties.length, expectedProperties.length);
Expand Down Expand Up @@ -2219,6 +2223,11 @@ suite('JSON Parser', () => {
const semanticErrors = validate2(jsonDoc, textDoc, schema);
assert.strictEqual(semanticErrors!.length, 1);
}
{
const { textDoc, jsonDoc } = toDocument('{"a":true}');
const semanticErrors = validateWithInferredDraft(jsonDoc, textDoc, schema);
assert.strictEqual(semanticErrors!.length, 1);
}
schema = {
"type": "object",

Expand Down Expand Up @@ -2299,6 +2308,11 @@ suite('JSON Parser', () => {
const semanticErrors = validate2(jsonDoc, textDoc, schema);
assert.strictEqual(semanticErrors!.length, 1);
}
{
const { textDoc, jsonDoc } = toDocument('{"a":true, "b": "string"}');
const semanticErrors = validateWithInferredDraft(jsonDoc, textDoc, schema);
assert.strictEqual(semanticErrors!.length, 1);
}
schema = {
"type": "object",

Expand Down