feat: adds support for schema store#342
Open
baywet wants to merge 4 commits into
Open
Conversation
…hema for the file Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c5e9b306-5d8c-4cc8-ac55-1b1175cfcedf
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c5e9b306-5d8c-4cc8-ac55-1b1175cfcedf
Collaborator
|
Schema store loading and management should not be part of the JSON language service.
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c5e9b306-5d8c-4cc8-ac55-1b1175cfcedf
Member
Author
|
@aeschli thanks for the feedback. I've moved the code that resolves the catalog, etc... to the extension itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pull request adds support for json schema store so schemas are suggested automatically based on https://www.schemastore.org/ when no $schema is present