Skip to content

Commit c2238dc

Browse files
committed
Avoid relativizing paths in the project outline
In the project outline view, paths for the Makefile and build log were automatically made relative. If the setting was an absolute path, the result would be ugly: For a makeDirectory setting '/tmp/amhello-debug', the outline would print Makefile: [../../../tmp/amhello-debug/Makefile] This was not only unsightly, but also wrong. See https://unix.stackexchange.com/questions/13858/do-the-parent-directorys-permissions-matter-when-accessing-a-subdirectory In short, if one of the parent directories (..) would be inaccessible, the ../../../tmp/amhello-debug path is wrong because it's inaccessible, even though /tmp/amhello-debug is accessible.
1 parent 5a47164 commit c2238dc

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/tree.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,9 +321,9 @@ export class ProjectOutlineProvider implements vscode.TreeDataProvider<BaseNode>
321321
this._currentConfigurationItem.update(configuration || this._unsetString);
322322
this._currentBuildTargetItem.update(buildTarget || this._unsetString);
323323
await this._currentLaunchTargetItem.update(launchTarget || this._unsetString);
324-
this._currentMakefilePathInfoItem.update(makefilePathInfo || this._unsetString, this.pathDisplayed(makefilePathInfo, "Makefile", false, true));
324+
this._currentMakefilePathInfoItem.update(makefilePathInfo || this._unsetString, this.pathDisplayed(makefilePathInfo, "Makefile", false, false));
325325
this._currentMakePathInfoItem.update(makePathInfo || this._unsetString, this.pathDisplayed(makePathInfo, "Make", true, false));
326-
this._currentBuildLogPathInfoItem.update(buildLogInfo || this._unsetString, this.pathDisplayed(buildLogInfo, "Build Log", false, true));
326+
this._currentBuildLogPathInfoItem.update(buildLogInfo || this._unsetString, this.pathDisplayed(buildLogInfo, "Build Log", false, false));
327327

328328
this.updateTree();
329329
}

0 commit comments

Comments
 (0)