Exclude pending reviews from "Show Changes Since Last Review" (#8264)

* Initial plan

* Initial plan for fixing Show Changes Since Last Review

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Modify GraphQL query to exclude pending reviews from last review

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Fix test builder for array handling

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Use 'last: 1' to get the most recent review instead of 'first: 1'

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Revert API proposal changes that were unintentionally included

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

Author: Copilot

src/github/graphql.ts

@@ -322,10 +322,12 @@ export interface LatestUpdatesResponse {
 export interface LatestReviewCommitResponse {
 	repository: {
 		pullRequest: {
-			viewerLatestReview: {
-				commit: {
-					oid: string;
-				}
+			reviews: {
+				nodes: {
+					commit: {
+						oid: string;
+					}
+				}[];
 			};
 		};
 	} | null;

src/github/pullRequestModel.ts

@@ -599,6 +599,7 @@ export class PullRequestModel extends IssueModel<PullRequest> implements IPullRe
 	async getViewerLatestReviewCommit(): Promise<{ sha: string } | undefined> {
 		Logger.debug(`Fetch viewers latest review commit`, IssueModel.ID);
 		const { query, remote, schema } = await this.githubRepository.ensure();
+		const currentUser = (await this.githubRepository.getAuthenticatedUser()).login;
 
 		try {
 			const { data } = await query<LatestReviewCommitResponse>({
@@ -607,15 +608,17 @@ export class PullRequestModel extends IssueModel<PullRequest> implements IPullRe
 					owner: remote.owner,
 					name: remote.repositoryName,
 					number: this.number,
+					author: currentUser,
 				},
 			});
 
 			if (data.repository === null) {
 				Logger.error('Unexpected null repository while getting last review commit', PullRequestModel.ID);
 			}
 
-			return data.repository?.pullRequest.viewerLatestReview ? {
-				sha: data.repository?.pullRequest.viewerLatestReview.commit.oid,
+			const latestReview = data.repository?.pullRequest.reviews.nodes[0];
+			return latestReview ? {
+				sha: latestReview.commit.oid,
 			} : undefined;
 		}
 		catch (e) {

src/github/queriesShared.gql

@@ -342,12 +342,14 @@ query IssueTimelineEvents($owner: String!, $name: String!, $number: Int!, $last:
 	}
 }
 
-query LatestReviewCommit($owner: String!, $name: String!, $number: Int!) {
+query LatestReviewCommit($owner: String!, $name: String!, $number: Int!, $author: String!) {
 	repository(owner: $owner, name: $name) {
 		pullRequest(number: $number) {
-			viewerLatestReview {
-				commit {
-					oid
+			reviews(last: 1, author: $author, states: [APPROVED, CHANGES_REQUESTED, COMMENTED, DISMISSED]) {
+				nodes {
+					commit {
+						oid
+					}
 				}
 			}
 		}

src/test/builders/graphql/latestReviewCommitBuilder.ts

@@ -10,16 +10,13 @@ import { RateLimitBuilder } from './rateLimitBuilder';
 
 type Repository = NonNullable<LatestReviewCommitResponse['repository']>;
 type PullRequest = Repository['pullRequest'];
-type ViewerLatestReview = PullRequest['viewerLatestReview'];
-type Commit = ViewerLatestReview['commit'];
+type Reviews = PullRequest['reviews'];
 
 export const LatestReviewCommitBuilder = createBuilderClass<LatestReviewCommitResponse>()({
 	repository: createLink<Repository>()({
 		pullRequest: createLink<PullRequest>()({
-			viewerLatestReview: createLink<ViewerLatestReview>()({
-				commit: createLink<Commit>()({
-					oid: { default: 'abc' },
-				}),
+			reviews: createLink<Reviews>()({
+				nodes: { default: [] },
 			}),
 		}),
 	}),