remove core github functionality (#1817)

Author: joaomoreno

package.json

@@ -15,7 +15,7 @@
   "version": "0.16.0",
   "publisher": "GitHub",
   "engines": {
-    "vscode": "^1.45.0"
+    "vscode": "^1.46.0"
   },
   "categories": [
     "Other"
@@ -701,10 +701,6 @@
       {
         "command": "issue.userCompletion",
         "title": "User Completion Chosen"
-      },
-      {
-        "command": "github.publish",
-        "title": "Publish to GitHub"
       }
     ],
     "keybindings": [
@@ -1164,14 +1160,7 @@
           "when": "commentController =~ /^(browse|review)/"
         }
       ]
-    },
-    "viewsWelcome": [
-      {
-        "view": "scm",
-        "contents": "You can also directly publish this folder to a GitHub repository.\n[$(github) Publish to GitHub](command:github.publish)",
-        "when": "config.git.enabled && !git.missing && workbenchState == folder"
-      }
-    ]
+    }
   },
   "scripts": {
     "vscode:prepublish": "webpack --env.production",

src/commands.ts

@@ -28,8 +28,7 @@ import { PullRequestModel } from './github/pullRequestModel';
 import { resolveCommentHandler, CommentReply } from './commentHandlerResolver';
 import { ITelemetry } from './common/telemetry';
 import { TreeNode } from './view/treeNodes/treeNode';
-import { CredentialStore, GitHub } from './github/credentials';
-import { GitAPI } from './typings/git';
+import { CredentialStore } from './github/credentials';
 
 const _onDidUpdatePR = new vscode.EventEmitter<PullRequest | void>();
 export const onDidUpdatePR: vscode.Event<PullRequest | void> = _onDidUpdatePR.event;
@@ -552,131 +551,3 @@ export function registerCommands(context: vscode.ExtensionContext, prManager: Pu
 		}
 	}));
 }
-
-function sanitizeRepositoryName(value: string): string {
-	return value.trim().replace(/[^a-z0-9_.]/ig, '-');
-}
-
-export function registerGlobalCommands(context: vscode.ExtensionContext, gitAPI: GitAPI, credentialStore: CredentialStore) {
-	async function getHub(): Promise<GitHub | undefined> {
-		if (await credentialStore.hasOctokit()) {
-			return await credentialStore.getHub()!;
-		} else {
-			return await credentialStore.login();
-		}
-	}
-
-	async function publish(): Promise<void> {
-		if (!vscode.workspace.workspaceFolders?.length) {
-			return;
-		}
-
-		const folder = vscode.workspace.workspaceFolders[0]; // TODO
-		const hub = await getHub();
-
-		if (!hub) {
-			return;
-		}
-
-		const owner = hub.octokit.currentUser!.login;
-
-		const quickpick = vscode.window.createQuickPick<vscode.QuickPickItem & { repo?: string, auth?: 'https' | 'ssh' }>();
-		quickpick.ignoreFocusOut = true;
-
-		quickpick.placeholder = 'Repository Name';
-		quickpick.show();
-
-		let repo: string | undefined;
-
-		const onDidChangeValue = async () => {
-			const sanitizedRepo = sanitizeRepositoryName(quickpick.value);
-
-			if (!sanitizedRepo) {
-				quickpick.items = [];
-			} else {
-				quickpick.items = [{ label: `$(repo) Create private repository`, description: `$(github) ${owner}/${sanitizedRepo}`, alwaysShow: true, repo: sanitizedRepo }];
-			}
-		};
-
-		quickpick.value = folder.name;
-		onDidChangeValue();
-
-		while (true) {
-			const listener = quickpick.onDidChangeValue(onDidChangeValue);
-			const pick = await getPick(quickpick);
-			listener.dispose();
-
-			repo = pick?.repo;
-
-			if (repo) {
-				try {
-					quickpick.busy = true;
-					await hub.octokit.repos.get({ owner, repo: repo });
-					quickpick.items = [{ label: `$(error) Repository already exists`, description: `$(github) ${owner}/${repo}`, alwaysShow: true }];
-				} catch {
-					break;
-				} finally {
-					quickpick.busy = false;
-				}
-			}
-		}
-
-		quickpick.dispose();
-
-		if (!repo) {
-			return;
-		}
-
-		const githubRepository = await vscode.window.withProgress({ location: vscode.ProgressLocation.Notification, cancellable: false, title: 'Publish to GitHub' }, async progress => {
-			progress.report({ message: 'Creating private repository in GitHub', increment: 25 });
-
-			const res = await hub.octokit.repos.createForAuthenticatedUser({
-				name: repo!,
-				private: true
-			});
-
-			const createdGithubRepository = res.data;
-
-			progress.report({ message: 'Creating first commit', increment: 25 });
-			const repository = await gitAPI.init(folder.uri);
-
-			if (!repository) {
-				return;
-			}
-
-			await repository.commit('first commit', { all: true });
-
-			progress.report({ message: 'Uploading files', increment: 25 });
-			await repository.addRemote('origin', createdGithubRepository.clone_url);
-			await repository.push('origin', 'master', true);
-
-			return createdGithubRepository;
-		});
-
-		if (!githubRepository) {
-			return;
-		}
-
-		const openInGitHub = 'Open In GitHub';
-		const action = await vscode.window.showInformationMessage(`Successfully published the '${owner}/${repo}' repository on GitHub.`, openInGitHub);
-
-		if (action === openInGitHub) {
-			vscode.commands.executeCommand('vscode.open', vscode.Uri.parse(githubRepository.html_url));
-		}
-	}
-
-	context.subscriptions.push(vscode.commands.registerCommand('github.publish', async () => {
-		try {
-			publish();
-		} catch (err) {
-			vscode.window.showErrorMessage(err.message);
-		}
-	}));
-}
-
-function getPick<T extends vscode.QuickPickItem>(quickpick: vscode.QuickPick<T>): Promise<T | undefined> {
-	return Promise.race<T | undefined>([
-		new Promise<T>(c => quickpick.onDidAccept(() => quickpick.selectedItems.length > 0 && c(quickpick.selectedItems[0]))),
-		new Promise<undefined>(c => quickpick.onDidHide(() => c(undefined)))
-	]);
-}

src/extension.ts

@@ -8,7 +8,7 @@ import * as vscode from 'vscode';
 import TelemetryReporter from 'vscode-extension-telemetry';
 import { Repository } from './api/api';
 import { ApiImpl } from './api/api1';
-import { registerCommands, registerGlobalCommands } from './commands';
+import { registerCommands } from './commands';
 import Logger from './common/logger';
 import { Resource } from './common/resources';
 import { handler as uriHandler } from './common/uri';
@@ -22,7 +22,6 @@ import { PullRequestsTreeDataProvider } from './view/prsTreeDataProvider';
 import { ReviewManager } from './view/reviewManager';
 import { IssueFeatureRegistrar } from './issues/issueFeatureRegistrar';
 import { CredentialStore } from './github/credentials';
-import { GithubRemoteSourceProvider } from './gitExtensionIntegration';
 import { GitExtension, GitAPI } from './typings/git';
 import { GitHubContactServiceProvider } from './gitProviders/GitHubContactServiceProvider';
 import { LiveShare } from 'vsls/vscode.js';
@@ -116,19 +115,12 @@ export async function activate(context: vscode.ExtensionContext): Promise<ApiImp
 	const gitExtension = vscode.extensions.getExtension<GitExtension>('vscode.git')!.exports;
 	const gitAPI = gitExtension.getAPI(1);
 
-	// let's not break compatibility
-	if (gitAPI.registerRemoteSourceProvider) {
-		const remoteSourceProvider = new GithubRemoteSourceProvider(credentialStore);
-		context.subscriptions.push(gitAPI.registerRemoteSourceProvider(remoteSourceProvider));
-	}
-
 	context.subscriptions.push(registerBuiltinGitProvider(apiImpl));
 	const liveshareGitProvider = registerLiveShareGitProvider(apiImpl);
 	context.subscriptions.push(liveshareGitProvider);
 	const liveshareApiPromise = liveshareGitProvider.initialize();
 
 	context.subscriptions.push(apiImpl);
-	registerGlobalCommands(context, gitAPI, credentialStore);
 
 	Logger.appendLine('Looking for git repository');