Don't allow in checks, make unused vars error (#7648)

Author: alexr00

.eslintrc.base.json

@@ -66,6 +66,13 @@
 		"no-useless-return": "off",
 		"no-var": "error",
 		"no-with": "error",
+		"no-restricted-syntax": [
+			"error",
+			{
+				"selector": "BinaryExpression[operator='in']",
+				"message": "Avoid using the 'in' operator for type checks."
+			}
+		],
 		"object-shorthand": "off",
 		"one-var": "off", // TODO@eamodio revisit
 		// "one-var": ["error", "never"],
@@ -230,7 +237,7 @@
 		"@typescript-eslint/no-unsafe-member-access": "off", // TODO@eamodio revisit
 		"@typescript-eslint/no-unsafe-return": "off", // TODO@eamodio revisit
 		"@typescript-eslint/no-unused-expressions": ["warn", { "allowShortCircuit": true }],
-		"@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_" }],
+		"@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "^_" }],
 		// "@typescript-eslint/no-unused-vars": [
 		// 	"warn",
 		// 	{

common/sessionParsing.ts

@@ -64,6 +64,12 @@ export interface StrReplaceEditorToolData {
 	parsedContent?: { content: string; fileA: string | undefined; fileB: string | undefined; };
 }
 
+export namespace StrReplaceEditorToolData {
+	export function is(value: any): value is StrReplaceEditorToolData {
+		return value && (typeof value.command === 'string');
+	}
+}
+
 export interface BashToolData {
 	commandLine: {
 		original: string;

src/commands.ts

@@ -651,12 +651,17 @@ export function registerCommands(
 		return { folderManager, pr };
 	};
 
+	function contextHasPath(ctx: OverviewContext | { path: string } | undefined): ctx is { path: string } {
+		const contextAsPath: Partial<{ path: string }> = (ctx as { path: string });
+		return !!contextAsPath.path;
+	}
+
 	context.subscriptions.push(vscode.commands.registerCommand('pr.checkoutFromDescription', async (ctx: OverviewContext | { path: string } | undefined) => {
 		if (!ctx) {
 			return vscode.window.showErrorMessage(vscode.l10n.t('No pull request context provided for checkout.'));
 		}
 
-		if ('path' in ctx) {
+		if (contextHasPath(ctx)) {
 			const { path } = ctx;
 			const prNumber = Number(Buffer.from(path.substring(1), 'base64').toString('utf8'));
 			if (Number.isNaN(prNumber)) {

src/gitProviders/vslsguest.ts

@@ -122,6 +122,7 @@ class LiveShareRepositoryProxyHandler {
 	constructor() { }
 
 	get(obj: any, prop: any) {
+		// eslint-disable-next-line no-restricted-syntax
 		if (prop in obj) {
 			return obj[prop];
 		}

src/github/copilotRemoteAgent.ts

@@ -5,7 +5,7 @@
 
 import * as pathLib from 'path';
 import vscode from 'vscode';
-import { parseSessionLogs, parseToolCallDetails } from '../../common/sessionParsing';
+import { parseSessionLogs, parseToolCallDetails, StrReplaceEditorToolData } from '../../common/sessionParsing';
 import { COPILOT_ACCOUNTS } from '../common/comment';
 import { CopilotRemoteAgentConfig } from '../common/config';
 import { COPILOT_LOGINS, COPILOT_SWE_AGENT, CopilotPRStatus, mostRecentCopilotEvent } from '../common/copilot';
@@ -15,9 +15,8 @@ import Logger from '../common/logger';
 import { GitHubRemote } from '../common/remote';
 import { CODING_AGENT, CODING_AGENT_AUTO_COMMIT_AND_PUSH } from '../common/settingKeys';
 import { ITelemetry } from '../common/telemetry';
-import { DataUri, toOpenPullRequestWebviewUri } from '../common/uri';
+import { toOpenPullRequestWebviewUri } from '../common/uri';
 import { dateFromNow } from '../common/utils';
-import { getIconForeground, getListErrorForeground, getListWarningForeground, getNotebookStatusSuccessIconForeground } from '../view/theme';
 import { copilotEventToSessionStatus, IAPISessionLogs, ICopilotRemoteAgentCommandArgs, ICopilotRemoteAgentCommandResponse, OctokitCommon, RemoteAgentResult, RepoInfo } from './common';
 import { ChatSessionWithPR, CopilotApi, getCopilotApi, RemoteAgentJobPayload, SessionInfo, SessionSetupStep } from './copilotApi';
 import { CopilotPRWatcher, CopilotStateModel } from './copilotPrWatcher';
@@ -1180,7 +1179,7 @@ export class CopilotRemoteAgentManager extends Disposable {
 				toolPart.originMessage = new vscode.MarkdownString(toolDetails.originMessage);
 			}
 			if (toolDetails.toolSpecificData) {
-				if ('command' in toolDetails.toolSpecificData) {
+				if (StrReplaceEditorToolData.is(toolDetails.toolSpecificData)) {
 					if ((toolDetails.toolSpecificData.command === 'view' || toolDetails.toolSpecificData.command === 'edit') && toolDetails.toolSpecificData.fileLabel) {
 						const uri = vscode.Uri.file(pathLib.join(pullRequest.githubRepository.rootUri.fsPath, toolDetails.toolSpecificData.fileLabel));
 						toolPart.invocationMessage = new vscode.MarkdownString(`${toolPart.toolName} [](${uri.toString()})`);

src/github/copilotRemoteAgent/chatSessionContentBuilder.ts

@@ -5,7 +5,7 @@
 
 import * as nodePath from 'path';
 import vscode from 'vscode';
-import { parseSessionLogs, parseToolCallDetails } from '../../../common/sessionParsing';
+import { parseSessionLogs, parseToolCallDetails, StrReplaceEditorToolData } from '../../../common/sessionParsing';
 import { COPILOT_SWE_AGENT } from '../../common/copilot';
 import Logger from '../../common/logger';
 import { CommentEvent, CopilotFinishedEvent, CopilotStartedEvent, EventType, ReviewEvent, TimelineEvent } from '../../common/timelineEvent';
@@ -369,7 +369,7 @@ export class ChatSessionContentBuilder {
 				toolPart.originMessage = new vscode.MarkdownString(toolDetails.originMessage);
 			}
 			if (toolDetails.toolSpecificData) {
-				if ('command' in toolDetails.toolSpecificData) {
+				if (StrReplaceEditorToolData.is(toolDetails.toolSpecificData)) {
 					if ((toolDetails.toolSpecificData.command === 'view' || toolDetails.toolSpecificData.command === 'edit') && toolDetails.toolSpecificData.fileLabel) {
 						const uri = vscode.Uri.file(nodePath.join(pullRequest.githubRepository.rootUri.fsPath, toolDetails.toolSpecificData.fileLabel));
 						toolPart.invocationMessage = new vscode.MarkdownString(`${toolPart.toolName} [](${uri.toString()})`);

src/view/compareChangesTreeDataProvider.ts

@@ -166,7 +166,8 @@ abstract class CompareChangesTreeProvider extends Disposable implements vscode.T
 
 			return { rawFiles, rawCommits, mergeBase };
 		} catch (e) {
-			if ('name' in e && e.name === 'HttpError' && e.status === 404) {
+			const eWithName: Partial<{ name: string; status: number }> = e;
+			if (e.name && eWithName.name === 'HttpError' && eWithName.status === 404) {
 				(this.view as vscode.TreeView2<TreeNode>).message = new vscode.MarkdownString(vscode.l10n.t('The upstream branch `{0}` does not exist on GitHub', this.model.baseBranch));
 			}
 			return {};