Fix user avatar display in comment widget for GitHub Enterprise (#8551)

* Initial plan

* Changes before error encountered

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Initial plan for fixing avatar display in comment widget for GitHub Enterprise

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Fix avatar display in comment widget for GitHub Enterprise

Apply isGitHubDotComAvatar check to comment widget code to prevent
broken avatar display for GitHub Enterprise users. For enterprise
avatars (non-githubusercontent.com URLs), skip fetching the avatar
and show no icon instead of a broken image.

Fixes:
- setReplyAuthor() in utils.ts (reply area avatar)
- TemporaryComment constructor in prComment.ts
- GHPRComment constructor in prComment.ts

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Add parens

* Merge branch 'main' into copilot/fix-avatar-in-comment-widget

Author: Copilot

src/github/prComment.ts

@@ -175,7 +175,7 @@ export class TemporaryComment extends CommentBase {
 		this.mode = vscode.CommentMode.Preview;
 		this.originalAuthor = {
 			name: currentUser.specialDisplayName ?? currentUser.login,
-			iconPath: currentUser.avatarUrl ? vscode.Uri.parse(`${currentUser.avatarUrl}&s=64`) : undefined,
+			iconPath: (currentUser.avatarUrl && DataUri.isGitHubDotComAvatar(currentUser.avatarUrl)) ? vscode.Uri.parse(`${currentUser.avatarUrl}&s=64`) : undefined,
 		};
 		this.label = isDraft ? vscode.l10n.t('Pending') : undefined;
 		this.state = isDraft ? vscode.CommentState.Draft : vscode.CommentState.Published;
@@ -238,12 +238,12 @@ export class GHPRComment extends CommentBase {
 		this.rawComment = comment;
 		this.originalAuthor = {
 			name: comment.user?.specialDisplayName ?? comment.user!.login,
-			iconPath: comment.user && comment.user.avatarUrl ? vscode.Uri.parse(comment.user.avatarUrl) : undefined,
+			iconPath: (comment.user && comment.user.avatarUrl && DataUri.isGitHubDotComAvatar(comment.user.avatarUrl)) ? vscode.Uri.parse(comment.user.avatarUrl) : undefined,
 		};
 		const url = vscode.Uri.parse(comment.url);
 		this.githubRepository = githubRepositories?.find(repo => repo.remote.host === url.authority);
 
-		const avatarUrisPromise = comment.user ? DataUri.avatarCirclesAsImageDataUris(context, [comment.user], 28, 28) : Promise.resolve([]);
+		const avatarUrisPromise = (comment.user && DataUri.isGitHubDotComAvatar(comment.user.avatarUrl)) ? DataUri.avatarCirclesAsImageDataUris(context, [comment.user], 28, 28) : Promise.resolve([]);
 		this.doSetBody(comment.body, !comment.user).then(async () => { // only refresh if there's no user. If there's a user, we'll refresh in the then.
 			const avatarUris = await avatarUrisPromise;
 			if (avatarUris.length > 0) {

src/github/utils.ts

@@ -104,6 +104,10 @@ export function threadRange(startLine: number, endLine: number, endCharacter?: n
 export async function setReplyAuthor(thread: vscode.CommentThread | vscode.CommentThread2, currentUser: IAccount, context: vscode.ExtensionContext) {
 	if (currentUser.avatarUrl) {
 		const thread2 = thread as vscode.CommentThread2;
+		if (!DataUri.isGitHubDotComAvatar(currentUser.avatarUrl)) {
+			thread2.canReply = { name: currentUser.name ?? currentUser.login, iconPath: undefined };
+			return;
+		}
 		thread2.canReply = { name: currentUser.name ?? currentUser.login, iconPath: vscode.Uri.parse(currentUser.avatarUrl) };
 		const uri = await DataUri.avatarCirclesAsImageDataUris(context, [currentUser], 28, 28);
 		thread2.canReply = { name: currentUser.name ?? currentUser.login, iconPath: uri[0] };